Uh oh!
There was an error while loading. Please reload this page.
Implement IS UNKNOWN/IS NOT UNKNOWN operators - #3246
Conversation
isidentical
commented
Aug 24, 2022
Also CC: @sarahyurick |
andygrove
commented
Aug 24, 2022
Thanks @isidentical! I think we can go and merge this and then add the type checking once my PR is merged (which could take a while). I filed #3247 to track this. |
isidentical
commented
Aug 24, 2022
Thanks @andygrove! I've subscribed to your PR, so hopefully once it is merged I can start working on the type-checking phase in another PR. |
codecov-commenter
commented
Aug 24, 2022
Codecov Report
@@ Coverage Diff @@## master #3246 +/- ##
=======================================
Coverage 85.84% 85.85% =======================================
Files 293 293 Lines 53246 53284 +38 =======================================
+ Hits 45710 45747 +37 - Misses 7536 7537 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ursabot
commented
Aug 24, 2022
Benchmark runs are scheduled for baseline = bdc56ca and contender = 94dacce. 94dacce is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes#3195.
Rationale for this change
This PR implements
IS UNKNOWNandIS NOT UNKNOWNSQL operations (similar to #3235).What changes are included in this PR?
The transformation of SQL-level
IS UNKNOWN/IS NOT UNKNOWNoperations toIS DISTINCT FROMqueries in the logical level.Are there any user-facing changes?
2 new operators.
@andygroveI assume that just like #3225, this would also require some type-checking. Should we implement it afterwards, or should we wait your PR and I can make the required changes in this PR.