Skip to content

Support "IS NOT TRUE/FALSE" syntax - #3252

Merged
andygrove merged 1 commit into
apache:masterfrom
sarahyurick:is_not_true_false
Aug 24, 2022
Merged

Support "IS NOT TRUE/FALSE" syntax#3252
andygrove merged 1 commit into
apache:masterfrom
sarahyurick:is_not_true_false

Conversation

@sarahyurick

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes#2265

What changes are included in this PR?

Similar to #3235 and #3246, this PR adds the "IS NOT TRUE" and "IS NOT FALSE" boolean operations and their SQL-level tests.

@github-actionsgithub-actionsBot added core Core DataFusion crate sql SQL Planner labels Aug 24, 2022
@sarahyurick

Copy link
Copy Markdown
ContributorAuthor

@andygrove this should also be included in #3247

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #3252 (b78a756) into master (94dacce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #3252 +/- ##
=======================================
Coverage 85.85% 85.86% =======================================
Files 293 293 Lines 53284 53322 +38 =======================================
+ Hits 45747 45784 +37 - Misses 7537 7538 +1 
Impacted FilesCoverage Δ
datafusion/core/tests/sql/expr.rs99.86% <100.00%> (+<0.01%)⬆️
datafusion/sql/src/planner.rs80.66% <100.00%> (+0.07%)⬆️
datafusion/expr/src/logical_plan/plan.rs78.21% <0.00%> (-0.35%)⬇️
datafusion/common/src/scalar.rs84.65% <0.00%> (+0.06%)⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ursabot

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = bcb660e and contender = 2de77fb. 2de77fb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion cratesqlSQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support "IS NOT TRUE/FALSE" syntax

4 participants

@sarahyurick@codecov-commenter@ursabot@andygrove