Skip to content

[Enhance](DOE)Support parse default es iso datetime string - #17412

Merged
stalary merged 4 commits into
apache:masterfrom
SaintBacchus:EsIsotime
Mar 10, 2023
Merged

[Enhance](DOE)Support parse default es iso datetime string#17412
stalary merged 4 commits into
apache:masterfrom
SaintBacchus:EsIsotime

Conversation

@SaintBacchus

@SaintBacchusSaintBacchus commented Mar 4, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Using cctz to parse default es iso datetime string;

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@SaintBacchus

SaintBacchus commented Mar 4, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Mar 4, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

stalary
stalary reviewed Mar 8, 2023
View reviewed changes
Comment threaddocker/thirdparties/custom_settings.env Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsUtil.java Outdated
Comment threadregression-test/conf/regression-conf.groovy Outdated
@github-actions

github-actionsBot commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

3 similar comments
@github-actions

github-actionsBot commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actionsBot commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

stalary
stalary approved these changes Mar 9, 2023
View reviewed changes

@stalarystalary left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SaintBacchus

SaintBacchus commented Mar 9, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 9, 2023
@github-actions

github-actionsBot commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@SaintBacchus

SaintBacchus commented Mar 9, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

3 similar comments
@SaintBacchus

SaintBacchus commented Mar 9, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@SaintBacchus

SaintBacchus commented Mar 9, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@stalary

stalary commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

run p0

@stalary
stalary merged commit 4ba93ef into apache:masterMar 10, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@SaintBacchus@gnehil
[Enhance](DOE)Support parse default es iso datetime string (apache#17412
c711e49
)
* support parse default es iso datetime string
qidaye pushed a commit to qidaye/incubator-doris that referenced this pull request Aug 7, 2023
@SaintBacchus@qidaye
[Enhance](DOE)Support parse default es iso datetime string (apache#17412
8f04edb
)
* support parse default es iso datetime string
@qidayeqidaye mentioned this pull request Aug 8, 2023
Merged
morningman pushed a commit that referenced this pull request Aug 8, 2023
@qidaye
[pick](DOE) pick doe fixes from master to branch-1.2-lts (#22685)
2bcf6c2
PRs:
1. #17566 2. #17412 3. #17745 4. #22279 5. #22046 6. #22423
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 7, 2023
@qidayecaiconghui1
[pick](DOE) pick doe fixes from master to branch-1.2-lts (apache#22685)
9bc5fbf
PRs:
1. apache#17566 2. apache#17412 3. apache#17745 4. apache#22279 5. apache#22046 6. apache#22423
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stalarystalarystalary approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/1.2.3kind/testreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SaintBacchus@stalary@morningman