Skip to content

[BugFix](Es Catalog) fix bug that es catalog will return error when query partial columns - #22423

Merged
yiguolei merged 2 commits into
apache:masterfrom
BePPPower:fixEs
Aug 4, 2023
Merged

[BugFix](Es Catalog) fix bug that es catalog will return error when query partial columns#22423
yiguolei merged 2 commits into
apache:masterfrom
BePPPower:fixEs

Conversation

@BePPPower

@BePPPowerBePPPower commented Jul 31, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Bug：
When the value of some ES column is empty, querying these value in doc_values mode will receive an error.

Reson：
In doc values mode, these values are empty, We need to determine if the array is empty

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions

github-actionsBot commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@BePPPower

BePPPower commented Aug 3, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actionsBot commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

morningman
morningman approved these changes Aug 3, 2023
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 3, 2023
@github-actions

github-actionsBot commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

qidaye
qidaye approved these changes Aug 3, 2023
View reviewed changes

@qidayeqidaye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added dev/2.0.0 2.0.0 release and removed dev/2.0.1 labels Aug 4, 2023
@hello-stephen

hello-stephen commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.9 seconds
stream load tsv: 512 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162405185 Bytes

@yiguolei
yiguolei merged commit bad8237 into apache:masterAug 4, 2023
@xiaokangxiaokang added dev/2.0.0-merged and removed dev/2.0.0 2.0.0 release labels Aug 4, 2023
xiaokang pushed a commit that referenced this pull request Aug 4, 2023
@BePPPower@xiaokang
[BugFix](Es Catalog) fix bug that es catalog will return error when q…
96a80c2
…uery partial columns (#22423)
Bug：
When the value of some ES column is empty, querying these value in doc_values mode will receive an error.
Reson：
In doc values mode, these values are empty, We need to determine if the array is empty
qidaye pushed a commit to qidaye/incubator-doris that referenced this pull request Aug 7, 2023
@BePPPower@qidaye
[BugFix](Es Catalog) fix bug that es catalog will return error when q…
d2821e9
…uery partial columns (apache#22423)
Bug：
When the value of some ES column is empty, querying these value in doc_values mode will receive an error.
Reson：
In doc values mode, these values are empty, We need to determine if the array is empty
qidaye pushed a commit to qidaye/incubator-doris that referenced this pull request Aug 7, 2023
@BePPPower@qidaye
[BugFix](Es Catalog) fix bug that es catalog will return error when q…
eaf149e
…uery partial columns (apache#22423)
Bug：
When the value of some ES column is empty, querying these value in doc_values mode will receive an error.
Reson：
In doc values mode, these values are empty, We need to determine if the array is empty
@qidayeqidaye mentioned this pull request Aug 8, 2023
Merged
morningman pushed a commit that referenced this pull request Aug 8, 2023
@qidaye
[pick](DOE) pick doe fixes from master to branch-1.2-lts (#22685)
2bcf6c2
PRs:
1. #17566 2. #17412 3. #17745 4. #22279 5. #22046 6. #22423
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 7, 2023
@qidayecaiconghui1
[pick](DOE) pick doe fixes from master to branch-1.2-lts (apache#22685)
9bc5fbf
PRs:
1. apache#17566 2. apache#17412 3. apache#17745 4. apache#22279 5. apache#22046 6. apache#22423
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
@qidayeqidayeqidaye approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BePPPower@hello-stephen@morningman@qidaye@xiaokang@yiguolei