Skip to content

[BugFix](DOE) Add http prefix when it's not set in hosts properties. - #17745

Merged
stalary merged 4 commits into
apache:masterfrom
SaintBacchus:DOE17722
Mar 21, 2023
Merged

[BugFix](DOE) Add http prefix when it's not set in hosts properties.#17745
stalary merged 4 commits into
apache:masterfrom
SaintBacchus:DOE17722

Conversation

@SaintBacchus

@SaintBacchusSaintBacchus commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close#17722

Problem summary

Add http prefix when it's not set in hosts properties.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@SaintBacchus

SaintBacchus commented Mar 13, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Mar 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.81 seconds
stream load tsv: 465 seconds loaded 74807831229 Bytes, about 153 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230319065929_clickbench_pr_116709.html

@SaintBacchus

SaintBacchus commented Mar 14, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

1 similar comment
@SaintBacchus

SaintBacchus commented Mar 14, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

stalary
stalary reviewed Mar 14, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/catalog/EsTable.java Outdated
@SaintBacchus

SaintBacchus commented Mar 14, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@SaintBacchus

SaintBacchus commented Mar 14, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

1 similar comment
@SaintBacchus

SaintBacchus commented Mar 15, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@SaintBacchus

SaintBacchus commented Mar 15, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@SaintBacchus

SaintBacchus commented Mar 15, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

stalary
stalary reviewed Mar 15, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/datasource/EsExternalCatalog.java Outdated
stalary
stalary previously approved these changes Mar 15, 2023
View reviewed changes

@stalarystalary left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stalary

stalary commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 15, 2023
@github-actions

github-actionsBot commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@SaintBacchus

SaintBacchus commented Mar 15, 2023

Copy link
Copy Markdown
ContributorAuthor

run p1

1 similar comment
@SaintBacchus

SaintBacchus commented Mar 15, 2023

Copy link
Copy Markdown
ContributorAuthor

run p1

@stalary

stalary commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

run p0

@SaintBacchus

SaintBacchus commented Mar 16, 2023

Copy link
Copy Markdown
ContributorAuthor

run p1

@SaintBacchus

SaintBacchus commented Mar 16, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@SaintBacchus

SaintBacchus commented Mar 16, 2023

Copy link
Copy Markdown
ContributorAuthor

run p1

@SaintBacchus

SaintBacchus commented Mar 16, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Mar 16, 2023
@SaintBacchus

SaintBacchus commented Mar 16, 2023

Copy link
Copy Markdown
ContributorAuthor

run clickbench

1 similar comment
@SaintBacchus

SaintBacchus commented Mar 16, 2023

Copy link
Copy Markdown
ContributorAuthor

run clickbench

@SaintBacchus

SaintBacchus commented Mar 16, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

1 similar comment
@SaintBacchus

SaintBacchus commented Mar 16, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@SaintBacchus

SaintBacchus commented Mar 16, 2023

Copy link
Copy Markdown
ContributorAuthor

run clickbench

@SaintBacchus

SaintBacchus commented Mar 17, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@SaintBacchus

SaintBacchus commented Mar 17, 2023

Copy link
Copy Markdown
ContributorAuthor

run clickbench

1 similar comment
@SaintBacchus

SaintBacchus commented Mar 17, 2023

Copy link
Copy Markdown
ContributorAuthor

run clickbench

@SaintBacchus

SaintBacchus commented Mar 17, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@SaintBacchus

SaintBacchus commented Mar 17, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

2 similar comments
@SaintBacchus

SaintBacchus commented Mar 17, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@SaintBacchus

SaintBacchus commented Mar 17, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@SaintBacchus

SaintBacchus commented Mar 18, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@SaintBacchus

SaintBacchus commented Mar 18, 2023

Copy link
Copy Markdown
ContributorAuthor

run arm

@SaintBacchus

SaintBacchus commented Mar 18, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@SaintBacchus

SaintBacchus commented Mar 19, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@SaintBacchus

SaintBacchus commented Mar 19, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

2 similar comments
@SaintBacchus

SaintBacchus commented Mar 19, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@SaintBacchus

SaintBacchus commented Mar 20, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@SaintBacchus

SaintBacchus commented Mar 20, 2023

Copy link
Copy Markdown
ContributorAuthor

run arm

stalary
stalary approved these changes Mar 21, 2023
View reviewed changes

@stalarystalary left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stalary
stalary merged commit 4023670 into apache:masterMar 21, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@SaintBacchus@gnehil
[BugFix](DOE) Add http prefix when it's not set in hosts properties. (a…
51ef7e2
…pache#17745)
* Add http prefix when it's not set in hosts properties
qidaye pushed a commit to qidaye/incubator-doris that referenced this pull request Aug 7, 2023
@SaintBacchus@qidaye
[BugFix](DOE) Add http prefix when it's not set in hosts properties. (a…
66f7313
…pache#17745)
* Add http prefix when it's not set in hosts properties
@qidayeqidaye mentioned this pull request Aug 8, 2023
Merged
morningman pushed a commit that referenced this pull request Aug 8, 2023
@qidaye
[pick](DOE) pick doe fixes from master to branch-1.2-lts (#22685)
2bcf6c2
PRs:
1. #17566 2. #17412 3. #17745 4. #22279 5. #22046 6. #22423
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 7, 2023
@qidayecaiconghui1
[pick](DOE) pick doe fixes from master to branch-1.2-lts (apache#22685)
9bc5fbf
PRs:
1. apache#17566 2. apache#17412 3. apache#17745 4. apache#22279 5. apache#22046 6. apache#22423
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stalarystalarystalary approved these changes

Assignees

No one assigned

Labels

dev/1.2.3kind/testreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] (DOE) hosts protocol access exception

4 participants

@SaintBacchus@hello-stephen@stalary@morningman