Skip to content

[improve](docker) docker base image add perf and pprof for CPU profile - #50536

Merged
catpineapple merged 4 commits into
apache:masterfrom
catpineapple:perf-base-image
Apr 29, 2025
Merged

[improve](docker) docker base image add perf and pprof for CPU profile #50536
catpineapple merged 4 commits into
apache:masterfrom
catpineapple:perf-base-image

Conversation

@catpineapple

@catpineapplecatpineapple commented Apr 29, 2025•
edited
Loading

Copy link
Copy Markdown
Member

What problem does this PR solve?

Add the environment dependency of running CPU profile to the docker base image

Related PR: #40330

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@catpineapple

catpineapple commented Apr 29, 2025

Copy link
Copy Markdown
MemberAuthor

run buildall

@catpineapple

catpineapple commented Apr 29, 2025

Copy link
Copy Markdown
MemberAuthor

run buildall

intelligentfu8
intelligentfu8 previously approved these changes Apr 29, 2025
View reviewed changes

@intelligentfu8intelligentfu8 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 29, 2025
@github-actions

github-actionsBot commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

zy-kkk
zy-kkk previously approved these changes Apr 29, 2025
View reviewed changes
@catpineapple
catpineapple dismissed stale reviews from zy-kkk and intelligentfu8 via 587f82bApril 29, 2025 07:31
@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Apr 29, 2025
@zy-kkk
zy-kkk self-requested a review April 29, 2025 07:34
intelligentfu8
intelligentfu8 approved these changes Apr 29, 2025
View reviewed changes

@intelligentfu8intelligentfu8 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 29, 2025
@catpineapple

catpineapple commented Apr 29, 2025

Copy link
Copy Markdown
MemberAuthor

run buildall

@shuke987

shuke987 commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

skip buildall

@catpineapple
catpineapple merged commit b5bb57a into apache:masterApr 29, 2025
@catpineapple
catpineapple deleted the perf-base-image branch April 30, 2025 02:21
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@catpineapplekoarz
[improve](docker) docker base image add perf and pprof for CPU profile (
de57bc0
apache#50536)
### What problem does this PR solve?
Add the environment dependency of running CPU profile to the docker base
image
Related PR: apache#40330 Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [x] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
morrySnow pushed a commit to morrySnow/incubator-doris that referenced this pull request Mar 26, 2026
@catpineapple
pick: sync docker/runtime/ from upstream apache/doris master (apache#…
db6af27
…7561)
Cherry-pick all docker/runtime/ changes from apache/doris master that
are missing in branch-hotfix-selectdb-doris-3.1-hubspot.
Includes changes from PRs:
apache#42068apache#42208apache#42564apache#42605apache#43040apache#43085apache#43200apache#45503apache#45926apache#46387apache#47342apache#47837apache#48183apache#48839apache#48898apache#49343apache#49874apache#50247apache#50536apache#50604apache#50745apache#50922apache#51357apache#51693apache#54321apache#54392apache#54950apache#55299apache#55548apache#55615apache#55671apache#55824apache#56471apache#56757apache#56917apache#57113apache#57236apache#57345apache#57374apache#57695apache#58229apache#58565apache#58638apache#59039apache#59292apache#59480apache#59553apache#60060apache#60458
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
Co-authored-by: catpineapple <catpineapple@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zy-kkkzy-kkkzy-kkk approved these changes
@intelligentfu8intelligentfu8intelligentfu8 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@catpineapple@hello-stephen@shuke987@zy-kkk@intelligentfu8