Skip to content

[opt](doris compose) stop command wait fe / be dead - #50745

Merged
englefly merged 13 commits into
apache:masterfrom
yujun777:fix-docker-compose-unstable
May 14, 2025
Merged

[opt](doris compose) stop command wait fe / be dead#50745
englefly merged 13 commits into
apache:masterfrom
yujun777:fix-docker-compose-unstable

Conversation

@yujun777

@yujun777yujun777 commented May 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

in docker suites, when stop be / fe, the master fe heartbeat may be delay due to wait rpc timeout, so even be is dead, fe maynot found it dead until next heartbeat.

so regression's stop command need to check fe / be had been dead from master fe's perspective.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented May 9, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yujun777

yujun777 commented May 9, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@yujun777
yujun777force-pushed the fix-docker-compose-unstable branch from 0f733f5 to 7bcb206CompareMay 12, 2025 06:21
@yujun777

yujun777 commented May 12, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@yujun777

yujun777 commented May 12, 2025

Copy link
Copy Markdown
ContributorAuthor

run external

@yujun777

yujun777 commented May 13, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

1 similar comment
@yujun777

yujun777 commented May 13, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@yujun777
yujun777force-pushed the fix-docker-compose-unstable branch from 5a45e42 to bb0dadbCompareMay 13, 2025 06:32
@yujun777

yujun777 commented May 13, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

deardeng
deardeng approved these changes May 13, 2025
View reviewed changes

@deardengdeardeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented May 13, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yujun777

yujun777 commented May 13, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@yujun777yujun777 reopened this May 14, 2025
@yujun777

yujun777 commented May 14, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 14, 2025
@github-actions

github-actionsBot commented May 14, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@englefly
englefly merged commit e2e52c5 into apache:masterMay 14, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@yujun777koarz
[opt](doris compose) stop command wait fe / be dead (apache#50745)
deb9e82
### What problem does this PR solve?
in docker suites, when stop be / fe, the master fe heartbeat may be
delay due to wait rpc timeout, so even be is dead, fe maynot found it
dead until next heartbeat.
so regression's stop command need to check fe / be had been dead from
master fe's perspective.
morrySnow pushed a commit to morrySnow/incubator-doris that referenced this pull request Mar 26, 2026
@catpineapple
pick: sync docker/runtime/ from upstream apache/doris master (apache#…
db6af27
…7561)
Cherry-pick all docker/runtime/ changes from apache/doris master that
are missing in branch-hotfix-selectdb-doris-3.1-hubspot.
Includes changes from PRs:
apache#42068apache#42208apache#42564apache#42605apache#43040apache#43085apache#43200apache#45503apache#45926apache#46387apache#47342apache#47837apache#48183apache#48839apache#48898apache#49343apache#49874apache#50247apache#50536apache#50604apache#50745apache#50922apache#51357apache#51693apache#54321apache#54392apache#54950apache#55299apache#55548apache#55615apache#55671apache#55824apache#56471apache#56757apache#56917apache#57113apache#57236apache#57345apache#57374apache#57695apache#58229apache#58565apache#58638apache#59039apache#59292apache#59480apache#59553apache#60060apache#60458
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
Co-authored-by: catpineapple <catpineapple@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@engleflyengleflyenglefly approved these changes
@deardengdeardengdeardeng approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yujun777@Thearas@englefly@deardeng