Skip to content

[feat](doris compose) fix start be check ulimit fail and add env variables - #58229

Merged
starocean999 merged 2 commits into
apache:masterfrom
yujun777:doris-compose-ulimit
Nov 24, 2025
Merged

[feat](doris compose) fix start be check ulimit fail and add env variables#58229
starocean999 merged 2 commits into
apache:masterfrom
yujun777:doris-compose-ulimit

Conversation

@yujun777

@yujun777yujun777 commented Nov 21, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

  1. fix start be failed:
❯ cat be.out
INFO: java_cmd /usr/local/openjdk-17/bin/java
INFO: jdk_version 17
Set max number of open file descriptors to a value greater than 60000.
Ask your system manager to modify /etc/security/limits.conf and append content like
* soft nofile 655350
* hard nofile 655350
and then run 'ulimit -n 655350' to take effect on current session.
  1. add env variables
python doris-compose.py up --env name1=value1 name2=value2

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yujun777

yujun777 commented Nov 21, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@yujun777yujun777 changed the title [fix](doris compose) fix start be check ulimit -n fail[feat](doris compose) fix start be check ulimit fail and add env variablesNov 21, 2025
@yujun777

yujun777 commented Nov 21, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

deardeng
deardeng approved these changes Nov 21, 2025
View reviewed changes

@deardengdeardeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yujun777

yujun777 commented Nov 23, 2025

Copy link
Copy Markdown
ContributorAuthor

fix nonConcurrent

@yujun777

yujun777 commented Nov 23, 2025

Copy link
Copy Markdown
ContributorAuthor

run nonConcurrent

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 24, 2025
@github-actions

github-actionsBot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@starocean999
starocean999 merged commit 85b4b2e into apache:masterNov 24, 2025
30 checks passed
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@yujun777@nagisa-kunhah
[feat](doris compose) fix start be check ulimit fail and add env vari…
ac510a2
…ables (apache#58229)
1. fix start be failed:
```
❯ cat be.out
INFO: java_cmd /usr/local/openjdk-17/bin/java
INFO: jdk_version 17
Set max number of open file descriptors to a value greater than 60000.
Ask your system manager to modify /etc/security/limits.conf and append content like
* soft nofile 655350
* hard nofile 655350
and then run 'ulimit -n 655350' to take effect on current session.
```
2. add env variables ```
python doris-compose.py up --env name1=value1 name2=value2
```
morrySnow pushed a commit to morrySnow/incubator-doris that referenced this pull request Mar 26, 2026
@catpineapple
pick: sync docker/runtime/ from upstream apache/doris master (apache#…
db6af27
…7561)
Cherry-pick all docker/runtime/ changes from apache/doris master that
are missing in branch-hotfix-selectdb-doris-3.1-hubspot.
Includes changes from PRs:
apache#42068apache#42208apache#42564apache#42605apache#43040apache#43085apache#43200apache#45503apache#45926apache#46387apache#47342apache#47837apache#48183apache#48839apache#48898apache#49343apache#49874apache#50247apache#50536apache#50604apache#50745apache#50922apache#51357apache#51693apache#54321apache#54392apache#54950apache#55299apache#55548apache#55615apache#55671apache#55824apache#56471apache#56757apache#56917apache#57113apache#57236apache#57345apache#57374apache#57695apache#58229apache#58565apache#58638apache#59039apache#59292apache#59480apache#59553apache#60060apache#60458
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
Co-authored-by: catpineapple <catpineapple@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deardengdeardengdeardeng approved these changes
@starocean999starocean999starocean999 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yujun777@hello-stephen@deardeng@starocean999