Skip to content

HBASE-22198 Fix flakey TestAsyncTableGetMultiThreaded - #135

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22198
Apr 10, 2019
Merged

HBASE-22198 Fix flakey TestAsyncTableGetMultiThreaded#135
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22198

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec32Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall289master passed
+1compile55master passed
+1checkstyle72master passed
+1shadedjars268branch has no errors when building our shaded downstream artifacts.
-1findbugs166hbase-server in master has 11 extant Findbugs warnings.
+1javadoc34master passed
_ Patch Compile Tests _
+1mvninstall250the patch passed
+1compile54the patch passed
+1javac54the patch passed
+1checkstyle67the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars269patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck518Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs169the patch passed
+1javadoc33the patch passed
_ Other Tests _
+1unit8496hbase-server in the patch passed.
+1asflicense25The patch does not generate ASF License warnings.
10877
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-135/1/artifact/out/Dockerfile
GITHUB PR#135
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 11c595129294 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 494a8ef
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-135/1/artifact/out/branch-findbugs-hbase-server-warnings.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-135/1/testReport/
Max. process+thread count5292 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-135/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

The findbugs warnings are not introduced by this patch.

break;
}
} catch (IOException e) {
LOG.warn("Failed to query");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the difference is here ? even if the region is not online, we'll retry unti exhaust or fail ?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UT aims to test whether we can deal with region moving/splitting, so it is possible that the region is not online at some point, but the admin method will not fail immediately without retrying, which is not like what we do in normal get/put operation, so here we need to catch the exception and use an external RetryCounter to retry. Otherwise it will cause the test to fail.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@openinx