Skip to content

HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone - #1446

Merged
busbey merged 4 commits into
apache:masterfrom
busbey:HBASE-23723
Apr 8, 2020
Merged

HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone#1446
busbey merged 4 commits into
apache:masterfrom
busbey:HBASE-23723

Conversation

@busbey

@busbeybusbey commented Apr 7, 2020

Copy link
Copy Markdown
Contributor

This is broken up into 3 commits that should be squashed before merging.

  • First refactor the MOB compaction tests so that they do more code reuse, so we can add our test(s) once and cover the various configuration options (tests should still pass after this commit)
  • Next add test(s) for when a snapshot clone happens to ensure we still properly can compact (the write amplification optimized tests will start to fail here)
  • Fix how we keep track of mob reference files so that we can tell where they ought to be in the filesystem even after a snapshot clone, essentially by aggregating at the hfile level the amount of information we have when resolving a given cell (tests should again pass)

busbey
busbey commented Apr 7, 2020
View reviewed changes
Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionWithDefaults.java
*/
@SuppressWarnings("deprecation")
@Category(LargeTests.class)
public class TestMobCompactionWithDefaults {

@busbeybusbeyApr 7, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is a rename of TestMobCompactionBase that's then combined with TestMobCompactionRegularMode.java. I'm not sure why the github UI doesn't show it as that. my local git client can see it.

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@busbey

busbey commented Apr 7, 2020

Copy link
Copy Markdown
ContributorAuthor

the shaded jars failure is a problem introduced in HBASE-24801 / #1392. I believe the fix has since landed.

I restarted the QAbot

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@busbey

busbey commented Apr 8, 2020

Copy link
Copy Markdown
ContributorAuthor

JDK8 unit test failure looks like an environment issue.

busbey
busbey commented Apr 8, 2020
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreFlusher.java Outdated
@Apache-HBase

Apache-HBase commented Apr 8, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall5m 14smaster passed
+1 💚checkstyle1m 31smaster passed
+1 💚spotbugs2m 42smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall5m 18sthe patch passed
+1 💚checkstyle0m 27sThe patch passed checkstyle in hbase-common
+1 💚checkstyle1m 5shbase-server: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck10m 18sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs3m 1sthe patch passed
_ Other Tests _
+1 💚asflicense0m 23sThe patch does not generate ASF License warnings.
38m 18s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1446
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 3e81e755f6c3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c383bd1
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 8, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 52sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 30sMaven dependency ordering for branch
+1 💚mvninstall5m 20smaster passed
+1 💚compile1m 17smaster passed
+1 💚shadedjars4m 44sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 55smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall5m 10sthe patch passed
+1 💚compile1m 15sthe patch passed
+1 💚javac1m 15sthe patch passed
+1 💚shadedjars4m 38spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 56sthe patch passed
_ Other Tests _
+1 💚unit1m 16shbase-common in the patch passed.
-1 ❌unit134m 15shbase-server in the patch failed.
163m 37s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1446
Optional Testsjavac javadoc unit shadedjars compile
unameLinux eaa5a105467d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c383bd1
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/testReport/
Max. process+thread count3962 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 8, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 52sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 37sMaven dependency ordering for branch
+1 💚mvninstall6m 21smaster passed
+1 💚compile1m 32smaster passed
+1 💚shadedjars5m 26sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 18shbase-common in master failed.
-0 ⚠️javadoc0m 42shbase-server in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall6m 20sthe patch passed
+1 💚compile1m 31sthe patch passed
+1 💚javac1m 31sthe patch passed
+1 💚shadedjars6m 14spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 20shbase-common in the patch failed.
-0 ⚠️javadoc0m 51shbase-server in the patch failed.
_ Other Tests _
+1 💚unit1m 46shbase-common in the patch passed.
-1 ❌unit134m 12shbase-server in the patch failed.
169m 41s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1446
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4f8dc77888f3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c383bd1
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/testReport/
Max. process+thread count3612 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

esteban
esteban reviewed Apr 8, 2020
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreFlusher.java Outdated
@Apache-HBase

Apache-HBase commented Apr 8, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall5m 24smaster passed
+1 💚checkstyle1m 33smaster passed
+1 💚spotbugs2m 41smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall5m 3sthe patch passed
+1 💚checkstyle0m 24sThe patch passed checkstyle in hbase-common
+1 💚checkstyle1m 6shbase-server: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck10m 30sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs3m 2sthe patch passed
_ Other Tests _
+1 💚asflicense0m 26sThe patch does not generate ASF License warnings.
38m 43s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1446
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 858bb8dc805e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ed83022
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@busbey

busbey commented Apr 8, 2020

Copy link
Copy Markdown
ContributorAuthor

unit test failures on latest qabot run all look like env issues on unrelated code.

@busbey
busbey requested a review from estebanApril 8, 2020 19:06
@esteban

esteban commented Apr 8, 2020

Copy link
Copy Markdown
Contributor

+1 lgtm.

@busbey
busbey merged commit eb7df04 into apache:masterApr 8, 2020
@busbey
busbey deleted the HBASE-23723 branch April 8, 2020 19:16
@busbey

busbey commented Apr 8, 2020

Copy link
Copy Markdown
ContributorAuthor

thanks for the review!

@Apache-HBase

Apache-HBase commented Apr 8, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 36sMaven dependency ordering for branch
+1 💚mvninstall8m 37smaster passed
+1 💚compile1m 56smaster passed
+1 💚shadedjars7m 14sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 22shbase-common in master failed.
-0 ⚠️javadoc0m 49shbase-server in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall8m 29sthe patch passed
+1 💚compile1m 55sthe patch passed
+1 💚javac1m 55sthe patch passed
+1 💚shadedjars7m 11spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 18shbase-common in the patch failed.
-0 ⚠️javadoc0m 41shbase-server in the patch failed.
_ Other Tests _
+1 💚unit1m 38shbase-common in the patch passed.
+1 💚unit126m 57shbase-server in the patch passed.
170m 24s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1446
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 42f65b77b233 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ed83022
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/testReport/
Max. process+thread count3970 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 8, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 36sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 39sMaven dependency ordering for branch
+1 💚mvninstall6m 48smaster passed
+1 💚compile1m 31smaster passed
+1 💚shadedjars5m 30sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 6smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall6m 56sthe patch passed
+1 💚compile1m 51sthe patch passed
+1 💚javac1m 51sthe patch passed
+1 💚shadedjars5m 56spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 7sthe patch passed
_ Other Tests _
+1 💚unit1m 41shbase-common in the patch passed.
+1 💚unit193m 42shbase-server in the patch passed.
230m 48s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1446
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5c92a0dfc097 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ed83022
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/testReport/
Max. process+thread count3521 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@busbey@thangTang
HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…
78e7df2
…hot clone (apache#1446)
* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@busbey@thangTang
HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…
b5bafbf
…hot clone (apache#1446)
* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@busbey@thangTang
HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…
e10757b
…hot clone (apache#1446)
* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@busbey
HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…
e2bdeea
…hot clone (apache#1446)
* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.
(cherry picked from commit eb7df04)
Change-Id: Ie3dc11f9cd5cd3b0ed39e260891d240a0e391d61
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
Author: Sean Busbey
Reason: Bug
Ref: CDPD-10138
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@busbey
HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…
449fea1
…hot clone (apache#1446)
* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.
(cherry picked from commit eb7df04)
Change-Id: Ie3dc11f9cd5cd3b0ed39e260891d240a0e391d61
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
Author: Sean Busbey
Reason: Bug
Ref: CDPD-10138
apurtell pushed a commit to apurtell/hbase that referenced this pull request Jul 12, 2022
@busbey@apurtell
HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…
8fcbdfd
…hot clone (apache#1446)
* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Jul 13, 2022
@busbey@apurtell
HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…
1290c7d
…hot clone (apache#1446)
* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Jul 19, 2022
@busbey@apurtell
HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…
7053461
…hot clone (apache#1446)
* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
huaxiangsun pushed a commit that referenced this pull request Aug 12, 2022
@apurtell@busbey
HBASE-23723Ensure MOB compaction works in optimized mode after snaps…
f36b349
…hot clone (#4617)
* HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (#1446)
* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
* spotless:apply to fix HBaseTestingUtility
* Fix error-prone errors
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
Co-authored-by: Sean Busbey <busbey@apache.org>
huaxiangsun pushed a commit to huaxiangsun/hbase that referenced this pull request Aug 12, 2022
@apurtell@busbeyHuaxiang Sun
HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…
997e4da
…hot clone (apache#4617)
* HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (apache#1446)
* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
* spotless:apply to fix HBaseTestingUtility
* Fix error-prone errors
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
Co-authored-by: Sean Busbey <busbey@apache.org>
@huaxiangsunhuaxiangsun mentioned this pull request Aug 12, 2022
Merged
huaxiangsun added a commit that referenced this pull request Aug 15, 2022
@huaxiangsun@apurtell@busbey
HBASE-23723Ensure MOB compaction works in optimized mode after snaps…
e595f15
…hot clone (#4617) (#4704)
* HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (#1446)
* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
* spotless:apply to fix HBaseTestingUtility
* Fix error-prone errors
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
Co-authored-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
Co-authored-by: Andrew Purtell <apurtell@apache.org>
Co-authored-by: Sean Busbey <busbey@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@busbey@nkalmar
HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…
5527238
…hot clone (apache#1446)
* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
This commit does not contain secrets
Change-Id: I558daa648248789ac5f4ffd51967035618be6960
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebanestebanAwaiting requested review from esteban

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@busbey@Apache-HBase@esteban