Uh oh!
There was an error while loading. Please reload this page.
HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone - #4617
Conversation
apurtell
commented
Jul 12, 2022
All MOB unit tests pass for me locally: [INFO] ------------------------------------------------------- |
Apache-HBase
commented
Jul 13, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2022
🎊 +1 overall
This message was automatically generated. |
BukrosSzabolcs
commented
Jul 13, 2022
I got the same results: |
apurtell
commented
Jul 13, 2022
Ah, I changed HBaseTestingUtility and then did not run spotless after. Pushed updates to fix that. |
Apache-HBase
commented
Jul 13, 2022
💔 -1 overall
This message was automatically generated. |
5b3f765 to
45713c1CompareApache-HBase
commented
Jul 13, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2022
💔 -1 overall
This message was automatically generated. |
apurtell
commented
Jul 13, 2022
Precommit test failures are similar to recent flakes on other issues, and are not related to this change. |
apurtell
commented
Jul 13, 2022
A similar error-prone finding as before, but in a different file. |
45713c1 to
ebf4a17CompareApache-HBase
commented
Jul 13, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 14, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 14, 2022
🎊 +1 overall
This message was automatically generated. |
…hot clone (apache#1446) * Reorganize MOB compaction tests for more reuse. * Add tests for mob compaction after snapshot clone operations * note the original table used to write a given mob hfile and use that to find it later. Signed-off-by: Esteban Gutierrez <esteban@apache.org>
ebf4a17 to
6c4035dCompareapurtell
commented
Jul 19, 2022
Working on old information, a github page rendering that was not updating properly, I thought the build was still failing in compilation due to error-prone and changed how the IOExceptions are formatted again, this time with string concatenation instead of String#format. I assume this is not a problem @wchevreuil and will go ahead and merge this if I don't hear back in 24 hours or so. |
Apache-HBase
commented
Jul 19, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 19, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 19, 2022
🎊 +1 overall
This message was automatically generated. |
huaxiangsun
commented
Aug 12, 2022
Seems everything is good, merge it to branch-2 and do a backport to branch-2.5. |
…hot clone (apache#4617) * HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (apache#1446) * Reorganize MOB compaction tests for more reuse. * Add tests for mob compaction after snapshot clone operations * note the original table used to write a given mob hfile and use that to find it later. Signed-off-by: Esteban Gutierrez <esteban@apache.org> * spotless:apply to fix HBaseTestingUtility * Fix error-prone errors Signed-off-by: Esteban Gutierrez <esteban@apache.org> Co-authored-by: Sean Busbey <busbey@apache.org>
…hot clone (#4617) (#4704) * HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (#1446) * Reorganize MOB compaction tests for more reuse. * Add tests for mob compaction after snapshot clone operations * note the original table used to write a given mob hfile and use that to find it later. Signed-off-by: Esteban Gutierrez <esteban@apache.org> * spotless:apply to fix HBaseTestingUtility * Fix error-prone errors Signed-off-by: Esteban Gutierrez <esteban@apache.org> Co-authored-by: Sean Busbey <busbey@apache.org> Signed-off-by: Esteban Gutierrez <esteban@apache.org> Co-authored-by: Andrew Purtell <apurtell@apache.org> Co-authored-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Esteban Gutierrez esteban@apache.org
Ported to branch-2 for HBASE-27154
Co-authored-by: Andrew Purtell apurtell@apache.org