Skip to content

HBASE-23723 Ensure MOB compaction works in optimized mode after snaps… - #4704

Merged
huaxiangsun merged 1 commit into
apache:branch-2.5from
huaxiangsun:branch-2.5.HBASE-23723
Aug 15, 2022
Merged

HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…#4704
huaxiangsun merged 1 commit into
apache:branch-2.5from
huaxiangsun:branch-2.5.HBASE-23723

Conversation

@huaxiangsun

Copy link
Copy Markdown
Contributor

…hot clone (#4617)

Signed-off-by: Esteban Gutierrez esteban@apache.org

  • spotless:apply to fix HBaseTestingUtility

  • Fix error-prone errors

Signed-off-by: Esteban Gutierrez esteban@apache.org
Co-authored-by: Sean Busbey busbey@apache.org

…hot clone (apache#4617)
* HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (apache#1446)
* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
* spotless:apply to fix HBaseTestingUtility
* Fix error-prone errors
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
Co-authored-by: Sean Busbey <busbey@apache.org>
@huaxiangsunhuaxiangsun added the backport This PR is a back port of some issue or issues already committed to master label Aug 12, 2022
@huaxiangsun

Copy link
Copy Markdown
ContributorAuthor

A backport from branch-2 to branch-2.5.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 12sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 16sbranch-2.5 passed
+1 💚compile2m 46sbranch-2.5 passed
+1 💚checkstyle0m 46sbranch-2.5 passed
+1 💚spotless0m 46sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 46sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 8sthe patch passed
+1 💚compile2m 45sthe patch passed
-0 ⚠️javac0m 31shbase-common generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154)
-0 ⚠️javac2m 14shbase-server generated 4 new + 189 unchanged - 4 fixed = 193 total (was 193)
+1 💚checkstyle0m 45sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck15m 27sPatch does not cause any errors with Hadoop 2.10.1 or 3.1.2 3.2.2 3.3.1.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
+1 💚spotbugs1m 58sthe patch passed
_ Other Tests _
+1 💚asflicense0m 20sThe patch does not generate ASF License warnings.
39m 21s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4704
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 86d1affa1621 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / da472aa
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count60 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 52sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 28sbranch-2.5 passed
+1 💚compile0m 50sbranch-2.5 passed
+1 💚shadedjars4m 0sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 9sthe patch passed
+1 💚compile0m 51sthe patch passed
+1 💚javac0m 51sthe patch passed
+1 💚shadedjars4m 0spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35sthe patch passed
_ Other Tests _
+1 💚unit1m 41shbase-common in the patch passed.
-1 ❌unit187m 6shbase-server in the patch failed.
210m 13s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4704
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6775756d6dd4 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / da472aa
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/testReport/
Max. process+thread count2160 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 36sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 22sbranch-2.5 passed
+1 💚compile1m 10sbranch-2.5 passed
+1 💚shadedjars4m 34sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 47sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall2m 59sthe patch passed
+1 💚compile1m 15sthe patch passed
+1 💚javac1m 15sthe patch passed
+1 💚shadedjars4m 41spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 28shbase-server generated 1 new + 90 unchanged - 0 fixed = 91 total (was 90)
_ Other Tests _
+1 💚unit1m 57shbase-common in the patch passed.
+1 💚unit216m 52shbase-server in the patch passed.
242m 12s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4704
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3fc95726a348 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / da472aa
Default JavaAdoptOpenJDK-11.0.10+9
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/testReport/
Max. process+thread count2315 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@huaxiangsun

Copy link
Copy Markdown
ContributorAuthor

I run the failed test case TestSplitRegionWhileRSCrash locally, it passed.

@huaxiangsun
huaxiangsun merged commit e595f15 into apache:branch-2.5Aug 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@huaxiangsun@Apache-HBase@apurtell