Skip to content

HBASE-22323 Fixed broken Thrift generation - #196

Merged
HorizonNet merged 1 commit into
apache:masterfrom
ultratendency:HBASE-22323
Apr 29, 2019
Merged

HBASE-22323 Fixed broken Thrift generation#196
HorizonNet merged 1 commit into
apache:masterfrom
ultratendency:HBASE-22323

Conversation

@HorizonNet

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec18Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall269master passed
+1compile31master passed
+1checkstyle33master passed
+1shadedjars271branch has no errors when building our shaded downstream artifacts.
+1findbugs79master passed
+1javadoc29master passed
_ Patch Compile Tests _
+1mvninstall253the patch passed
+1compile31the patch passed
+1javac31the patch passed
-1checkstyle33hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1whitespace0The patch has no whitespace issues.
+1shadedjars274patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck554Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs101the patch passed
+1javadoc35the patch passed
_ Other Tests _
+1unit213hbase-thrift in the patch passed.
+1asflicense10The patch does not generate ASF License warnings.
2317
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/1/artifact/out/Dockerfile
GITHUB PR#196
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux d333e1cc4f79 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 4477dd5
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/1/artifact/out/diff-checkstyle-hbase-thrift.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/1/testReport/
Max. process+thread count2029 (vs. ulimit of 10000)
modulesC: hbase-thrift U: hbase-thrift
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec23Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1mvninstall250master passed
+1compile31master passed
+1checkstyle33master passed
+1shadedjars259branch has no errors when building our shaded downstream artifacts.
+1findbugs78master passed
+1javadoc30master passed
_ Patch Compile Tests _
+1mvninstall238the patch passed
+1compile32the patch passed
+1javac32the patch passed
+1checkstyle33the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars256patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck502Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs92the patch passed
+1javadoc31the patch passed
_ Other Tests _
+1unit206hbase-thrift in the patch passed.
+1asflicense11The patch does not generate ASF License warnings.
2176
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/2/artifact/out/Dockerfile
GITHUB PR#196
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 645702b6315b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 5b07ee9
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/2/testReport/
Max. process+thread count1971 (vs. ulimit of 10000)
modulesC: hbase-thrift U: hbase-thrift
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet
HorizonNet merged commit 882bbdb into apache:masterApr 29, 2019
@HorizonNet
HorizonNet deleted the HBASE-22323 branch April 29, 2019 17:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HorizonNet@Apache-HBase@Apache9