Uh oh!
There was an error while loading. Please reload this page.
HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… - #5802
Conversation
stoty
commented
Apr 9, 2024
Using Caffeine instead of Guava Cache, as recommended by Guava. |
Apache-HBase
commented
Apr 9, 2024
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 9, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 9, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 9, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 9, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 9, 2024
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 9, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 9, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 9, 2024
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 9, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 9, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 9, 2024
🎊 +1 overall
This message was automatically generated. |
stoty
commented
Apr 9, 2024
Oops, this is actually two commits. |
Apache-HBase
commented
Apr 10, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 10, 2024
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 10, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 10, 2024
💔 -1 overall
This message was automatically generated. |
| DEFAULT_REST_SCANNERCACHE_EXPIRE_TIME_MS, TimeUnit.MILLISECONDS); | ||
| Cache<String, ScannerInstanceResource> cache = | ||
| Caffeine.newBuilder() |
There was a problem hiding this comment.
Any reason we are not using org.apache.hbase.thirdparty.com.google.common.cache.CacheBuilder?
There was a problem hiding this comment.
The Guava documenatation itself suggests using this one instead.
There was a problem hiding this comment.
This one is supposed to be better (though perf doesn't matter that much in this case), and the the docs imply that the Guava one is not actively developed anymore.
We already use this library elsewhere.
Apache-HBase
commented
Apr 15, 2024
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2024
🎊 +1 overall
This message was automatically generated. |
…vent scanner leakage Signed-off-by: Peter Somogyi <psomogyi@apache.org> Change-Id: I6a2f3a6398a68297db91cb8980ce80085ecfd7cb
stoty
commented
Apr 15, 2024
Ruined formatting by spotless. |
Apache-HBase
commented
Apr 15, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2024
🎊 +1 overall
This message was automatically generated. |
…vent scanner leakage (#5802) Signed-off-by: Peter Somogyi <psomogyi@apache.org>
…vent scanner leakage (#5802) Signed-off-by: Peter Somogyi <psomogyi@apache.org>
…vent scanner leakage (#5802) Signed-off-by: Peter Somogyi <psomogyi@apache.org>
…vent scanner leakage (#5802) Signed-off-by: Peter Somogyi <psomogyi@apache.org>
…vent scanner leakage (#5802) Signed-off-by: Peter Somogyi <psomogyi@apache.org>
…vent scanner leakage (apache#5802) Signed-off-by: Peter Somogyi <psomogyi@apache.org>
…vent scanner leakage (apache#5802) Signed-off-by: Peter Somogyi <psomogyi@apache.org> Change-Id: I7bd7b6991d69644024bdd34eb68cd70ec3aeafe4
…vent scanner leakage