Uh oh!
There was an error while loading. Please reload this page.
HBASE-28239 Auto create configured namespaces - #5841
Open
chandrasekhar-188k wants to merge 1 commit into
Open
Conversation
Apache-HBase
commented
Apr 21, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 21, 2024
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 21, 2024
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 21, 2024
💔 -1 overall
This message was automatically generated. |
Apache9
reviewed
Apr 22, 2024
| String[] customNamespaces = | ||
| env.getMasterConfiguration().getStrings(ADDITIONAL_NAMESPACES); | ||
| if (null != customNamespaces && customNamespaces.length > 0) { | ||
| Arrays.stream(customNamespaces).forEach(ns -> { |
Contributor
There was a problem hiding this comment.
Why not just follow the regular way to create these namespaces?
We have to insert system namespace here because meta table is in this namespace, so there is a cyclic dependency...
For other namespaces, I suggest to create them with your own operational scripts or some management systems, from outside the cluster.
ContributorAuthor
There was a problem hiding this comment.
This improvement provides a config option for operators to create the additional namespaces during the HBase startup. This would eliminate the need to wrap createTable calls in checkAndCreateNamespace or provide separate cluster bootstrap functionality to guarantee that the namespace is created.
Contributor
There was a problem hiding this comment.
But the code can only take effect when initializing the cluster, i.e, on the first startup of this HBase cluster... If later you changed the configuration and restart the hbase cluster, it will not take effect.
I think this will confuse our users...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.