Uh oh!
There was an error while loading. Please reload this page.
HBASE-24735: Refactor ReplicationSourceManager: move logPositionAndCl… - #2064
Conversation
Apache-HBase
commented
Jul 14, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 14, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 14, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 15, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 15, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 15, 2020
💔 -1 overall
This message was automatically generated. |
bharathv
left a comment
There was a problem hiding this comment.
nice cleanup, minor comments and then +1
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| entryBatch.getLastWalPosition(), entryBatch.getLastSeqIds())); | ||
| } | ||
| /** |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
27dab4e to
6f28e3bCompareApache-HBase
commented
Jul 21, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 21, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 21, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 21, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 21, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 21, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 10, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 10, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 10, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 10, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 10, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 10, 2020
🎊 +1 overall
This message was automatically generated. |
| protected final ConcurrentHashMap<String, ReplicationSourceShipper> workerThreads = | ||
| new ConcurrentHashMap<>(); | ||
| private AtomicLong totalBufferUsed; |
There was a problem hiding this comment.
Since we are cleaning out this extra, unnecessary variable, could we make "this.manager" package private (or provide a package private getter), so that source readers and source shippers don't have to define an additional reference to ReplicationSourceManager?
There was a problem hiding this comment.
Good idea. Let me refator it. And after I rethink about this, the ReplicationSourceManager is still needed by ReplicationSource. But only need the getTotalBuffered/getTotalLimit/getGlobalMetrics now. Maybe introduce a new interface in the future.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…eanOldLogs/cleanUpHFileRefs to ReplicationSource inside
Apache-HBase
commented
Aug 11, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 11, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 11, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 11, 2020
🎊 +1 overall
This message was automatically generated. |
wchevreuil
left a comment
There was a problem hiding this comment.
Latest UT failure seems unrelated. +1
Apache-HBase
commented
Aug 11, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 11, 2020
🎊 +1 overall
This message was automatically generated. |
…eanOldLogs/cleanUpHFileRefs to ReplicationSource inside (apache#2064) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…eanOldLogs/cleanUpHFileRefs to ReplicationSource inside (#2064) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…eanOldLogs/cleanUpHFileRefs to ReplicationSource inside (#2064) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…eanOldLogs/cleanUpHFileRefs to ReplicationSource inside (#2064) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…eanOldLogs/cleanUpHFileRefs to ReplicationSource inside (#2064) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…eanOldLogs/cleanUpHFileRefs to ReplicationSource inside (#2064) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…eanOldLogs/cleanUpHFileRefs to ReplicationSource inside (#2064) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…eanOldLogs/cleanUpHFileRefs to ReplicationSource inside (#2064) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…eanOldLogs/cleanUpHFileRefs to ReplicationSource inside (#2064) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…eanOldLogs/cleanUpHFileRefs to ReplicationSource inside (#2064) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…eanOldLogs/cleanUpHFileRefs to ReplicationSource inside