Skip to content

HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports - #2854

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-25333
Jan 9, 2021
Merged

HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports#2854
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-25333

Conversation

@Apache9

@Apache9Apache9 commented Jan 7, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this Jan 7, 2021
@Apache9
Apache9 requested a review from apurtellJanuary 7, 2021 04:04
@Apache-HBase

Apache-HBase commented Jan 7, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 19sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck20m 54sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
_ Other Tests _
+1 💚asflicense0m 18sThe patch does not generate ASF License warnings.
31m 32s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2854
Optional Testsdupname asflicense hadoopcheck xml
unameLinux b98958fc5b59 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a414361
Max. process+thread count76 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 7, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 16sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 47smaster passed
+1 💚compile3m 5smaster passed
+1 💚shadedjars7m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 8smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 35sthe patch passed
+1 💚compile3m 10sthe patch passed
+1 💚javac3m 10sthe patch passed
+1 💚shadedjars7m 23spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 4sthe patch passed
_ Other Tests _
+1 💚unit245m 18sroot in the patch passed.
285m 22s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2854
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9fcab4c4083d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a414361
Default JavaAdoptOpenJDK-11.0.6+10
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/1/testReport/
Max. process+thread count4488 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Jan 8, 2021

Copy link
Copy Markdown
ContributorAuthor

Ping @apurtell.

And @petersomogyi FYI.

petersomogyi
petersomogyi reviewed Jan 8, 2021
View reviewed changes
Comment threadpom.xml Outdated
<restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">
<includeTestCode>true</includeTestCode>
<commentLineBufferSize>512</commentLineBufferSize>
<reason>Use RestrictedApi annotation in error prone instead</reason>

@petersomogyipetersomogyiJan 8, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HBASE-24640 replaced VisibleForTesting with IA.Private annotation. The reason in this restrictImports should recommend the same.

@Apache9Apache9Jan 8, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this is the case. Even in IA.Public classes, not all the IA.Private annotations are for testing, and here we are telling a more general rule, not only for IA.Public classes. Saying that use IA.Private instead of VisibleForTesting will make developers confusing.
Let me see if I could make things more clear.

@Apache9Apache9Jan 8, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the wording. PTAL. Thanks.

@Apache-HBase

Apache-HBase commented Jan 8, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck17m 31sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
_ Other Tests _
+1 💚asflicense0m 19sThe patch does not generate ASF License warnings.
25m 0s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2854
Optional Testsdupname asflicense hadoopcheck xml
unameLinux be5615f08817 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 45ef88d
Max. process+thread count76 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 8, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 16sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 41smaster passed
+1 💚compile3m 8smaster passed
+1 💚shadedjars7m 19sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 5smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 29sthe patch passed
+1 💚compile3m 6sthe patch passed
+1 💚javac3m 6sthe patch passed
+1 💚shadedjars7m 24spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 3sthe patch passed
_ Other Tests _
+1 💚unit256m 2sroot in the patch passed.
295m 39s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2854
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 47b5f77eedf0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 45ef88d
Default JavaAdoptOpenJDK-11.0.6+10
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/testReport/
Max. process+thread count4545 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 8, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 9smaster passed
+1 💚compile2m 38smaster passed
+1 💚shadedjars7m 14sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 13smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 48sthe patch passed
+1 💚compile2m 36sthe patch passed
+1 💚javac2m 36sthe patch passed
+1 💚shadedjars7m 10spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 12sthe patch passed
_ Other Tests _
+1 💚unit383m 27sroot in the patch passed.
418m 32s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2854
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d08b4343c78b 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 45ef88d
Default JavaAdoptOpenJDK-1.8.0_232-b09
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/testReport/
Max. process+thread count4470 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 8, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚hadoopcheck19m 9sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
27m 53s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2854
Optional Testsdupname asflicense hadoopcheck xml
unameLinux 9f0ce4e2377a 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5c233e9
Max. process+thread count63 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 8, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 28sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 46smaster passed
+1 💚compile3m 8smaster passed
+1 💚shadedjars7m 23sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 8smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 32sthe patch passed
+1 💚compile3m 9sthe patch passed
+1 💚javac3m 9sthe patch passed
+1 💚shadedjars7m 21spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 6sthe patch passed
_ Other Tests _
+1 💚unit289m 15sroot in the patch passed.
330m 3s
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2854
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2d726b89cdde 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5c233e9
Default JavaAdoptOpenJDK-11.0.6+10
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/testReport/
Max. process+thread count4261 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 8, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 15sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 51smaster passed
+1 💚compile2m 41smaster passed
+1 💚shadedjars7m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 12smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 49sthe patch passed
+1 💚compile2m 37sthe patch passed
+1 💚javac2m 37sthe patch passed
+1 💚shadedjars7m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 13sthe patch passed
_ Other Tests _
+1 💚unit384m 29sroot in the patch passed.
419m 41s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2854
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 21643e088cd1 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5c233e9
Default JavaAdoptOpenJDK-1.8.0_232-b09
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/testReport/
Max. process+thread count4626 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 4925a64 into apache:masterJan 9, 2021
Apache9 added a commit that referenced this pull request Jan 9, 2021
@Apache9
HBASE-25333Add maven enforcer rule to ban VisibleForTesting imports (#…
75f5cb2
…2854)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Apache9 added a commit that referenced this pull request Jan 9, 2021
@Apache9
HBASE-25333Add maven enforcer rule to ban VisibleForTesting imports (#…
751431d
…2854)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersomogyipetersomogyipetersomogyi approved these changes
@apurtellapurtellAwaiting requested review from apurtell

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@petersomogyi