Uh oh!
There was an error while loading. Please reload this page.
HBASE-25482 Improve SimpleRegionNormalizer#getAverageRegionSizeMb - #2858
Conversation
Apache-HBase
commented
Jan 8, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 8, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 8, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 11, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 11, 2021
🎊 +1 overall
This message was automatically generated. |
| final long totalSizeMb = tableRegions.stream() | ||
| .mapToLong(this::getRegionSizeMB) | ||
| .sum(); |
There was a problem hiding this comment.
Sorry, just to be sure on the goal here, this is just to avoid this loop always happen, even when totalSizeMb is not been used?
There was a problem hiding this comment.
Yes, this is origin goal. If we set NormalizerTargetRegionSize, we use NormalizerTargetRegionSize as avgRegionSize and return. But now I found another serious bug, NormalizerTargetRegionCount and NormalizerTargetRegionSize will never used when log level is not debug.
Apache-HBase
commented
Jan 11, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 14, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 14, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 14, 2021
🎊 +1 overall
This message was automatically generated. |
ndimiduk
commented
Jan 14, 2021
Any further comments/concerns @wchevreuil ? |
…ache#2858) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
…ache#2858) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
…ache#2858) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
HBASE-25482
If the table is set NormalizerTargetRegionSize, we take NormalizerTargetRegionSize as avgRegionSize and return it. So the totalSizeMb of table is not always calculated.