HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase… by joshelser · Pull Request #2878 · apache/hbase

joshelser · 2021-01-12T15:50:25Z

…-default.xml

Revert of the revert -- re-applying HBASE-25449 with a change
of renaming the test hdfs XML configuration file as it was adversely
affecting tests using MiniDFS

This reverts commit c218e57.

Co-authored-by: Josh Elser elserj@apache.org

fyi @shenshengli

…-default.xml Revert of the revert -- re-applying HBASE-25449 with a change of renaming the test hdfs XML configuration file as it was adversely affecting tests using MiniDFS This reverts commit c218e57. Co-authored-by: Josh Elser <elserj@apache.org>

joshelser · 2021-01-12T15:51:24Z

A revision on #2816. Trivial changing of the src/test/resources/hdfs-default.xml file to another name and updating the UT.

Includes a change to hbase-server/pom.xml to try to get the full test suite to run (or at least some tests using MiniDFS)

Apache-HBase · 2021-01-12T16:47:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 54s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 36s	master passed
+1 💚	checkstyle	1m 49s	master passed
+0 🆗	refguide	3m 52s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	3m 5s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 1s	the patch passed
+1 💚	checkstyle	1m 35s	the patch passed
-0 ⚠️	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	xml	0m 5s	The patch has no ill-formed XML file.
+0 🆗	refguide	3m 40s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	19m 40s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 10s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 24s	The patch does not generate ASF License warnings.
		56m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2878
Optional Tests	dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 3580e44d010c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c218e57`
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/1/artifact/yetus-general-check/output/branch-site/book.html
whitespace	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/1/artifact/yetus-general-check/output/whitespace-eol.txt
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/1/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-12T19:54:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 38s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 47s	master passed
+1 💚	compile	1m 38s	master passed
+1 💚	shadedjars	7m 29s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 6s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 34s	the patch passed
+1 💚	compile	1m 38s	the patch passed
+1 💚	javac	1m 38s	the patch passed
+1 💚	shadedjars	7m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 12s	hbase-common in the patch passed.
+1 💚	unit	206m 59s	hbase-server in the patch passed.
		242m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2878
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e9ab64f2c0b0 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c218e57`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/1/testReport/
Max. process+thread count	3537 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-12T19:56:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 0s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 11s	master passed
+1 💚	compile	1m 24s	master passed
+1 💚	shadedjars	7m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 53s	the patch passed
+1 💚	compile	1m 24s	the patch passed
+1 💚	javac	1m 24s	the patch passed
+1 💚	shadedjars	7m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 31s	hbase-common in the patch passed.
+1 💚	unit	211m 20s	hbase-server in the patch passed.
		245m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2878
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux be830361c0d6 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c218e57`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/1/testReport/
Max. process+thread count	3788 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Seems the pre commit result is fine.

Let me kick another run to see if it is stable.

Apache-HBase · 2021-01-13T16:16:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 20s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 32s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 0s	master passed
+1 💚	compile	4m 22s	master passed
+1 💚	checkstyle	1m 43s	master passed
+0 🆗	refguide	4m 5s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	3m 10s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 5s	the patch passed
+1 💚	compile	6m 6s	the patch passed
+1 💚	javac	6m 6s	the patch passed
+1 💚	checkstyle	2m 23s	the patch passed
-0 ⚠️	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	xml	0m 6s	The patch has no ill-formed XML file.
+0 🆗	refguide	5m 28s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	20m 55s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 8s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 21s	The patch does not generate ASF License warnings.
		71m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2878
Optional Tests	dupname asflicense javac refguide xml spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 05e08f085c6b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dfefff7`
Default Java	AdoptOpenJDK-1.8.0_232-b09
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/artifact/yetus-general-check/output/branch-site/book.html
whitespace	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/artifact/yetus-general-check/output/whitespace-eol.txt
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-13T17:54:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 20s	master passed
+1 💚	compile	1m 36s	master passed
+1 💚	shadedjars	6m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 5s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 9s	the patch passed
+1 💚	compile	1m 35s	the patch passed
+1 💚	javac	1m 35s	the patch passed
+1 💚	shadedjars	7m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 48s	hbase-common in the patch passed.
+1 💚	unit	136m 34s	hbase-server in the patch passed.
		169m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2878
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fe283594ae26 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dfefff7`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/testReport/
Max. process+thread count	3934 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-13T19:14:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 13s	master passed
+1 💚	compile	1m 47s	master passed
+1 💚	shadedjars	8m 4s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 26s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 32s	the patch passed
+1 💚	compile	2m 10s	the patch passed
+1 💚	javac	2m 10s	the patch passed
+1 💚	shadedjars	9m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 28s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 55s	hbase-common in the patch passed.
+1 💚	unit	208m 44s	hbase-server in the patch passed.
		249m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2878
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9141838d55ac 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dfefff7`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/testReport/
Max. process+thread count	3597 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2878/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

shenshengli · 2021-01-14T01:00:09Z

Thank you for your revision so that this change can proceed quickly.

joshelser requested a review from Apache9 January 12, 2021 15:50

petersomogyi approved these changes Jan 13, 2021
View reviewed changes

Apache9 reviewed Jan 13, 2021
View reviewed changes

Comment threadhbase-common/src/main/resources/hbase-default.xml

Apache9 approved these changes Jan 13, 2021
View reviewed changes

saintstack approved these changes Jan 13, 2021
View reviewed changes

joshelser closed this Jan 14, 2021

joshelser mentioned this pull request Jan 14, 2021
HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml #2816
Closed

Navigation Menu

Uh oh!

HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase… - #2878

HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase…#2878
joshelser wants to merge 1 commit into
apache:masterfrom
joshelser:25449-reapply

joshelser commented Jan 12, 2021

Uh oh!

joshelser commented Jan 12, 2021

Uh oh!

Apache-HBase commented Jan 12, 2021

Uh oh!

Apache-HBase commented Jan 12, 2021

Uh oh!

Apache-HBase commented Jan 12, 2021

Uh oh!

Uh oh!

Apache9 left a comment

Uh oh!

Apache-HBase commented Jan 13, 2021

Uh oh!

Apache-HBase commented Jan 13, 2021

Uh oh!

Apache-HBase commented Jan 13, 2021

Uh oh!

shenshengli commented Jan 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

joshelser commented Jan 12, 2021

Uh oh!

joshelser commented Jan 12, 2021

Uh oh!

Apache-HBase commented Jan 12, 2021

Uh oh!

Apache-HBase commented Jan 12, 2021

Uh oh!

Apache-HBase commented Jan 12, 2021

Uh oh!

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jan 13, 2021

Uh oh!

Apache-HBase commented Jan 13, 2021

Uh oh!

Apache-HBase commented Jan 13, 2021

Uh oh!

shenshengli commented Jan 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants