Skip to content

HBASE-25512 May throw StringIndexOutOfBoundsException when construct illegal tablename error - #2884

Merged
saintstack merged 1 commit into
apache:masterfrom
zhengzhuobinzzb:illegal-tablename-error-message-opt
Feb 8, 2021
Merged

HBASE-25512 May throw StringIndexOutOfBoundsException when construct illegal tablename error#2884
saintstack merged 1 commit into
apache:masterfrom
zhengzhuobinzzb:illegal-tablename-error-message-opt

Conversation

@zhengzhuobinzzb

@zhengzhuobinzzbzhengzhuobinzzb commented Jan 15, 2021

Copy link
Copy Markdown
Contributor

fix bug: string out of bounds when construct illegal tablename error

@Apache-HBase

Apache-HBase commented Jan 15, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 33smaster passed
+1 💚compile0m 26smaster passed
+1 💚shadedjars6m 59sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 28smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 13sthe patch passed
+1 💚compile0m 28sthe patch passed
+1 💚javac0m 28sthe patch passed
+1 💚shadedjars6m 38spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
+1 💚unit1m 35shbase-common in the patch passed.
27m 30s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2884
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1e140ee35abe 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3cc2468
Default JavaAdoptOpenJDK-11.0.6+10
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/testReport/
Max. process+thread count278 (vs. ulimit of 30000)
modulesC: hbase-common U: hbase-common
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 15, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 14sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 13smaster passed
+1 💚compile0m 22smaster passed
+1 💚shadedjars7m 16sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 21smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 20sthe patch passed
+1 💚compile0m 22sthe patch passed
+1 💚javac0m 22sthe patch passed
+1 💚shadedjars7m 17spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 19sthe patch passed
_ Other Tests _
+1 💚unit1m 32shbase-common in the patch passed.
28m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2884
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3d61f1641492 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3cc2468
Default JavaAdoptOpenJDK-1.8.0_232-b09
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/testReport/
Max. process+thread count229 (vs. ulimit of 30000)
modulesC: hbase-common U: hbase-common
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 15, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 55smaster passed
+1 💚compile0m 52smaster passed
+1 💚checkstyle0m 24smaster passed
+1 💚spotbugs0m 43smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 28sthe patch passed
+1 💚compile0m 48sthe patch passed
+1 💚javac0m 48sthe patch passed
+1 💚checkstyle0m 24sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck17m 51sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs0m 51sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
37m 24s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2884
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux aa9c725a63ef 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3cc2468
Default JavaAdoptOpenJDK-1.8.0_232-b09
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-common U: hbase-common
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@saintstack

saintstack commented Jan 15, 2021

Copy link
Copy Markdown
Contributor

Patch looks good but please file an accompanying JIRA over here https://issues.apache.org/jira/projects/HBASE/summary

After filing JIRA, please change the subject on this PR and make it the JIRA ID followed by the JIRA summary: e.g. HBASE-XXXXX string out of bounds when construct illegal tablename error Thanks.

@zhengzhuobinzzb

zhengzhuobinzzb commented Jan 15, 2021

Copy link
Copy Markdown
ContributorAuthor

OK, I will do this latter

@zhengzhuobinzzbzhengzhuobinzzb changed the title fix bug: string out of bounds when construct illegal tablename error …HBASE-25512 string out of bounds when construct illegal tablename errorJan 15, 2021
@zhengzhuobinzzb

zhengzhuobinzzb commented Jan 15, 2021

Copy link
Copy Markdown
ContributorAuthor

Patch looks good but please file an accompanying JIRA over here https://issues.apache.org/jira/projects/HBASE/summary

After filing JIRA, please change the subject on this PR and make it the JIRA ID followed by the JIRA summary: e.g. HBASE-XXXXX string out of bounds when construct illegal tablename error Thanks.

Done. Create JIRA and link to this.
JIRA: https://issues.apache.org/jira/browse/HBASE-25512

@saintstacksaintstack changed the title HBASE-25512 string out of bounds when construct illegal tablename errorHBASE-25512 May throw StringIndexOutOfBoundsException when construct illegal tablename errorJan 15, 2021
saintstack
saintstack reviewed Jan 15, 2021
View reviewed changes
Comment threadhbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java Outdated
throw new IllegalArgumentException(isSnapshot ? "Snapshot" : "Table" + " qualifier must not be empty");
}
// Treat the bytes as UTF-8
String qualifierString = new String(

@saintstacksaintstackJan 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Why do this 'new String' instead of doing Bytes.toString(qualifierName, start, end - start) ?

I fixed the summary.

@zhengzhuobinzzbzhengzhuobinzzbJan 15, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!
No special reason here. Just copy the origin code.
Now I changed code to use Bytes.toString(qualifierName, start, end - start) instead of new String.
Is this better?

@zhengzhuobinzzb
zhengzhuobinzzbforce-pushed the illegal-tablename-error-message-opt branch from c877135 to e869f89CompareJanuary 15, 2021 21:17
@Apache-HBase

Apache-HBase commented Jan 15, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 0sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 47smaster passed
+1 💚compile0m 23smaster passed
+1 💚shadedjars6m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 33sthe patch passed
+1 💚compile0m 24sthe patch passed
+1 💚javac0m 24sthe patch passed
+1 💚shadedjars6m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22sthe patch passed
_ Other Tests _
+1 💚unit1m 25shbase-common in the patch passed.
25m 43s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2884
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f864e631811a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1474ebc
Default JavaAdoptOpenJDK-1.8.0_232-b09
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/testReport/
Max. process+thread count340 (vs. ulimit of 30000)
modulesC: hbase-common U: hbase-common
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 15, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 30smaster passed
+1 💚compile0m 27smaster passed
+1 💚shadedjars6m 58sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 26smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 8sthe patch passed
+1 💚compile0m 27sthe patch passed
+1 💚javac0m 27sthe patch passed
+1 💚shadedjars6m 49spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
+1 💚unit1m 36shbase-common in the patch passed.
27m 35s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2884
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 33773db7af99 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1474ebc
Default JavaAdoptOpenJDK-11.0.6+10
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/testReport/
Max. process+thread count273 (vs. ulimit of 30000)
modulesC: hbase-common U: hbase-common
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 15, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 55smaster passed
+1 💚compile0m 52smaster passed
+1 💚checkstyle0m 26smaster passed
+1 💚spotbugs0m 47smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 23sthe patch passed
+1 💚compile0m 49sthe patch passed
+1 💚javac0m 49sthe patch passed
+1 💚checkstyle0m 24sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck17m 36sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs0m 51sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
37m 10s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2884
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux d5deba326225 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1474ebc
Default JavaAdoptOpenJDK-1.8.0_232-b09
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-common U: hbase-common
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani

virajjasani commented Jan 30, 2021

Copy link
Copy Markdown
Contributor

Thanks for the PR @zhengzhuobinzzb , do you think you can add a test case for this change?

@zhengzhuobinzzb
zhengzhuobinzzbforce-pushed the illegal-tablename-error-message-opt branch from e869f89 to 15426afCompareFebruary 5, 2021 10:35
@Apache-HBase

Apache-HBase commented Feb 5, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 30smaster passed
+1 💚compile0m 25smaster passed
+1 💚shadedjars7m 21sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 53sthe patch passed
+1 💚compile0m 23sthe patch passed
+1 💚javac0m 23sthe patch passed
+1 💚shadedjars7m 22spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 21sthe patch passed
_ Other Tests _
+1 💚unit1m 42shbase-common in the patch passed.
28m 39s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2884
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ee1a9c888f9d 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3043796
Default JavaAdoptOpenJDK-1.8.0_232-b09
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/testReport/
Max. process+thread count222 (vs. ulimit of 30000)
modulesC: hbase-common U: hbase-common
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 5, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 24smaster passed
+1 💚compile0m 27smaster passed
+1 💚shadedjars6m 52sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 27smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 12sthe patch passed
+1 💚compile0m 25sthe patch passed
+1 💚javac0m 25sthe patch passed
+1 💚shadedjars6m 50spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
+1 💚unit1m 45shbase-common in the patch passed.
27m 36s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2884
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 013caa20f942 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3043796
Default JavaAdoptOpenJDK-11.0.6+10
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/testReport/
Max. process+thread count281 (vs. ulimit of 30000)
modulesC: hbase-common U: hbase-common
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 5, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall4m 25smaster passed
+1 💚compile0m 56smaster passed
+1 💚checkstyle0m 24smaster passed
+1 💚spotbugs0m 50smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 13sthe patch passed
+1 💚compile0m 53sthe patch passed
+1 💚javac0m 53sthe patch passed
+1 💚checkstyle0m 24sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck21m 2sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs0m 57sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
43m 29s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2884
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 7a13d95ee334 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3043796
Default JavaAdoptOpenJDK-1.8.0_232-b09
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-common U: hbase-common
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@zhengzhuobinzzb

zhengzhuobinzzb commented Feb 7, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks for the PR @zhengzhuobinzzb , do you think you can add a test case for this change?

I added it by assert this method must throw IllegalArgumentException when the table name is illegal.

@saintstack
saintstack merged commit 098f7c0 into apache:masterFeb 8, 2021
saintstack pushed a commit that referenced this pull request Feb 8, 2021
@zhengzhuobinzzb@saintstack
fix bug: string out of bounds when construct illegal tablename error …
9b6c135
…message (#2884)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: stack <stack@apache.org>
saintstack added a commit that referenced this pull request Feb 8, 2021
@saintstack
Revert "fix bug: string out of bounds when construct illegal tablenam…
16fe1e9
…e error message (#2884)"
This reverts commit 098f7c0.
saintstack added a commit that referenced this pull request Feb 8, 2021
@saintstack
HBASE-25512May throw StringIndexOutOfBoundsException when construct …
8a4c3b0
…illegal tablename error #2884
This revert of a revert reapplies the PR; the original application was
missing the HBASE JIRA #; thats why it was reverted and then reapplied
w/ the JIRA # added.
This reverts commit 16fe1e9.
saintstack added a commit that referenced this pull request Feb 8, 2021
@saintstack
Revert "fix bug: string out of bounds when construct illegal tablenam…
1d281ef
…e error message (#2884)"
This reverts commit 9b6c135.
ddupg pushed a commit to ddupg/hbase that referenced this pull request Feb 9, 2021
@zhengzhuobinzzbsunxin
fix bug: string out of bounds when construct illegal tablename error …
300134c
…message (apache#2884)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: stack <stack@apache.org>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Feb 9, 2021
@saintstacksunxin
Revert "fix bug: string out of bounds when construct illegal tablenam…
9351865
…e error message (apache#2884)"
This reverts commit 098f7c0.
ddupg pushed a commit to ddupg/hbase that referenced this pull request Feb 9, 2021
@saintstacksunxin
HBASE-25512 May throw StringIndexOutOfBoundsException when construct …
8873c72
…illegal tablename error apache#2884
This revert of a revert reapplies the PR; the original application was
missing the HBASE JIRA #; thats why it was reverted and then reapplied
w/ the JIRA # added.
This reverts commit 16fe1e9.
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Feb 24, 2021
@zhengzhuobinzzb@wchevreuil
fix bug: string out of bounds when construct illegal tablename error …
e24c7ff
…message (apache#2884)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: stack <stack@apache.org>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Feb 24, 2021
@saintstack@wchevreuil
Revert "fix bug: string out of bounds when construct illegal tablenam…
dc9bda6
…e error message (apache#2884)"
This reverts commit 098f7c0.
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Feb 24, 2021
@saintstack@wchevreuil
HBASE-25512 May throw StringIndexOutOfBoundsException when construct …
4737330
…illegal tablename error apache#2884
This revert of a revert reapplies the PR; the original application was
missing the HBASE JIRA #; thats why it was reverted and then reapplied
w/ the JIRA # added.
This reverts commit 16fe1e9.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstacksaintstacksaintstack left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhengzhuobinzzb@Apache-HBase@saintstack@virajjasani