Uh oh!
There was an error while loading. Please reload this page.
HBASE-25522 Remove deprecated methods in ReplicationPeerConfig - #2898
Conversation
Apache-HBase
commented
Jan 21, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 21, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 21, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 21, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 21, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 21, 2021
🎊 +1 overall
This message was automatically generated. |
Apache9
commented
Jan 22, 2021
Please fix the checkstyle issues? |
Apache-HBase
commented
Jan 22, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 22, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 22, 2021
💔 -1 overall
This message was automatically generated. |
ZhaoBQ
commented
Jan 22, 2021
Mockito cannot mock/spy because ReplicationPeerConfig is final class. Modify it back and ignore the checkstyle. |
Apache-HBase
commented
Jan 22, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 22, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 22, 2021
💔 -1 overall
This message was automatically generated. |
virajjasani
left a comment
There was a problem hiding this comment.
Left one comment to reuse same builder object, rest looks good.
Nice cleanup @ZhaoBQ
| ReplicationPeerConfig rpc = ReplicationPeerConfig.newBuilder().setClusterKey(KEY_ONE).build(); | ||
| admin.addReplicationPeer(ID_ONE, rpc).join(); | ||
| rpc.setReplicateAllUserTables(false); | ||
| rpc = ReplicationPeerConfig.newBuilder(rpc).setReplicateAllUserTables(false).build(); |
There was a problem hiding this comment.
Rather than creating a new builder from rpc, we can reuse old one.
e.g
ReplicationPeerConfigBuilder rpcBuilder = ReplicationPeerConfig.newBuilder().setClusterKey(KEY_ONE);
admin.addReplicationPeer(ID_ONE, rpcBuilder.build()).join();
rpcBuilder.setReplicateAllUserTables(false);
admin.updateReplicationPeerConfig(ID_ONE, rpcBuilder.build()).join();
Applicable to other similar places.
There was a problem hiding this comment.
Thanks for the nice suggestion, fix it immediately.
Apache-HBase
commented
Jan 23, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 23, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 23, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 23, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 23, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 23, 2021
🎊 +1 overall
This message was automatically generated. |
No description provided.