Uh oh!
There was an error while loading. Please reload this page.
HBASE-25847 More DEBUG and TRACE level logging in CatalogJanitor and HbckChore - #3230
Merged
Conversation
apurtell
commented
May 5, 2021
| disabledTableRegions.add(regionInfo.getRegionNameAsString()); | ||
| } | ||
| if (regionInfo.isSplitParent()) { | ||
| if (regionState.isSplit()) { |
ContributorAuthor
There was a problem hiding this comment.
Most of this patch is just more logging. This is a real bug fix, though. Right now it just affects logging (numbers printed in a debug log line) but if in the future code depends on splitParentRegions to be properly populated, this will be needed.
Contributor
There was a problem hiding this comment.
+1 on this change.
Was always odd have a Regions' split state recorded in its RegionInfo; RegionInfo does not keep internally if it is being merged or if open, etc. Regions are manipulated by other entities so state belongs elsewhere. +1 on move to regionstate checking instead.
apurtell
commented
May 5, 2021
Uh oh!
There was an error while loading. Please reload this page.
apurtell
commented
May 5, 2021
Uh oh!
There was an error while loading. Please reload this page.
Apache9
commented
May 5, 2021
Contributor
Some background https://issues.apache.org/jira/browse/HBASE-24942 I've found a bug when refactoring CatalogJanitor because of we may clean the merge qualifiers in MergeTableRegionsProcedure. Theoretically we should only do this in GCRegion related procedures(as what you proposed here), but doing this in other places could speed up later process which could be blocked by merge qualifiers. For me I'm +1 on removing the redundant removal in CatalogJanitor, but let's wait for @saintstack 's opinon too? Thanks. |
Apache-HBase
commented
May 5, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 5, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 5, 2021
💔 -1 overall
This message was automatically generated. |
virajjasani
commented
May 5, 2021
Contributor
|
Apache-HBase
commented
May 5, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 5, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 5, 2021
💔 -1 overall
This message was automatically generated. |
virajjasani
commented
May 5, 2021
Contributor
The error is persistent and it is relevant |
ContributorAuthor
With these changes the ingestion test completes successfully and without weird artifacts in the logging. All split regions are GCed by procedures. In memory state aligns with filesystem state. |
apurtell
commented
May 5, 2021
ContributorAuthor
Well since what I want here is "More DEBUG and TRACE level logging" I will remove the additional changes so the test failure is fixed and address that on a separate PR. |
ContributorAuthor
Just the logging changes now, and the bug fix to ensure log lines emit correct information. The CatalogJanitor cleanup proposal is now this PR: #3234 @virajjasani The next test report here should be good. |
Apache-HBase
commented
May 5, 2021
🎊 +1 overall
This message was automatically generated. |
bharathv
approved these changes
May 5, 2021
bharathv
left a comment
Contributor
There was a problem hiding this comment.
logging makes sense to me..
| if (!this.lastReport.isEmpty()) { | ||
| LOG.warn(this.lastReport.toString()); | ||
| } else { | ||
| LOG.debug(this.lastReport.toString()); |
Contributor
There was a problem hiding this comment.
nit: toString() might be an expensive call if debug is not enabled, might want to switch to a isDebugEnabled() guard, (later versions of log4j supports log.debug(Object)/log.debug(Supplier) so that toString() is eventually evaluated after the debug guard check)..
ContributorAuthor
There was a problem hiding this comment.
We used to abide by that guidance but I don't see that done often in new code.
saintstack
approved these changes
May 5, 2021
| disabledTableRegions.add(regionInfo.getRegionNameAsString()); | ||
| } | ||
| if (regionInfo.isSplitParent()) { | ||
| if (regionState.isSplit()) { |
Contributor
There was a problem hiding this comment.
+1 on this change.
Was always odd have a Regions' split state recorded in its RegionInfo; RegionInfo does not keep internally if it is being merged or if open, etc. Regions are manipulated by other entities so state belongs elsewhere. +1 on move to regionstate checking instead.
| if (!this.lastReport.isEmpty()) { | ||
| LOG.warn(this.lastReport.toString()); | ||
| } else { | ||
| LOG.debug(this.lastReport.toString()); |
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
May 5, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 5, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 5, 2021
🎊 +1 overall
This message was automatically generated. |
apurtell
commented
May 6, 2021
ContributorAuthor
Added log level guards as requested before merge. |
asfgit pushed a commit
that referenced
this pull request
May 6, 2021
…HbckChore (#3230) Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Michael Stack <stack@apache.org>
asfgit pushed a commit
that referenced
this pull request
May 6, 2021
…HbckChore (#3230) Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Michael Stack <stack@apache.org>
Apache-HBase
commented
May 6, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 6, 2021
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.