Skip to content

HBASE-26030 hbase-cleanup.sh did not clean the wal dir if hbase.wal.dir configured individually - #3432

Merged
Apache9 merged 1 commit into
apache:masterfrom
mokai87:master
Jul 3, 2021
Merged

HBASE-26030 hbase-cleanup.sh did not clean the wal dir if hbase.wal.dir configured individually#3432
Apache9 merged 1 commit into
apache:masterfrom
mokai87:master

Conversation

@mokai87

Copy link
Copy Markdown
Contributor

…ir configured individually

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 58sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
2m 5s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3432/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3432
Optional Tests
unameLinux 8026566fd392 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / bffe895
Max. process+thread count45 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3432/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
2m 10s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3432/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3432
Optional Tests
unameLinux dbea2ed63462 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / bffe895
Max. process+thread count42 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3432/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
-0 ⚠️shellcheck0m 1sThe patch generated 2 new + 26 unchanged - 0 fixed = 28 total (was 26)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
_ Other Tests _
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
2m 12s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3432/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3432
Optional Testsdupname asflicense shellcheck shelldocs
unameLinux 62ca61cf4f85 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / bffe895
shellcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3432/1/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
Max. process+thread count49 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3432/1/console
versionsgit=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never know there is a script for doing the clean up work...

For WAL deletion, maybe a problem is that, it could use a different HDFS comparing to HFile? Does the script consider this situation?

Thanks.

@mokai87

Copy link
Copy Markdown
ContributorAuthor

Yes, it depends on the scheme of path. I tested it on HDFS and OBS both.

@Apache9
Apache9 merged commit b80d70c into apache:masterJul 3, 2021
Apache9 pushed a commit that referenced this pull request Jul 3, 2021
…ir configured individually (#3432)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Jul 3, 2021
…ir configured individually (#3432)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Jul 3, 2021
…ir configured individually (#3432)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mokai87@Apache-HBase@Apache9