Uh oh!
There was an error while loading. Please reload this page.
HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations - #3436
Conversation
Apache-HBase
commented
Jun 29, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 29, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 29, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 29, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 29, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 29, 2021
💔 -1 overall
This message was automatically generated. |
Apache9
commented
Jun 30, 2021
Sorry, I do not fully understand the problem here. Skimmed the code, the change is to use RegionScanner directly instead of the get method. Does this mean the get method is broken as it releases the ByteBuff too early? But I think we use this method everywhere in the HRegion class, we do not need to change them? Thanks. |
sunhelly
commented
Jun 30, 2021
Hi, @Apache9 , yes the get method is broken, the other places using this method should also be changed. |
Apache-HBase
commented
Jun 30, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 30, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 30, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 30, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 30, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 30, 2021
🎊 +1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| currentValue = currentValues.get(currentValuesIndex); | ||
| if (i < (deltas.size() - 1) && !CellUtil.matchingQualifier(delta, deltas.get(i + 1))) { | ||
| currentValuesIndex++; | ||
| List<Cell> currentValues = new ArrayList<>(); |
There was a problem hiding this comment.
Super nit.... Does currentValues have to be out here? Usually you put it after you open the try {.
Uh oh!
There was an error while loading. Please reload this page.
492cb88 to
f762abbCompareApache-HBase
commented
Jul 5, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 5, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 5, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 5, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 5, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 5, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 6, 2021
💔 -1 overall
This message was automatically generated. |
sunhelly
commented
Jul 6, 2021
I have fixed the test issue after the commit 9f86148. |
Apache-HBase
commented
Jul 6, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 6, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 6, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 6, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 6, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 8, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 8, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 8, 2021
🎊 +1 overall
This message was automatically generated. |
sunhelly
commented
Jul 8, 2021
@saintstack@Apache9@anoopsjohn PTAL, thanks. |
saintstack
left a comment
There was a problem hiding this comment.
+1 (again).
This is great. A nit but only if you make a new PR.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
Jul 13, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2021
🎊 +1 overall
This message was automatically generated. |
sunhelly
commented
Jul 14, 2021
The failed UT is not related to this issue. |
…r some operations (apache#3436) Signed-off-by: Michael Stack <stack@apache.org>
…r some operations (apache#3436) (apache#3486) Signed-off-by: Michael Stack <stack@apache.org>
Uh oh!
There was an error while loading. Please reload this page.