Skip to content

HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related … - #3478

Merged
Apache9 merged 2 commits into
apache:masterfrom
Apache9:HBASE-26081
Jul 19, 2021
Merged

HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …#3478
Apache9 merged 2 commits into
apache:masterfrom
Apache9:HBASE-26081

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

…classes in hbase-server and mark them as IA.LimitedPrivate

@Apache9Apache9 self-assigned this Jul 13, 2021
@Apache9

Copy link
Copy Markdown
ContributorAuthor

This is a very big change.

The classes in the new package, org.apache.hadoop.hbase.testing, are all the classes we want to hide from end users, including HBTU and its parent classes, and HBaseCluster and MiniHBaseCluster. All these classes are changed to IA.LimitedPrivate(Phoenix), as I believe Phoenix still needs test some internal stuff of HBase. The DistributedHBaseCluster is kept as is since it is IA.Private.

And then I copied the classes under the new org.apache.hadoop.hbase.testing to org.apache.hadoop.hbase in hbase-testing-module, still keep the IA.Public annotation but mark them all as deprecated, which will be removed in 4.0.0, for keeping compatible. Also modified the HBTU a bit to remove the dependency on junit, by throwing AssertionError directly, as I do not think we should pull in junit as a compile dependency for any libraries...

Thanks.

@Apache9
Apache9 requested review from busbey and saintstackJuly 13, 2021 11:22
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 15sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall5m 58smaster passed
+1 💚compile11m 26smaster passed
+1 💚shadedjars11m 2sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc8m 48smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall5m 48sthe patch passed
+1 💚compile12m 5sthe patch passed
+1 💚javac12m 5sthe patch passed
+1 💚shadedjars11m 13spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc8m 40sthe patch passed
_ Other Tests _
+1 💚unit2m 22shbase-common in the patch passed.
+1 💚unit1m 39shbase-client in the patch passed.
+1 💚unit0m 50shbase-zookeeper in the patch passed.
+1 💚unit0m 32shbase-replication in the patch passed.
+1 💚unit8m 21shbase-balancer in the patch passed.
+1 💚unit0m 52shbase-http in the patch passed.
+1 💚unit1m 35shbase-asyncfs in the patch passed.
+1 💚unit1m 56shbase-procedure in the patch passed.
+1 💚unit146m 25shbase-server in the patch passed.
+1 💚unit10m 58shbase-mapreduce in the patch passed.
+1 💚unit1m 39shbase-testing-util in the patch passed.
+1 💚unit6m 13shbase-thrift in the patch passed.
+1 💚unit7m 9shbase-shell in the patch passed.
+1 💚unit3m 13shbase-endpoint in the patch passed.
+1 💚unit9m 55shbase-backup in the patch passed.
+1 💚unit1m 14shbase-it in the patch passed.
-1 ❌unit2m 34shbase-rest in the patch failed.
+1 💚unit1m 47shbase-examples in the patch passed.
+1 💚unit1m 21shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 11shbase-client-project in the patch passed.
+1 💚unit1m 12shbase-shaded-client-project in the patch passed.
298m 4s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5ca302c0767b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9f21eec
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rest.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/testReport/
Max. process+thread count4817 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 26sDocker mode activated.
-0 ⚠️yetus0m 12sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 23smaster passed
+1 💚compile8m 14smaster passed
+1 💚shadedjars8m 59sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 27smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 16sthe patch passed
+1 💚compile8m 18sthe patch passed
+1 💚javac8m 18sthe patch passed
+1 💚shadedjars9m 5spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 15shbase-testing-util generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
_ Other Tests _
+1 💚unit1m 58shbase-common in the patch passed.
+1 💚unit1m 32shbase-client in the patch passed.
+1 💚unit0m 46shbase-zookeeper in the patch passed.
+1 💚unit0m 39shbase-replication in the patch passed.
+1 💚unit8m 45shbase-balancer in the patch passed.
+1 💚unit0m 57shbase-http in the patch passed.
+1 💚unit1m 47shbase-asyncfs in the patch passed.
+1 💚unit2m 22shbase-procedure in the patch passed.
+1 💚unit218m 19shbase-server in the patch passed.
+1 💚unit18m 29shbase-mapreduce in the patch passed.
+1 💚unit1m 55shbase-testing-util in the patch passed.
+1 💚unit9m 34shbase-thrift in the patch passed.
+1 💚unit7m 17shbase-shell in the patch passed.
+1 💚unit3m 33shbase-endpoint in the patch passed.
+1 💚unit13m 40shbase-backup in the patch passed.
+1 💚unit1m 15shbase-it in the patch passed.
-1 ❌unit4m 24shbase-rest in the patch failed.
+1 💚unit2m 50shbase-examples in the patch passed.
+1 💚unit1m 43shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 15shbase-client-project in the patch passed.
+1 💚unit1m 17shbase-shaded-client-project in the patch passed.
369m 1s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 816f703269e3 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9f21eec
Default JavaAdoptOpenJDK-1.8.0_282-b08
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-testing-util.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-rest.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/testReport/
Max. process+thread count3106 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 5sDocker mode activated.
-0 ⚠️yetus0m 16sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 2smaster passed
+1 💚compile8m 44smaster passed
+1 💚shadedjars8m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 29smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
-1 ❌mvninstall1m 56sroot in the patch failed.
-1 ❌compile0m 45shbase-server in the patch failed.
-1 ❌compile0m 25shbase-mapreduce in the patch failed.
-1 ❌compile0m 20shbase-testing-util in the patch failed.
-1 ❌compile0m 31shbase-thrift in the patch failed.
-1 ❌compile0m 20shbase-shell in the patch failed.
-1 ❌compile0m 21shbase-endpoint in the patch failed.
-1 ❌compile0m 24shbase-backup in the patch failed.
-1 ❌compile0m 24shbase-it in the patch failed.
-1 ❌compile0m 23shbase-rest in the patch failed.
-1 ❌compile0m 26shbase-examples in the patch failed.
-1 ❌compile0m 13shbase-shaded-testing-util-tester in the patch failed.
-1 ❌compile0m 20shbase-client-project in the patch failed.
-1 ❌compile0m 19shbase-shaded-client-project in the patch failed.
-0 ⚠️javac0m 45shbase-server in the patch failed.
-0 ⚠️javac0m 25shbase-mapreduce in the patch failed.
-0 ⚠️javac0m 20shbase-testing-util in the patch failed.
-0 ⚠️javac0m 31shbase-thrift in the patch failed.
-0 ⚠️javac0m 20shbase-shell in the patch failed.
-0 ⚠️javac0m 21shbase-endpoint in the patch failed.
-0 ⚠️javac0m 24shbase-backup in the patch failed.
-0 ⚠️javac0m 24shbase-it in the patch failed.
-0 ⚠️javac0m 23shbase-rest in the patch failed.
-0 ⚠️javac0m 26shbase-examples in the patch failed.
-0 ⚠️javac0m 13shbase-shaded-testing-util-tester in the patch failed.
-0 ⚠️javac0m 20shbase-client-project in the patch failed.
-0 ⚠️javac0m 19shbase-shaded-client-project in the patch failed.
-1 ❌shadedjars6m 18spatch has 20 errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 17shbase-testing-util generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
_ Other Tests _
+1 💚unit1m 50shbase-common in the patch passed.
+1 💚unit1m 14shbase-client in the patch passed.
+1 💚unit0m 44shbase-zookeeper in the patch passed.
+1 💚unit0m 27shbase-replication in the patch passed.
+1 💚unit8m 58shbase-balancer in the patch passed.
+1 💚unit0m 50shbase-http in the patch passed.
+1 💚unit1m 29shbase-asyncfs in the patch passed.
+1 💚unit1m 52shbase-procedure in the patch passed.
-1 ❌unit0m 48shbase-server in the patch failed.
-1 ❌unit0m 25shbase-mapreduce in the patch failed.
-1 ❌unit0m 22shbase-testing-util in the patch failed.
-1 ❌unit0m 35shbase-thrift in the patch failed.
-1 ❌unit0m 21shbase-shell in the patch failed.
-1 ❌unit0m 23shbase-endpoint in the patch failed.
-1 ❌unit0m 24shbase-backup in the patch failed.
-1 ❌unit0m 25shbase-it in the patch failed.
-1 ❌unit0m 25shbase-rest in the patch failed.
-1 ❌unit0m 28shbase-examples in the patch failed.
-1 ❌unit0m 14shbase-shaded-testing-util-tester in the patch failed.
-1 ❌unit0m 21shbase-client-project in the patch failed.
-1 ❌unit0m 19shbase-shaded-client-project in the patch failed.
85m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 76313ff03f41 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0836695
Default JavaAdoptOpenJDK-1.8.0_282-b08
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-mapreduce.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-testing-util.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-thrift.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-shell.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-endpoint.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-backup.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-it.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-rest.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-examples.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-shaded_hbase-shaded-testing-util-tester.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-archetypes_hbase-client-project.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-archetypes_hbase-shaded-client-project.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-mapreduce.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-testing-util.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-thrift.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-shell.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-endpoint.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-backup.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-it.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-rest.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-examples.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-shaded_hbase-shaded-testing-util-tester.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-archetypes_hbase-client-project.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-archetypes_hbase-shaded-client-project.txt
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-testing-util.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-testing-util.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-thrift.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-endpoint.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-backup.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-it.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-rest.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-examples.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shaded_hbase-shaded-testing-util-tester.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-archetypes_hbase-client-project.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-archetypes_hbase-shaded-client-project.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/testReport/
Max. process+thread count551 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 14sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall5m 13smaster passed
+1 💚compile10m 19smaster passed
+1 💚shadedjars10m 52sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 9smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall5m 4sthe patch passed
+1 💚compile10m 42sthe patch passed
+1 💚javac10m 42sthe patch passed
+1 💚shadedjars11m 29spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 19shbase-testing-util generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
_ Other Tests _
+1 💚unit2m 7shbase-common in the patch passed.
+1 💚unit1m 31shbase-client in the patch passed.
+1 💚unit0m 51shbase-zookeeper in the patch passed.
+1 💚unit0m 30shbase-replication in the patch passed.
+1 💚unit7m 33shbase-balancer in the patch passed.
+1 💚unit0m 57shbase-http in the patch passed.
+1 💚unit1m 44shbase-asyncfs in the patch passed.
+1 💚unit2m 10shbase-procedure in the patch passed.
+1 💚unit160m 19shbase-server in the patch passed.
+1 💚unit12m 21shbase-mapreduce in the patch passed.
+1 💚unit1m 49shbase-testing-util in the patch passed.
+1 💚unit7m 32shbase-thrift in the patch passed.
+1 💚unit7m 19shbase-shell in the patch passed.
+1 💚unit3m 7shbase-endpoint in the patch passed.
+1 💚unit11m 54shbase-backup in the patch passed.
+1 💚unit1m 6shbase-it in the patch passed.
+1 💚unit3m 55shbase-rest in the patch passed.
+1 💚unit1m 58shbase-examples in the patch passed.
+1 💚unit1m 28shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 21shbase-client-project in the patch passed.
+1 💚unit1m 26shbase-shaded-client-project in the patch passed.
310m 37s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b7b001c3d2aa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0836695
Default JavaAdoptOpenJDK-1.8.0_282-b08
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-testing-util.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/testReport/
Max. process+thread count5361 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 26sDocker mode activated.
-0 ⚠️yetus0m 14sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall6m 0smaster passed
+1 💚compile10m 51smaster passed
+1 💚shadedjars11m 14sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc8m 40smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall5m 58sthe patch passed
+1 💚compile11m 43sthe patch passed
+1 💚javac11m 43sthe patch passed
+1 💚shadedjars11m 33spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc8m 52sthe patch passed
_ Other Tests _
+1 💚unit2m 16shbase-common in the patch passed.
+1 💚unit1m 40shbase-client in the patch passed.
+1 💚unit0m 55shbase-zookeeper in the patch passed.
+1 💚unit0m 46shbase-replication in the patch passed.
+1 💚unit7m 10shbase-balancer in the patch passed.
+1 💚unit0m 58shbase-http in the patch passed.
+1 💚unit2m 9shbase-asyncfs in the patch passed.
+1 💚unit2m 6shbase-procedure in the patch passed.
-1 ❌unit159m 40shbase-server in the patch failed.
+1 💚unit13m 11shbase-mapreduce in the patch passed.
+1 💚unit1m 48shbase-testing-util in the patch passed.
+1 💚unit7m 38shbase-thrift in the patch passed.
+1 💚unit7m 31shbase-shell in the patch passed.
+1 💚unit3m 5shbase-endpoint in the patch passed.
+1 💚unit9m 22shbase-backup in the patch passed.
+1 💚unit1m 28shbase-it in the patch passed.
+1 💚unit3m 41shbase-rest in the patch passed.
+1 💚unit2m 17shbase-examples in the patch passed.
+1 💚unit1m 26shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 19shbase-client-project in the patch passed.
+1 💚unit1m 16shbase-shaded-client-project in the patch passed.
317m 34s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a2f27ff28dc7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0836695
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/testReport/
Max. process+thread count4838 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 8sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 33smaster passed
+1 💚compile15m 5smaster passed
+1 💚checkstyle8m 48smaster passed
+1 💚spotbugs16m 3smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 28sthe patch passed
+1 💚compile15m 43sthe patch passed
-0 ⚠️javac0m 49shbase-common generated 5 new + 155 unchanged - 4 fixed = 160 total (was 159)
-0 ⚠️javac0m 28shbase-zookeeper generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
-0 ⚠️javac3m 34shbase-server generated 97 new + 96 unchanged - 97 fixed = 193 total (was 193)
-0 ⚠️javac0m 29shbase-testing-util generated 100 new + 1 unchanged - 0 fixed = 101 total (was 1)
-0 ⚠️checkstyle1m 37shbase-server: The patch generated 175 new + 1315 unchanged - 173 fixed = 1490 total (was 1488)
-0 ⚠️checkstyle0m 18shbase-testing-util: The patch generated 174 new + 0 unchanged - 0 fixed = 174 total (was 0)
-0 ⚠️whitespace0m 0sThe patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚hadoopcheck20m 46sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
-1 ❌spotbugs1m 2shbase-testing-util generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
_ Other Tests _
+1 💚asflicense4m 20sThe patch does not generate ASF License warnings.
138m 33s
ReasonTests
FindBugsmodule:hbase-testing-util
Inconsistent synchronization of org.apache.hadoop.hbase.HBaseTestingUtility.hbaseAdmin; locked 42% of time Unsynchronized access at HBaseTestingUtility.java:42% of time Unsynchronized access at HBaseTestingUtility.java:[line 3045]
org.apache.hadoop.hbase.HBaseTestingUtility.explainTableAvailability(TableName) concatenates strings using + in a loop At HBaseTestingUtility.java:in a loop At HBaseTestingUtility.java:[line 3225]
Write to static field org.apache.hadoop.hbase.HBaseTestingUtility.FS_URI from instance method org.apache.hadoop.hbase.HBaseTestingUtility.setFileSystemURI(String) At HBaseTestingUtility.java:from instance method org.apache.hadoop.hbase.HBaseTestingUtility.setFileSystemURI(String) At HBaseTestingUtility.java:[line 4044]
Write to static field org.apache.hadoop.hbase.MiniHBaseCluster.index from instance method org.apache.hadoop.hbase.MiniHBaseCluster.startMaster() At MiniHBaseCluster.java:from instance method org.apache.hadoop.hbase.MiniHBaseCluster.startMaster() At MiniHBaseCluster.java:[line 551]
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3478
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
unameLinux 475fdecf635a 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-testing-util.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-testing-util.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/whitespace-eol.txt
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/new-spotbugs-hbase-testing-util.html
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@saintstack

Copy link
Copy Markdown
Contributor

So, a user of these classes who moved to hbase 3.0.0 might have to amend their CLASSPATH but that is all? They might have to add hbase-testing jar to their CLASSPATH?

@saintstack

Copy link
Copy Markdown
Contributor

Why you thinking the package movement? The HBTU I'd think should be a top-level package rather than a sub-package down in testing?

Comment threadhbase-rest/pom.xml
@saintstack

Copy link
Copy Markdown
Contributor

You move the fundamentals HBTU and HBC from top-level into sub-package to send downstreamers the message that these classes are off-limits going forward?

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 13sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 0smaster passed
+1 💚compile8m 40smaster passed
+1 💚shadedjars8m 23sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 24smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 47sthe patch passed
+1 💚compile8m 50sthe patch passed
+1 💚javac8m 50sthe patch passed
+1 💚shadedjars8m 42spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 17shbase-testing-util generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
_ Other Tests _
+1 💚unit1m 49shbase-common in the patch passed.
+1 💚unit1m 13shbase-client in the patch passed.
+1 💚unit0m 44shbase-zookeeper in the patch passed.
+1 💚unit0m 26shbase-replication in the patch passed.
+1 💚unit8m 57shbase-balancer in the patch passed.
+1 💚unit0m 50shbase-http in the patch passed.
+1 💚unit1m 32shbase-asyncfs in the patch passed.
+1 💚unit1m 51shbase-procedure in the patch passed.
+1 💚unit148m 40shbase-server in the patch passed.
+1 💚unit11m 48shbase-mapreduce in the patch passed.
+1 💚unit1m 40shbase-testing-util in the patch passed.
+1 💚unit6m 29shbase-thrift in the patch passed.
+1 💚unit7m 22shbase-shell in the patch passed.
+1 💚unit3m 42shbase-endpoint in the patch passed.
+1 💚unit9m 52shbase-backup in the patch passed.
+1 💚unit1m 18shbase-it in the patch passed.
+1 💚unit3m 53shbase-rest in the patch passed.
+1 💚unit2m 1shbase-examples in the patch passed.
+1 💚unit1m 34shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 20shbase-client-project in the patch passed.
+1 💚unit1m 11shbase-shaded-client-project in the patch passed.
282m 43s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 69bdb0460bcc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-1.8.0_282-b08
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-testing-util.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/testReport/
Max. process+thread count5059 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 12sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall4m 50smaster passed
+1 💚compile10m 7smaster passed
+1 💚shadedjars9m 5sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 41sthe patch passed
+1 💚compile9m 54sthe patch passed
+1 💚javac9m 54sthe patch passed
+1 💚shadedjars9m 12spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 52sthe patch passed
_ Other Tests _
+1 💚unit2m 14shbase-common in the patch passed.
+1 💚unit1m 28shbase-client in the patch passed.
+1 💚unit0m 49shbase-zookeeper in the patch passed.
+1 💚unit0m 32shbase-replication in the patch passed.
+1 💚unit8m 20shbase-balancer in the patch passed.
+1 💚unit0m 46shbase-http in the patch passed.
+1 💚unit1m 28shbase-asyncfs in the patch passed.
+1 💚unit1m 45shbase-procedure in the patch passed.
+1 💚unit143m 42shbase-server in the patch passed.
+1 💚unit11m 7shbase-mapreduce in the patch passed.
+1 💚unit1m 36shbase-testing-util in the patch passed.
+1 💚unit6m 17shbase-thrift in the patch passed.
+1 💚unit7m 14shbase-shell in the patch passed.
+1 💚unit3m 13shbase-endpoint in the patch passed.
+1 💚unit10m 8shbase-backup in the patch passed.
+1 💚unit1m 11shbase-it in the patch passed.
+1 💚unit3m 32shbase-rest in the patch passed.
+1 💚unit1m 48shbase-examples in the patch passed.
+1 💚unit1m 18shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 6shbase-client-project in the patch passed.
+1 💚unit1m 6shbase-shaded-client-project in the patch passed.
284m 11s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 88bc77eae89f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/testReport/
Max. process+thread count4815 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

You move the fundamentals HBTU and HBC from top-level into sub-package to send downstreamers the message that these classes are off-limits going forward?

The idea is to copy the HBTU related classes to hbase-testing-util and mark them deprecated, so end users could still use them through all the hbase 3.x lifecycle, and also have plenty of time to switch to the new TestingHBaseCluster, which is enough for most end users.

And for hbase itself, we move the HBTU to another package, so it will not have conflict with the one in hbase-testing-util, and then, since it is not IA.Public again, we could start to purge the uncessary methods, and also do big refactoring on it. And I think Phoenix still needs to make use of this class, as it needs to test something internal to hbase, so I marked the 'new' HBTU as IA.LimitedPrivate, but anyone, I think for an IA.LimitedPrivate class, we are free to change it in minor releases.

You can see some discuss in the parent issue HBASE-13126.

Thanks.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

So, a user of these classes who moved to hbase 3.0.0 might have to amend their CLASSPATH but that is all? They might have to add hbase-testing jar to their CLASSPATH?

Yes, users need to add hbase-testing-util as a test dependency, but they do not need to change their code in 3.0.0, but in 4.0.0, they have to change their code to make use of the new classes.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

Why you thinking the package movement? The HBTU I'd think should be a top-level package rather than a sub-package down in testing?

To avoid conflict with the copied ones in hbase-testing-util, we should either move the original one to another package, or rename them. In general, I do not have much intention on which one is better, but for me, I do not have better names for these classes, due to lack of English vocabulary... Do you have any suggestions sir? We could move them back to the top level, but with different names.

Thanks.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 9sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 12smaster passed
+1 💚compile14m 20smaster passed
+1 💚checkstyle7m 33smaster passed
+1 💚spotbugs15m 6smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 33sthe patch passed
+1 💚compile15m 13sthe patch passed
-0 ⚠️javac0m 49shbase-common generated 5 new + 155 unchanged - 4 fixed = 160 total (was 159)
-0 ⚠️javac0m 31shbase-zookeeper generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
-0 ⚠️javac3m 25shbase-server generated 97 new + 96 unchanged - 97 fixed = 193 total (was 193)
-0 ⚠️javac0m 30shbase-testing-util generated 100 new + 1 unchanged - 0 fixed = 101 total (was 1)
-0 ⚠️checkstyle1m 36shbase-server: The patch generated 175 new + 1315 unchanged - 173 fixed = 1490 total (was 1488)
-0 ⚠️checkstyle0m 18shbase-testing-util: The patch generated 174 new + 0 unchanged - 0 fixed = 174 total (was 0)
-0 ⚠️whitespace0m 0sThe patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚xml0m 3sThe patch has no ill-formed XML file.
+1 💚hadoopcheck20m 14sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs17m 26sthe patch passed
_ Other Tests _
+1 💚asflicense3m 34sThe patch does not generate ASF License warnings.
128m 19s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3478
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
unameLinux 1bf07411b674 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-testing-util.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-testing-util.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 11sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 27smaster passed
+1 💚compile9m 15smaster passed
+1 💚shadedjars8m 14sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 25smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 15sthe patch passed
+1 💚compile9m 19sthe patch passed
+1 💚javac9m 19sthe patch passed
+1 💚shadedjars8m 25spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 17sthe patch passed
_ Other Tests _
+1 💚unit1m 57shbase-common in the patch passed.
+1 💚unit1m 23shbase-client in the patch passed.
+1 💚unit0m 46shbase-zookeeper in the patch passed.
+1 💚unit0m 28shbase-replication in the patch passed.
+1 💚unit7m 47shbase-balancer in the patch passed.
+1 💚unit0m 46shbase-http in the patch passed.
+1 💚unit1m 25shbase-asyncfs in the patch passed.
+1 💚unit1m 45shbase-procedure in the patch passed.
-1 ❌unit167m 46shbase-server in the patch failed.
+1 💚unit10m 38shbase-mapreduce in the patch passed.
+1 💚unit1m 38shbase-testing-util in the patch passed.
+1 💚unit6m 28shbase-thrift in the patch passed.
+1 💚unit7m 8shbase-shell in the patch passed.
+1 💚unit2m 54shbase-endpoint in the patch passed.
+1 💚unit9m 2shbase-backup in the patch passed.
+1 💚unit1m 13shbase-it in the patch passed.
+1 💚unit3m 49shbase-rest in the patch passed.
+1 💚unit1m 50shbase-examples in the patch passed.
+1 💚unit1m 20shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 8shbase-client-project in the patch passed.
+1 💚unit1m 9shbase-shaded-client-project in the patch passed.
301m 29s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 754a4bb3de4b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/testReport/
Max. process+thread count5022 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 15sDocker mode activated.
-0 ⚠️yetus0m 11sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 14smaster passed
+1 💚compile8m 12smaster passed
+1 💚shadedjars9m 8sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 2smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 2sthe patch passed
+1 💚compile8m 18sthe patch passed
+1 💚javac8m 18sthe patch passed
+1 💚shadedjars9m 0spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc5m 59sthe patch passed
_ Other Tests _
+1 💚unit1m 51shbase-common in the patch passed.
+1 💚unit1m 27shbase-client in the patch passed.
+1 💚unit0m 47shbase-zookeeper in the patch passed.
+1 💚unit0m 36shbase-replication in the patch passed.
+1 💚unit12m 5shbase-balancer in the patch passed.
+1 💚unit0m 49shbase-http in the patch passed.
+1 💚unit1m 42shbase-asyncfs in the patch passed.
+1 💚unit2m 9shbase-procedure in the patch passed.
+1 💚unit211m 18shbase-server in the patch passed.
+1 💚unit14m 15shbase-mapreduce in the patch passed.
+1 💚unit1m 35shbase-testing-util in the patch passed.
+1 💚unit9m 14shbase-thrift in the patch passed.
+1 💚unit7m 9shbase-shell in the patch passed.
+1 💚unit3m 20shbase-endpoint in the patch passed.
+1 💚unit12m 54shbase-backup in the patch passed.
+1 💚unit1m 9shbase-it in the patch passed.
+1 💚unit5m 0shbase-rest in the patch passed.
+1 💚unit2m 17shbase-examples in the patch passed.
+1 💚unit1m 27shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 9shbase-client-project in the patch passed.
+1 💚unit1m 5shbase-shaded-client-project in the patch passed.
357m 1s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux bc766d0e070e 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/testReport/
Max. process+thread count3281 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 45sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 9sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 1sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 33smaster passed
+1 💚compile17m 42smaster passed
+1 💚checkstyle8m 42smaster passed
+1 💚spotbugs16m 44smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 37sthe patch passed
+1 💚compile17m 49sthe patch passed
-0 ⚠️javac0m 56shbase-common generated 5 new + 155 unchanged - 4 fixed = 160 total (was 159)
-0 ⚠️javac0m 31shbase-zookeeper generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
-0 ⚠️javac4m 0shbase-server generated 97 new + 96 unchanged - 97 fixed = 193 total (was 193)
-0 ⚠️javac0m 36shbase-testing-util generated 100 new + 1 unchanged - 0 fixed = 101 total (was 1)
-0 ⚠️checkstyle1m 46shbase-server: The patch generated 175 new + 1315 unchanged - 173 fixed = 1490 total (was 1488)
-0 ⚠️checkstyle0m 21shbase-testing-util: The patch generated 174 new + 0 unchanged - 0 fixed = 174 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
+1 💚hadoopcheck23m 54sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs20m 14sthe patch passed
_ Other Tests _
+1 💚asflicense4m 2sThe patch does not generate ASF License warnings.
147m 2s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3478
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
unameLinux fbdae27bcddc 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-testing-util.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-testing-util.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
-0 ⚠️yetus0m 12sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 8smaster passed
+1 💚compile9m 17smaster passed
+1 💚shadedjars8m 8sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 24smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 13sthe patch passed
+1 💚compile9m 26sthe patch passed
+1 💚javac9m 26sthe patch passed
+1 💚shadedjars8m 13spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 27sthe patch passed
_ Other Tests _
+1 💚unit1m 57shbase-common in the patch passed.
+1 💚unit1m 25shbase-client in the patch passed.
+1 💚unit0m 49shbase-zookeeper in the patch passed.
+1 💚unit0m 27shbase-replication in the patch passed.
+1 💚unit7m 24shbase-balancer in the patch passed.
+1 💚unit0m 45shbase-http in the patch passed.
+1 💚unit1m 26shbase-asyncfs in the patch passed.
+1 💚unit1m 42shbase-procedure in the patch passed.
+1 💚unit135m 57shbase-server in the patch passed.
+1 💚unit10m 12shbase-mapreduce in the patch passed.
+1 💚unit1m 39shbase-testing-util in the patch passed.
+1 💚unit6m 55shbase-thrift in the patch passed.
+1 💚unit7m 13shbase-shell in the patch passed.
+1 💚unit2m 55shbase-endpoint in the patch passed.
+1 💚unit10m 12shbase-backup in the patch passed.
+1 💚unit1m 14shbase-it in the patch passed.
+1 💚unit3m 29shbase-rest in the patch passed.
+1 💚unit1m 46shbase-examples in the patch passed.
+1 💚unit1m 19shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 8shbase-client-project in the patch passed.
+1 💚unit1m 10shbase-shaded-client-project in the patch passed.
270m 6s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux dee4acc7ceba 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/testReport/
Max. process+thread count5398 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@saintstack

Copy link
Copy Markdown
Contributor

To avoid conflict with the copied ones in hbase-testing-util, we should either move the original one to another package, or rename them. In general, I do not have much intention on which one is better, but for me, I do not have better names for these classes, due to lack of English vocabulary... Do you have any suggestions sir? We could move them back to the top level, but with different names.

Thanks for explanation. Suggest you add description on the JIRA repeating the helpful overview you give here pointing at the parent issue's discussion.

On moving the classes to a sub-package though some of these classes are used broadly, given what you are trying to achieve (cleanup, refactor), this is probably the easiest approach. One suggestion I have would be renaming HBaseTestingUtility as TestingUtility and leaving it in the top-level package. The 'HBase' prefix is redundant. Might be working looking at. If it makes more work for you, just ignore.

Meantime, let me +1 this change.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 14sDocker mode activated.
-0 ⚠️yetus0m 11sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 15smaster passed
+1 💚compile8m 13smaster passed
+1 💚shadedjars9m 5sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 1smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 6sthe patch passed
+1 💚compile8m 16sthe patch passed
+1 💚javac8m 16sthe patch passed
+1 💚shadedjars9m 0spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 2sthe patch passed
_ Other Tests _
+1 💚unit1m 51shbase-common in the patch passed.
+1 💚unit1m 27shbase-client in the patch passed.
+1 💚unit0m 46shbase-zookeeper in the patch passed.
+1 💚unit0m 37shbase-replication in the patch passed.
+1 💚unit12m 5shbase-balancer in the patch passed.
+1 💚unit0m 48shbase-http in the patch passed.
+1 💚unit1m 42shbase-asyncfs in the patch passed.
+1 💚unit2m 8shbase-procedure in the patch passed.
+1 💚unit211m 25shbase-server in the patch passed.
+1 💚unit14m 20shbase-mapreduce in the patch passed.
+1 💚unit1m 36shbase-testing-util in the patch passed.
+1 💚unit9m 10shbase-thrift in the patch passed.
+1 💚unit7m 4shbase-shell in the patch passed.
+1 💚unit3m 20shbase-endpoint in the patch passed.
+1 💚unit12m 51shbase-backup in the patch passed.
+1 💚unit1m 9shbase-it in the patch passed.
+1 💚unit4m 59shbase-rest in the patch passed.
+1 💚unit2m 17shbase-examples in the patch passed.
+1 💚unit1m 31shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 7shbase-client-project in the patch passed.
+1 💚unit1m 7shbase-shaded-client-project in the patch passed.
357m 10s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 028047c8c976 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/testReport/
Max. process+thread count3599 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…classes in hbase-server and mark them as IA.LimitedPrivate
@Apache9

Copy link
Copy Markdown
ContributorAuthor

Thank you @saintstack . Finally I think I found a way to do renaming instead of moving. This is the release note of this issue. PTAL. Shout if you do not think it is good enough.

Copy HBaseCommonTestingUtility, HBaseZKTestingUtility, HBaseTestingUtility, HBaseCluster, MiniHBaseCluster, StartMiniClusterOption to hbase-testing-util, and mark them as Deprecated. They will be removed in 4.0.0. End users should use TestingHBaseCluster for writing UTs in the future.

And in hbase-server and related modules, these classes are renamed.
HBaseCommonTestingUtility -> HBaseCommonTestingUtil
HBaseZKTestingUtility -> HBaseZKTestingUtil
HBaseTestingUtility -> HBaseTestingUtil
HBaseCluster -> HBaseClusterInterface
MiniHBaseCluster -> SingleProcessHBaseCluster
StartMiniClusterOption -> StartTestingClusterOption
And all these classes are marked as IA.LimitedPrivate("Phoenix"), and IS.Evolving. Except Phoenix, other end users should not use them any more.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 23sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 8sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 0smaster passed
+1 💚compile14m 14smaster passed
+1 💚checkstyle7m 27smaster passed
+1 💚spotbugs13m 36smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall4m 6sthe patch passed
+1 💚compile14m 31sthe patch passed
-0 ⚠️javac0m 46shbase-common generated 5 new + 155 unchanged - 4 fixed = 160 total (was 159)
-0 ⚠️javac0m 27shbase-zookeeper generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
-0 ⚠️javac3m 21shbase-server generated 97 new + 96 unchanged - 97 fixed = 193 total (was 193)
-0 ⚠️javac0m 46shbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198)
-0 ⚠️javac0m 30shbase-testing-util generated 100 new + 1 unchanged - 0 fixed = 101 total (was 1)
-0 ⚠️checkstyle1m 37shbase-server: The patch generated 92 new + 1460 unchanged - 28 fixed = 1552 total (was 1488)
-0 ⚠️checkstyle0m 18shbase-testing-util: The patch generated 174 new + 0 unchanged - 0 fixed = 174 total (was 0)
-0 ⚠️checkstyle0m 19shbase-it: The patch generated 2 new + 119 unchanged - 0 fixed = 121 total (was 119)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
+1 💚hadoopcheck22m 49sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs18m 12sthe patch passed
_ Other Tests _
+1 💚asflicense3m 31sThe patch does not generate ASF License warnings.
129m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3478
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
unameLinux 385d216c7b8c 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-compile-javac-hbase-testing-util.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-testing-util.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-it.txt
Max. process+thread count87 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 12sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall4m 45smaster passed
+1 💚compile9m 22smaster passed
+1 💚shadedjars8m 14sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 27smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 14sthe patch passed
+1 💚compile9m 16sthe patch passed
+1 💚javac9m 16sthe patch passed
+1 💚shadedjars8m 17spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 22sthe patch passed
_ Other Tests _
+1 💚unit1m 52shbase-common in the patch passed.
+1 💚unit1m 23shbase-client in the patch passed.
+1 💚unit0m 46shbase-zookeeper in the patch passed.
+1 💚unit0m 29shbase-replication in the patch passed.
+1 💚unit7m 42shbase-balancer in the patch passed.
+1 💚unit0m 45shbase-http in the patch passed.
+1 💚unit1m 25shbase-asyncfs in the patch passed.
+1 💚unit1m 45shbase-procedure in the patch passed.
+1 💚unit137m 57shbase-server in the patch passed.
+1 💚unit10m 19shbase-mapreduce in the patch passed.
+1 💚unit1m 37shbase-testing-util in the patch passed.
+1 💚unit6m 31shbase-thrift in the patch passed.
+1 💚unit7m 6shbase-shell in the patch passed.
+1 💚unit2m 55shbase-endpoint in the patch passed.
+1 💚unit8m 58shbase-backup in the patch passed.
+1 💚unit1m 12shbase-it in the patch passed.
+1 💚unit3m 44shbase-rest in the patch passed.
+1 💚unit1m 48shbase-examples in the patch passed.
+1 💚unit1m 23shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 10shbase-client-project in the patch passed.
+1 💚unit1m 8shbase-shaded-client-project in the patch passed.
271m 45s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ed881b40ea4c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/testReport/
Max. process+thread count5015 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 21sDocker mode activated.
-0 ⚠️yetus0m 11sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 1smaster passed
+1 💚compile8m 11smaster passed
+1 💚shadedjars9m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc5m 58smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 5sthe patch passed
+1 💚compile8m 10sthe patch passed
+1 💚javac8m 10sthe patch passed
+1 💚shadedjars9m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 2sthe patch passed
_ Other Tests _
+1 💚unit1m 50shbase-common in the patch passed.
+1 💚unit1m 26shbase-client in the patch passed.
+1 💚unit0m 46shbase-zookeeper in the patch passed.
+1 💚unit0m 36shbase-replication in the patch passed.
+1 💚unit12m 7shbase-balancer in the patch passed.
+1 💚unit0m 49shbase-http in the patch passed.
+1 💚unit1m 41shbase-asyncfs in the patch passed.
+1 💚unit2m 10shbase-procedure in the patch passed.
+1 💚unit212m 12shbase-server in the patch passed.
+1 💚unit14m 22shbase-mapreduce in the patch passed.
+1 💚unit1m 35shbase-testing-util in the patch passed.
+1 💚unit9m 9shbase-thrift in the patch passed.
+1 💚unit7m 4shbase-shell in the patch passed.
+1 💚unit3m 18shbase-endpoint in the patch passed.
+1 💚unit13m 0shbase-backup in the patch passed.
+1 💚unit1m 8shbase-it in the patch passed.
+1 💚unit5m 0shbase-rest in the patch passed.
+1 💚unit2m 18shbase-examples in the patch passed.
+1 💚unit1m 30shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 11shbase-client-project in the patch passed.
+1 💚unit1m 8shbase-shaded-client-project in the patch passed.
358m 1s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d31a460201bc 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/testReport/
Max. process+thread count3213 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 10sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 59smaster passed
+1 💚compile14m 18smaster passed
+1 💚checkstyle7m 30smaster passed
+1 💚spotbugs13m 38smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 0sthe patch passed
+1 💚compile14m 23sthe patch passed
+1 💚javac0m 46shbase-common generated 0 new + 155 unchanged - 4 fixed = 155 total (was 159)
+1 💚javac0m 56shbase-client in the patch passed.
-0 ⚠️javac0m 27shbase-zookeeper generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
+1 💚javac0m 23shbase-replication in the patch passed.
+1 💚javac0m 30shbase-balancer in the patch passed.
+1 💚javac0m 28shbase-http in the patch passed.
+1 💚javac0m 26shbase-asyncfs in the patch passed.
+1 💚javac0m 32shbase-procedure in the patch passed.
-0 ⚠️javac3m 16shbase-server generated 97 new + 96 unchanged - 97 fixed = 193 total (was 193)
-0 ⚠️javac0m 47shbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198)
-0 ⚠️javac0m 30shbase-testing-util generated 100 new + 1 unchanged - 0 fixed = 101 total (was 1)
+1 💚javac0m 56shbase-thrift in the patch passed.
+1 💚javac0m 23shbase-shell in the patch passed.
+1 💚javac0m 31shbase-endpoint in the patch passed.
+1 💚javac0m 36shbase-backup in the patch passed.
+1 💚javac0m 39shbase-it in the patch passed.
+1 💚javac0m 39shbase-rest in the patch passed.
+1 💚javac0m 35shbase-examples in the patch passed.
+1 💚javac0m 14shbase-shaded-testing-util-tester in the patch passed.
+1 💚javac0m 25shbase-client-project in the patch passed.
+1 💚javac0m 24shbase-shaded-client-project in the patch passed.
-0 ⚠️checkstyle1m 35shbase-server: The patch generated 13 new + 1445 unchanged - 43 fixed = 1458 total (was 1488)
-0 ⚠️checkstyle0m 18shbase-testing-util: The patch generated 174 new + 0 unchanged - 0 fixed = 174 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚hadoopcheck20m 0sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs17m 26sthe patch passed
_ Other Tests _
+1 💚asflicense3m 31sThe patch does not generate ASF License warnings.
124m 41s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3478
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
unameLinux 95a515dd5188 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/diff-compile-javac-hbase-testing-util.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/diff-checkstyle-hbase-testing-util.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed. Looks great. +1

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 12sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall4m 10smaster passed
+1 💚compile9m 15smaster passed
+1 💚shadedjars8m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 24smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 13sthe patch passed
+1 💚compile9m 16sthe patch passed
+1 💚javac9m 16sthe patch passed
+1 💚shadedjars8m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 26sthe patch passed
_ Other Tests _
+1 💚unit1m 50shbase-common in the patch passed.
+1 💚unit1m 23shbase-client in the patch passed.
+1 💚unit0m 46shbase-zookeeper in the patch passed.
+1 💚unit0m 28shbase-replication in the patch passed.
+1 💚unit7m 42shbase-balancer in the patch passed.
+1 💚unit0m 45shbase-http in the patch passed.
+1 💚unit1m 27shbase-asyncfs in the patch passed.
+1 💚unit1m 45shbase-procedure in the patch passed.
+1 💚unit137m 57shbase-server in the patch passed.
+1 💚unit10m 16shbase-mapreduce in the patch passed.
+1 💚unit1m 34shbase-testing-util in the patch passed.
+1 💚unit6m 25shbase-thrift in the patch passed.
+1 💚unit7m 7shbase-shell in the patch passed.
+1 💚unit2m 56shbase-endpoint in the patch passed.
+1 💚unit9m 5shbase-backup in the patch passed.
+1 💚unit1m 12shbase-it in the patch passed.
+1 💚unit3m 47shbase-rest in the patch passed.
+1 💚unit1m 48shbase-examples in the patch passed.
+1 💚unit1m 19shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 11shbase-client-project in the patch passed.
+1 💚unit1m 11shbase-shaded-client-project in the patch passed.
270m 35s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ed24b47c312e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/testReport/
Max. process+thread count5054 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 22sDocker mode activated.
-0 ⚠️yetus0m 11sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 3smaster passed
+1 💚compile8m 6smaster passed
+1 💚shadedjars9m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc5m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile8m 13sthe patch passed
+1 💚javac8m 13sthe patch passed
+1 💚shadedjars9m 1spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 1sthe patch passed
_ Other Tests _
+1 💚unit1m 50shbase-common in the patch passed.
+1 💚unit1m 26shbase-client in the patch passed.
+1 💚unit0m 46shbase-zookeeper in the patch passed.
+1 💚unit0m 36shbase-replication in the patch passed.
+1 💚unit12m 5shbase-balancer in the patch passed.
+1 💚unit0m 49shbase-http in the patch passed.
+1 💚unit1m 40shbase-asyncfs in the patch passed.
+1 💚unit2m 9shbase-procedure in the patch passed.
+1 💚unit212m 1shbase-server in the patch passed.
+1 💚unit14m 11shbase-mapreduce in the patch passed.
+1 💚unit1m 39shbase-testing-util in the patch passed.
+1 💚unit9m 11shbase-thrift in the patch passed.
+1 💚unit7m 5shbase-shell in the patch passed.
+1 💚unit3m 19shbase-endpoint in the patch passed.
+1 💚unit12m 56shbase-backup in the patch passed.
+1 💚unit1m 8shbase-it in the patch passed.
+1 💚unit5m 1shbase-rest in the patch passed.
+1 💚unit2m 15shbase-examples in the patch passed.
+1 💚unit1m 28shbase-shaded-testing-util-tester in the patch passed.
+1 💚unit1m 10shbase-client-project in the patch passed.
+1 💚unit1m 7shbase-shaded-client-project in the patch passed.
357m 17s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3478
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 62ebe8952bb5 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d1bf1
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/testReport/
Max. process+thread count3458 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit d30cc27 into apache:masterJul 19, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@saintstack