Skip to content

HBASE-26114 when “hbase.mob.compaction.threads.max” is set to a negat… - #3541

Merged
anoopsjohn merged 2 commits into
apache:branch-2from
liever18:HBASE-26114
Jul 30, 2021
Merged

HBASE-26114 when “hbase.mob.compaction.threads.max” is set to a negat…#3541
anoopsjohn merged 2 commits into
apache:branch-2from
liever18:HBASE-26114

Conversation

@liever18

@liever18liever18 commented Jul 29, 2021

Copy link
Copy Markdown

[https://issues.apache.org/jira/projects/HBASE/issues/HBASE-26114]
Description of PR
fix bug HBASE-26114

When the value is set to a negative number, such as -1, Hmaster cannot start normally. When MOB_COMPACTION_THREADS_MAX is set to 0, mobUtil will set it to 1. But the program does not take into account that it is set to a negative number.

changge
modified
if (maxThreads == 0) {
to
if (maxThreads <= 0) {
to improve the handling mechanism for the user to set hbase.mob.compaction.threads.max as an abnormal value.

@liever18
HBASE-26114 when “hbase.mob.compaction.threads.max” is set to a negat…
5d0b1ac
…ive number, HMaster cannot start normally
improve the handling mechanism for the user to set hbase.mob.compaction.threads.max as an abnormal value.
@Apache-HBase

Apache-HBase commented Jul 29, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall4m 38sbranch-2 passed
+1 💚compile3m 43sbranch-2 passed
+1 💚checkstyle1m 10sbranch-2 passed
+1 💚spotbugs2m 28sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 39sthe patch passed
+1 💚compile3m 37sthe patch passed
+1 💚javac3m 37sthe patch passed
+1 💚checkstyle1m 14sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 39sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 25sthe patch passed
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
46m 6s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3541
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 502657d5a664 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 29, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 36sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
-1 ❌mvninstall5m 23sroot in branch-2 failed.
+1 💚compile1m 39sbranch-2 passed
+1 💚shadedjars9m 38sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 7sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall6m 44sthe patch passed
+1 💚compile1m 47sthe patch passed
+1 💚javac1m 47sthe patch passed
+1 💚shadedjars10m 29spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 4sthe patch passed
_ Other Tests _
+1 💚unit232m 38shbase-server in the patch passed.
275m 49s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3541
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 15dc58fbc7ce 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-11.0.10+9
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/1/testReport/
Max. process+thread count2822 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@liever18
HBASE-26114 when hbase.mob.compaction.threads.max is set to a negativ…
89a5915
…e number, HMaster cannot start normally
add modification instructions
@Apache-HBase

Apache-HBase commented Jul 30, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 14sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall3m 39sbranch-2 passed
+1 💚compile3m 13sbranch-2 passed
+1 💚checkstyle1m 7sbranch-2 passed
+1 💚spotbugs2m 4sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 17sthe patch passed
+1 💚compile3m 9sthe patch passed
+1 💚javac3m 9sthe patch passed
-0 ⚠️checkstyle1m 5shbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-0 ⚠️whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚hadoopcheck12m 7sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 13sthe patch passed
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
41m 3s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3541
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux dacfb72f376c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / f049301
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/2/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count95 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 30, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 21sbranch-2 passed
+1 💚compile1m 6sbranch-2 passed
+1 💚shadedjars7m 21sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 45sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 9sthe patch passed
+1 💚compile1m 12sthe patch passed
+1 💚javac1m 12sthe patch passed
+1 💚shadedjars7m 12spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 40sthe patch passed
_ Other Tests _
+1 💚unit133m 51shbase-server in the patch passed.
163m 55s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3541
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8d0fed63d429 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / f049301
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/2/testReport/
Max. process+thread count4113 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 30, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 40sbranch-2 passed
+1 💚compile0m 59sbranch-2 passed
+1 💚shadedjars6m 29sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 26sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
+1 💚shadedjars6m 32spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37sthe patch passed
_ Other Tests _
+1 💚unit154m 58shbase-server in the patch passed.
181m 15s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3541
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4a7c52e86077 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / f049301
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/2/testReport/
Max. process+thread count3660 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@anoopsjohn
anoopsjohn merged commit 6df4cb1 into apache:branch-2Jul 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anoopsjohnanoopsjohnanoopsjohn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liever18@Apache-HBase@anoopsjohn