Skip to content

HBASE-26125 Backport HBASE-25401 "Add trace support for async call in… - #3543

Merged
taklwu merged 1 commit into
apache:branch-2from
taklwu:HBASE-26125
Aug 2, 2021
Merged

HBASE-26125 Backport HBASE-25401 "Add trace support for async call in…#3543
taklwu merged 1 commit into
apache:branch-2from
taklwu:HBASE-26125

Conversation

@taklwu

@taklwutaklwu commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

… rpc client" to branch-2

2/17 commits of HBASE-22120

original commit is 2420286

@Apache9Stephen Wu
HBASE-26125 Backport HBASE-25401 "Add trace support for async call in…
df580f6
… rpc client" to branch-2
2/17 commits of HBASE-22120
@Apache-HBase

Apache-HBase commented Jul 29, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for branch
+1 💚mvninstall4m 0sbranch-2 passed
+1 💚compile9m 18sbranch-2 passed
+1 💚checkstyle2m 28sbranch-2 passed
+1 💚spotbugs16m 34sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall3m 40sthe patch passed
+1 💚compile9m 19sthe patch passed
+1 💚cc9m 19sthe patch passed
+1 💚javac9m 19sthe patch passed
+1 💚checkstyle2m 26sroot: The patch generated 0 new + 22 unchanged - 4 fixed = 22 total (was 26)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚hadoopcheck13m 6sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc6m 22sthe patch passed
+1 💚spotbugs17m 26sthe patch passed
_ Other Tests _
+1 💚asflicense0m 57sThe patch does not generate ASF License warnings.
97m 2s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3543
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml
unameLinux aa49cd5524a0 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / f049301
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count127 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 30, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 30sMaven dependency ordering for branch
+1 💚mvninstall5m 16sbranch-2 passed
+1 💚compile4m 2sbranch-2 passed
+1 💚shadedjars11m 38sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 9sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 29sMaven dependency ordering for patch
+1 💚mvninstall6m 40sthe patch passed
+1 💚compile4m 2sthe patch passed
+1 💚javac4m 2sthe patch passed
+1 💚shadedjars11m 19spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 15sthe patch passed
_ Other Tests _
+1 💚unit206m 10sroot in the patch passed.
268m 37s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3543
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2d0f1a3d1173 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / f049301
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/testReport/
Max. process+thread count6109 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 30, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall3m 43sbranch-2 passed
+1 💚compile8m 56sbranch-2 passed
+1 💚checkstyle2m 6sbranch-2 passed
+1 💚spotbugs15m 17sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile9m 6sthe patch passed
+1 💚cc9m 6sthe patch passed
-0 ⚠️javac9m 6sroot generated 2 new + 1885 unchanged - 2 fixed = 1887 total (was 1887)
+1 💚checkstyle2m 3sroot: The patch generated 0 new + 22 unchanged - 4 fixed = 22 total (was 26)
+1 💚whitespace0m 1sThe patch has no whitespace issues.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
+1 💚hadoopcheck12m 7sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc6m 23sthe patch passed
+1 💚spotbugs16m 38sthe patch passed
_ Other Tests _
+1 💚asflicense1m 7sThe patch does not generate ASF License warnings.
91m 51s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3543
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml
unameLinux 7797daa2f1a0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / f049301
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count141 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 30, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 37sMaven dependency ordering for branch
+1 💚mvninstall4m 19sbranch-2 passed
+1 💚compile3m 9sbranch-2 passed
+1 💚shadedjars7m 48sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 55sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall4m 21sthe patch passed
+1 💚compile3m 7sthe patch passed
+1 💚javac3m 7sthe patch passed
+1 💚shadedjars7m 43spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 54sthe patch passed
_ Other Tests _
+1 💚unit183m 33sroot in the patch passed.
229m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3543
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 60bed9e656fd 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / f049301
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/testReport/
Max. process+thread count6538 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 30, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall3m 39sbranch-2 passed
+1 💚compile2m 22sbranch-2 passed
+1 💚shadedjars6m 27sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 40sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 21sthe patch passed
+1 💚compile2m 18sthe patch passed
+1 💚javac2m 18sthe patch passed
+1 💚shadedjars6m 26spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 44sthe patch passed
_ Other Tests _
-1 ❌unit311m 56sroot in the patch failed.
348m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3543
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 487544cd80d2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / f049301
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/testReport/
Max. process+thread count4545 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@taklwu

taklwu commented Jul 30, 2021

Copy link
Copy Markdown
ContributorAuthor

that two failure tests TestVerifyReplicationCrossDiffHdfs (timeout) and TestReplicationEmptyWALRecovery are unrelated. it's passing locally

% mvn clean test -Dtest=TestVerifyReplicationCrossDiffHdfs
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 57.183 s - in org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M4:test (secondPartTestsExecution) @ hbase-mapreduce ---
[INFO] Tests are skipped.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:14 min
[INFO] Finished at: 2021-07-30T11:26:07-07:00
[INFO] ------------------------------------------------------------------------
% mvn clean test -Dtest=TestReplicationEmptyWALRecovery
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.replication.TestReplicationEmptyWALRecovery
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 44.277 s - in org.apache.hadoop.hbase.replication.TestReplicationEmptyWALRecovery
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M4:test (secondPartTestsExecution) @ hbase-server ---
[INFO] Tests are skipped.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:26 min
[INFO] Finished at: 2021-07-30T11:24:14-07:00
[INFO] ------------------------------------------------------------------------

petersomogyi
petersomogyi approved these changes Aug 2, 2021
View reviewed changes

@petersomogyipetersomogyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean cherry-pick.

@taklwu
taklwu merged commit ca09643 into apache:branch-2Aug 2, 2021
taklwu added a commit that referenced this pull request Aug 4, 2021
@taklwu
Revert "HBASE-26125BackportHBASE-25401"Add trace support for async…
d007b52
… call in rpc client" to branch-2 (#3543)"
This reverts commit ca09643.
taklwu added a commit to taklwu/hbase that referenced this pull request Aug 4, 2021
@taklwu
Revert "HBASE-26125 Backport HBASE-25401 "Add trace support for async…
8a28556
… call in rpc client" to branch-2 (apache#3543)"
This reverts commit ca09643.
@taklwutaklwu mentioned this pull request Aug 4, 2021
Closed
taklwu added a commit that referenced this pull request Aug 4, 2021
@taklwu
Revert "HBASE-26125BackportHBASE-25401"Add trace support for async…
fffdcba
… call in rpc client" to branch-2 (#3543)"
This reverts commit ca09643.
taklwu added a commit that referenced this pull request Aug 5, 2021
@taklwu
HBASE-26125BackportHBASE-25401"Add trace support for async call in…
82d4765
… rpc client" to branch-2 (#3543)
2/17 commits of HBASE-22120
Co-authored-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
taklwu added a commit that referenced this pull request Aug 27, 2021
@taklwu
HBASE-26125BackportHBASE-25401"Add trace support for async call in…
1beffa7
… rpc client" to branch-2 (#3543)
2/17 commits of HBASE-22120
Co-authored-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
taklwu added a commit that referenced this pull request Sep 1, 2021
@taklwu
HBASE-26125BackportHBASE-25401"Add trace support for async call in…
4dfc59c
… rpc client" to branch-2 (#3543)
2/17 commits of HBASE-22120
Co-authored-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersomogyipetersomogyipetersomogyi approved these changes
@apurtellapurtellAwaiting requested review from apurtell
@Apache9Apache9Awaiting requested review from Apache9
@wchevreuilwchevreuilAwaiting requested review from wchevreuil
@anoopsjohnanoopsjohnAwaiting requested review from anoopsjohn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@taklwu@Apache-HBase@petersomogyi@Apache9