HBASE-21606 document meta table load metrics by symat · Pull Request #369 · apache/hbase

symat · 2019-07-09T15:36:31Z

I also attached a screenshot in jira (to see the formatting): HBASE-21606-v1.png

Apache-HBase · 2019-07-09T16:03:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	28	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
+1	mvninstall	266	master passed
0	refguide	475	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
		_ Patch Compile Tests _
+1	mvninstall	237	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
0	refguide	482	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
		_ Other Tests _
+1	asflicense	14	The patch does not generate ASF License warnings.
		1568

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/1/artifact/out/Dockerfile
GITHUB PR	#369
Optional Tests	dupname asflicense refguide
uname	Linux 4ddc4bc5658f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `9ac9505`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/1/artifact/out/branch-site/book.html
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/1/artifact/out/patch-site/book.html
Max. process+thread count	96 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

busbey · 2019-07-09T16:50:02Z

here's the new section in the rendering the QA bot did: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/1/artifact/out/patch-site/book.html#rs_meta_metrics

xcangCRM

+1.
In general, the content is accurate.
Please address some grammar issues pointed by Sean. Thanks!

xcangCRM · 2019-07-09T18:28:10Z

+[[rs_meta_metrics]]
+=== Meta Table Load Metrics
+
+HBase meta table metrics collection feature is available in HBase 1.4+ but it is disabled by default, as it can


Actually, it's available since 1.3
Could you please double check that? thanks

Thanks, I just checked it. I don't find the MetaTableMetrics coprocessor or the lossy counting related config parameter in 1.3.
Also the whole metrics system was changed between 1.3 and 1.4 (you don't have the hbase-metrics maven module in 1.3), I guess this is why it wasn't merged back from 1.4.

the-sakthi

Just one suggestion. Other than that, the update looks great! Thanks @symat

Apache-HBase · 2019-07-12T20:06:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	142	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
+1	mvninstall	315	master passed
0	refguide	853	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
		_ Patch Compile Tests _
+1	mvninstall	344	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
0	refguide	566	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
		_ Other Tests _
+1	asflicense	17	The patch does not generate ASF License warnings.
		2305

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/2/artifact/out/Dockerfile
GITHUB PR	#369
Optional Tests	dupname asflicense refguide
uname	Linux ec5316c571e6 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `438bf32`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/2/artifact/out/branch-site/book.html
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/2/artifact/out/patch-site/book.html
Max. process+thread count	86 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

the-sakthi · 2019-07-12T21:08:05Z

+1. Thanks @symat

Apache-HBase · 2019-07-15T13:21:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	33	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
+1	mvninstall	255	master passed
0	refguide	465	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
		_ Patch Compile Tests _
+1	mvninstall	244	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
0	refguide	438	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
		_ Other Tests _
+1	asflicense	16	The patch does not generate ASF License warnings.
		1507

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/3/artifact/out/Dockerfile
GITHUB PR	#369
Optional Tests	dupname asflicense refguide
uname	Linux 6d1511253183 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `74731c2`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/3/artifact/out/branch-site/book.html
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/3/artifact/out/patch-site/book.html
Max. process+thread count	96 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Closes#369 Signed-off-by: Xu Cang <xcang@apache.org> Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com> Signed-off-by: Sean Busbey <busbey@apache.org> (cherry picked from commit e5f05bf)

Closesapache#369 Signed-off-by: Xu Cang <xcang@apache.org> Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com> Signed-off-by: Sean Busbey <busbey@apache.org> (cherry picked from commit e5f05bf) (cherry picked from commit 10d2499) Change-Id: I575556cec560378f0a1057f8ad604ed4b17d7968

HBASE-21606 document meta table load metrics
313142c

busbey requested changes Jul 9, 2019
View reviewed changes

xcangCRM approved these changes Jul 9, 2019
View reviewed changes

Comment threadsrc/main/asciidoc/_chapters/ops_mgt.adoc

xcangCRM reviewed Jul 9, 2019
View reviewed changes

xcangCRM self-requested a review July 9, 2019 18:28

HBASE-21606 implement code review comments
5efe755

the-sakthi reviewed Jul 11, 2019
View reviewed changes

Comment threadsrc/main/asciidoc/_chapters/ops_mgt.adoc

the-sakthi reviewed Jul 11, 2019
View reviewed changes

HBASE-21606 adding example MetaTable metrics to the documentation
b14bfd6

the-sakthi approved these changes Jul 12, 2019
View reviewed changes

busbey approved these changes Jul 15, 2019
View reviewed changes

asfgit closed this in e5f05bfJul 15, 2019

wchevreuil mentioned this pull request Feb 2, 2022
HBASE-26707: Reduce number of renames during bulkload #4066
Merged

Navigation Menu

Uh oh!

HBASE-21606 document meta table load metrics - #369

HBASE-21606 document meta table load metrics#369
symat wants to merge 3 commits into
apache:masterfrom
symat:HBASE-21606

symat commented Jul 9, 2019

Uh oh!

Apache-HBase commented Jul 9, 2019

Uh oh!

busbey commented Jul 9, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xcangCRM left a comment

Uh oh!

Uh oh!

xcangCRMJul 9, 2019

Uh oh!

symatJul 11, 2019

Uh oh!

Uh oh!

the-sakthi left a comment •
edited
Loading

Uh oh!

Apache-HBase commented Jul 12, 2019

Uh oh!

the-sakthi commented Jul 12, 2019

Uh oh!

Apache-HBase commented Jul 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

symat commented Jul 9, 2019

Uh oh!

Apache-HBase commented Jul 9, 2019

Uh oh!

busbey commented Jul 9, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xcangCRM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xcangCRMJul 9, 2019

Choose a reason for hiding this comment

Uh oh!

symatJul 11, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

the-sakthi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jul 12, 2019

Uh oh!

the-sakthi commented Jul 12, 2019

Uh oh!

Apache-HBase commented Jul 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

the-sakthi left a comment •
edited
Loading