Uh oh!
There was an error while loading. Please reload this page.
HBASE-26707: Reduce number of renames during bulkload - #4066
Merged
Conversation
move files directly to the store dir when requireWritingToTmpDirFirst is false fix failedBulkLoad to work on second call change existing tests to run without tmp folder too add tests for SecureBulkLoadListener
Apache-HBase
commented
Jan 26, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 26, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 26, 2022
🎊 +1 overall
This message was automatically generated. |
BukrosSzabolcs
commented
Jan 26, 2022
ContributorAuthor
@Apache9 , @wchevreuil, @joshelser Could you please take a look? |
Apache-HBase
commented
Jan 31, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 31, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 1, 2022
🎊 +1 overall
This message was automatically generated. |
wchevreuil
left a comment
Contributor
There was a problem hiding this comment.
Overall, looks good, just some nits, and two additional questions.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| // Source filesystem | ||
| private FileSystem srcFs = null; | ||
| private Map<String, FsPermission> origPermissions = null; | ||
| private Map<String, String> origlSources = null; |
Contributor
There was a problem hiding this comment.
Could be <String,Path> and save need for path conversion again in failedBulkLoad?
Contributor
There was a problem hiding this comment.
nit: origSources instead of origlSources?
ContributorAuthor
There was a problem hiding this comment.
I left it like that because origPermissions uses String as well so a conversion would be done anyway. And while I could switch both of those to use Paths, log messages will need a string too.
Contributor
There was a problem hiding this comment.
I left it like that because
origPermissionsuses String as well so a conversion would be done anyway. And while I could switch both of those to use Paths, log messages will need a string too.
Ok, let's just then follow var naming pattern, then.
Uh oh!
There was an error while loading. Please reload this page.
| LOG.debug("Moving " + p + " to " + stageP); | ||
| FileStatus origFileStatus = fs.getFileStatus(p); | ||
| origPermissions.put(srcPath, origFileStatus.getPermission()); | ||
| origlSources.put(stageP.toString(), srcPath); |
Contributor
There was a problem hiding this comment.
One idea for FILE SFT, could we always force the copy option above, instead of this one that relies on rename?
ContributorAuthor
There was a problem hiding this comment.
We could. My only concern is that it might be impractical over a certain data size especially if there is no config or param that would allow the user to use rename if they need to.
What do you think?
Contributor
There was a problem hiding this comment.
True. My main concern is how safe this rename would be, if we don't have hboss in the picture. Could concurrent bulkloads be a problem in such cases? Maybe a workaround for such deployments would be to always pass a custom staging dir?
ContributorAuthor
There was a problem hiding this comment.
I do not think concurrency is an issue. SecureBulkLoadListener keeps track of the moved files and a separate listener is created for each region in each bulkLoad. So even with parallel bulkLoads they can not touch each other's files. Using the same source folder can be an issue but it always was an issue.
I'm not sure I understand your comment about "always pass a custom staging dir". The staging dir by default is different for each bulkLoad process. I break this by introducing the "custom staging dir" which always points to the live data folder as a workaround to skip moving hfiles to an actual staging dir without loosing the existing error handling. We can't change it and decrease the number of moves at the same time.
Contributor
There was a problem hiding this comment.
Ah, yeah, then we would need to rename from the custom stage to the actual dir anyways. I think we can leave it this way.
For S3 with SFT, I think the best practice would be to pass the copy option, for consistency. Shouldn't have much difference, as s3 renames are basically copies.
wchevreuil
approved these changes
Feb 15, 2022
wchevreuil
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a small nit on variable naming pending, but am good to go without it.
Apache-HBase
commented
Feb 17, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 17, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 17, 2022
🎊 +1 overall
This message was automatically generated. |
BukrosSzabolcs
commented
Feb 17, 2022
ContributorAuthor
Thanks a lot @wchevreuil for your feedback and merging this! |
BukrosSzabolcs added a commit
to BukrosSzabolcs/hbase
that referenced
this pull request
Feb 22, 2022
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit
that referenced
this pull request
Feb 25, 2022
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
apurtell pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 18, 2022
…pache#4122) Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java
apurtell pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 19, 2022
…pache#4122) Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java
apurtell pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 25, 2022
…pache#4122) Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java
apurtell pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 26, 2022
…pache#4122) Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java
apurtell added a commit
to apurtell/hbase
that referenced
this pull request
Mar 26, 2022
…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9 HBASE-25988 Store the store file list by a file apache#3578) commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging apache#3617) commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… apache#3656) commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table apache#3666) commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… apache#3665) commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… apache#3681) commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting apache#3685) commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… apache#3721) commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… apache#3774) commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl apache#3749) commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… apache#3700) commit a288365 HBASE-26271: Cleanup the broken store files under data directory apache#3786) commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… apache#3845) commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… apache#3942) commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META apache#3998) commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… apache#4010) commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading apache#4006) commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… apache#4034) commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock apache#4040) commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer apache#4035) commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… apache#4055) commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… apache#4054) commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… apache#4080) commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation apache#4113) commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … apache#4111) commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (apache#4066) apache#4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous apache#4082) commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… apache#4226) commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (apache#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <elserj@apache.org> Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
apurtell pushed a commit
that referenced
this pull request
Mar 26, 2022
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java
apurtell added a commit
that referenced
this pull request
Mar 26, 2022
…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9HBASE-25988 Store the store file list by a file #3578) commit 6e05376HBASE-26079 Use StoreFileTracker when splitting and merging #3617) commit 090b2feHBASE-26224HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… #3656) commit 0ee1689HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table #3666) commit 2052e80HBASE-26248 Should find a suitable way to let users specify the store… #3665) commit 5ff0f98HBASE-26264 Add more checks to prevent misconfiguration on store file… #3681) commit fc4f6d1HBASE-26280HBASE-26280 Use store file tracker when snapshoting #3685) commit 06db852HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721) commit e4e7cf8HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774) commit 08d1171HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749) commit 8bec26eHBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700) commit a288365HBASE-26271: Cleanup the broken store files under data directory #3786) commit d00b5faHBASE-26454 CreateTableProcedure still relies on temp dir and renames… #3845) commit 771e552HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1HBASE-26265 Update ref guide to mention the new store file tracker im… #3942) commit 755b3b4HBASE-26585 Add SFT configuration to META table descriptor when creating META #3998) commit 39c42c7HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… #4010) commit 6e1f5b7HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading #4006) commit f1dd865HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… #4034) commit 8fbc9a2HBASE-26674 Should modify filesCompacting under storeWriteLock #4040) commit 5aa0fd2HBASE-26675 Data race on Compactor.writer #4035) commit 3021c58HBASE-26700 The way we bypass broken track file is not enough in Stor… #4055) commit a8b68c9HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… #4054) commit dffeb8eHBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080) commit b265fe5HBASE-26673 Implement a shell command for change SFT implementation #4113) commit 4cdb380HBASE-26640 Reimplement master local region initialization to better … #4111) commit 77bb153HBASE-26707: Reduce number of renames during bulkload (#4066) #4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous #4082) commit d3629bbHBASE-26837 Set SFT config when creating TableDescriptor in TestClone… #4226) commit 541d748HBASE-26881 Backport HBASE-25368 to branch-2 (#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <elserj@apache.org> Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
vinayakphegde pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…pache#4122) Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java Change-Id: I7bc468b99b4641673e42a8fb0e887d6a6088d08e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move files directly to the store dir when requireWritingToTmpDirFirst is
false
fix failedBulkLoad to work on second call
change existing tests to run without tmp folder too
add tests for SecureBulkLoadListener