Skip to content

Backport "HBASE-26616 Refactor code related to ZooKeeper authentication (#3973)" to branch-2.5 - #4020

Merged
ndimiduk merged 1 commit into
apache:branch-2.5from
ndimiduk:26616-refactor-zk-auth-branch-2.5
Jan 11, 2022
Merged

Backport "HBASE-26616 Refactor code related to ZooKeeper authentication (#3973)" to branch-2.5#4020
ndimiduk merged 1 commit into
apache:branch-2.5from
ndimiduk:26616-refactor-zk-auth-branch-2.5

Conversation

@ndimiduk

@ndimidukndimiduk commented Jan 10, 2022

Copy link
Copy Markdown
Member

This refactor reduces the size and scope of the ZKUtil class. The core of this refactor is
moving the login* methods from ZKUtil into their own class, ZKAuthentication. The class
JaasConfiguration is also moved along with them.

Signed-off-by: Andrew Purtell apurtell@apache.org
Signed-off-by: Duo Zhang zhangduo@apache.org

@ndimiduk
HBASE-26616 Refactor code related to ZooKeeper authentication (apache…
eaa2327
…#3973)
This refactor reduces the size and scope of the `ZKUtil` class. The core of this refactor is
moving the `login*` methods from `ZKUtil` into their own class, `ZKAuthentication`. The class
`JaasConfiguration` is also moved along with them.
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Jan 10, 2022
@Apache-HBase

Apache-HBase commented Jan 10, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 37sMaven dependency ordering for branch
+1 💚mvninstall4m 44sbranch-2.5 passed
+1 💚compile3m 47sbranch-2.5 passed
+1 💚checkstyle1m 24sbranch-2.5 passed
+1 💚spotbugs2m 49sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 30sthe patch passed
+1 💚compile3m 45sthe patch passed
+1 💚javac0m 31shbase-zookeeper generated 0 new + 111 unchanged - 1 fixed = 111 total (was 112)
+1 💚javac3m 14shbase-server in the patch passed.
+1 💚checkstyle0m 14shbase-zookeeper: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
+1 💚checkstyle1m 6sThe patch passed checkstyle in hbase-server
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck18m 35sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚spotbugs3m 0sthe patch passed
_ Other Tests _
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
53m 51s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4020
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 247329ab1091 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 6a060ad
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-zookeeper hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 10, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 37sMaven dependency ordering for branch
+1 💚mvninstall4m 56sbranch-2.5 passed
+1 💚compile1m 17sbranch-2.5 passed
+1 💚shadedjars6m 36sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 56sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall3m 35sthe patch passed
+1 💚compile1m 17sthe patch passed
+1 💚javac1m 17sthe patch passed
+1 💚shadedjars6m 35spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 54sthe patch passed
_ Other Tests _
+1 💚unit0m 44shbase-zookeeper in the patch passed.
+1 💚unit146m 39shbase-server in the patch passed.
177m 39s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4020
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f674156bc7e3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 6a060ad
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/testReport/
Max. process+thread count4130 (vs. ulimit of 12500)
modulesC: hbase-zookeeper hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 10, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec9m 8sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall6m 15sbranch-2.5 passed
+1 💚compile1m 44sbranch-2.5 passed
+1 💚shadedjars8m 14sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 6sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for patch
+1 💚mvninstall5m 1sthe patch passed
+1 💚compile1m 38sthe patch passed
+1 💚javac1m 38sthe patch passed
+1 💚shadedjars8m 49spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 17sthe patch passed
_ Other Tests _
+1 💚unit0m 54shbase-zookeeper in the patch passed.
+1 💚unit206m 26shbase-server in the patch passed.
253m 42s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4020
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 79671f2dce5f 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 6a060ad
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/testReport/
Max. process+thread count2663 (vs. ulimit of 12500)
modulesC: hbase-zookeeper hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4020/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit 9ef7f59 into apache:branch-2.5Jan 11, 2022
@ndimiduk
ndimiduk deleted the 26616-refactor-zk-auth-branch-2.5 branch January 11, 2022 00:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndimiduk@Apache-HBase