Uh oh!
There was an error while loading. Please reload this page.
HBASE-22729 Start RSGroupInfoManager as default - #405
Closed
infraio wants to merge 4 commits into
Closed
Conversation
…aded (apache#362) Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: Guanghao Zhang <zghao@apache.org>
…move hbase-rsgroup module (apache#399) Signed-off-by: Zheng Hu <openinx@gmail.com>
Apache9
requested changes
Jul 24, 2019
Apache9
left a comment
Contributor
There was a problem hiding this comment.
I think starting RSGroupInfoManager by default should be done after HBASE-22695? As now we still need the coprocessor...
| groupName = RSGroupInfo.DEFAULT_GROUP; | ||
| } | ||
| targetRSGInfo = rsGroupInfoManager.getRSGroup(groupName); | ||
| } catch (IOException exp) { |
ContributorAuthor
There was a problem hiding this comment.
Seems the base branch is not right...
ContributorAuthor
There was a problem hiding this comment.
oh. The reason is the method didn't throw IOException now. So remove the try...catch thing.
infraio
commented
Jul 24, 2019
ContributorAuthor
What is the whole plan? |
Apache9
commented
Jul 24, 2019
Contributor
https://github.com/Apache9/hbase/tree/HBASE-22695 I'm trying to store the rs group info to table first. It will lead to a huge change. |
Apache-HBase
commented
Jul 24, 2019
💔 -1 overall
This message was automatically generated. |
infraio
commented
Jul 25, 2019
ContributorAuthor
Got it. Will continue this issue later. |
asfgitforce-pushed
the
HBASE-22514
branch
3 times, most recently
from
July 30, 2019 13:01
47d6533 to
1b5f6b5Compareasfgitforce-pushed
the
HBASE-22514
branch
4 times, most recently
from
August 8, 2019 03:58
77e95bd to
e4b1720Compareasfgitforce-pushed
the
HBASE-22514
branch
3 times, most recently
from
August 18, 2019 04:14
32a2015 to
8660b52Compareasfgitforce-pushed
the
HBASE-22514
branch
4 times, most recently
from
August 27, 2019 12:35
4741f66 to
548e8c4Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.