HBASE-27281 Add default implementation for Connection$getClusterId by petersomogyi · Pull Request #4683 · apache/hbase

petersomogyi · 2022-08-08T11:25:00Z

No description provided.

Apache-HBase · 2022-08-08T11:48:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 56s	master passed
+1 💚	compile	0m 20s	master passed
+1 💚	shadedjars	3m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 40s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	shadedjars	3m 47s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 26s	hbase-client in the patch passed.
		18m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4683
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4bbff0fb045d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `54f2106`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/1/testReport/
Max. process+thread count	186 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-08T11:49:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 53s	master passed
+1 💚	compile	0m 20s	master passed
+1 💚	shadedjars	4m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 18s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	3m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 52s	hbase-client in the patch passed.
		18m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4683
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e1d5ff6657c9 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `54f2106`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/1/testReport/
Max. process+thread count	159 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-08T11:56:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 21s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 24s	master passed
+1 💚	compile	0m 37s	master passed
+1 💚	checkstyle	0m 16s	master passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 13s	the patch passed
+1 💚	compile	0m 36s	the patch passed
+1 💚	javac	0m 36s	the patch passed
+1 💚	checkstyle	0m 14s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 34s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
-1 ❌	spotless	0m 18s	patch has 22 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	0m 45s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		25m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4683
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 210f7eff164c 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `54f2106`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-08-08T12:36:05Z

Better throw a UnsupportedOperationException?

petersomogyi · 2022-08-08T13:32:23Z

Better throw a UnsupportedOperationException?

I also thought about that but don't know which is a better solution. For example TokenUtil.getAuthToken checks for null clusterId.

@Apache9 Do you have a better idea of how we could keep compatibility?

Apache9 · 2022-08-08T13:36:38Z

I think that's part of the reason why we do not add a default implementation for it, as we rely on it...

Apache9

Can do this for now.

Apache-HBase · 2022-08-11T14:56:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 27s	master passed
+1 💚	compile	0m 19s	master passed
+1 💚	shadedjars	3m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 13s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	3m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 16s	hbase-client in the patch passed.
		16m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4683
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8ba4305e768c 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bffae99`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/2/testReport/
Max. process+thread count	159 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-11T15:00:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 43s	master passed
+1 💚	compile	0m 16s	master passed
+1 💚	shadedjars	3m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	shadedjars	3m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 19s	hbase-client in the patch passed.
		19m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4683
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1426ae310695 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bffae99`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/2/testReport/
Max. process+thread count	190 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-11T15:06:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 20s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 27s	master passed
+1 💚	compile	0m 38s	master passed
+1 💚	checkstyle	0m 15s	master passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 42s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 10s	the patch passed
+1 💚	compile	0m 37s	the patch passed
+1 💚	javac	0m 37s	the patch passed
+1 💚	checkstyle	0m 14s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 37s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 43s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 45s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		26m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4683
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 692cce70a1e5 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bffae99`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4683/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2022-08-11T15:08:27Z

Thanks team.

…4683) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…pache#4683) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit b9a13eb) Change-Id: I39d1ef6a0e5ff6e0f62e5a1fc1b3e4a26843afdb

HBASE-27281 Add default implementation for Connection$getClusterId
877d0d3

petersomogyi requested review from Apache9 and apurtell August 8, 2022 11:25

Apache9 approved these changes Aug 9, 2022
View reviewed changes

javadoc format fix
5c28368

petersomogyi merged commit 39b496e into apache:masterAug 11, 2022

petersomogyi deleted the HBASE-27281 branch August 11, 2022 15:16

petersomogyi added a commit that referenced this pull request Aug 11, 2022
HBASE-27281Add default implementation for Connection$getClusterId (#…
b9a13eb
…4683) Signed-off-by: Duo Zhang <zhangduo@apache.org>

petersomogyi added a commit that referenced this pull request Aug 11, 2022
HBASE-27281Add default implementation for Connection$getClusterId (#…
ad67706
…4683) Signed-off-by: Duo Zhang <zhangduo@apache.org>

petersomogyi added a commit that referenced this pull request Aug 11, 2022
HBASE-27281Add default implementation for Connection$getClusterId (#…
3f5076d
…4683) Signed-off-by: Duo Zhang <zhangduo@apache.org>

Navigation Menu

Uh oh!

HBASE-27281 Add default implementation for Connection$getClusterId - #4683

HBASE-27281 Add default implementation for Connection$getClusterId#4683
petersomogyi merged 2 commits into
apache:masterfrom
petersomogyi:HBASE-27281

petersomogyi commented Aug 8, 2022

Uh oh!

Apache-HBase commented Aug 8, 2022

Uh oh!

Apache-HBase commented Aug 8, 2022

Uh oh!

Apache-HBase commented Aug 8, 2022

Uh oh!

Apache9 commented Aug 8, 2022

Uh oh!

petersomogyi commented Aug 8, 2022

Uh oh!

Apache9 commented Aug 8, 2022

Uh oh!

Apache9 left a comment

Uh oh!

Apache-HBase commented Aug 11, 2022

Uh oh!

Apache-HBase commented Aug 11, 2022

Uh oh!

Apache-HBase commented Aug 11, 2022

Uh oh!

ndimiduk commented Aug 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

petersomogyi commented Aug 8, 2022

Uh oh!

Apache-HBase commented Aug 8, 2022

Uh oh!

Apache-HBase commented Aug 8, 2022

Uh oh!

Apache-HBase commented Aug 8, 2022

Uh oh!

Apache9 commented Aug 8, 2022

Uh oh!

petersomogyi commented Aug 8, 2022

Uh oh!

Apache9 commented Aug 8, 2022

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Aug 11, 2022

Uh oh!

Apache-HBase commented Aug 11, 2022

Uh oh!

Apache-HBase commented Aug 11, 2022

Uh oh!

ndimiduk commented Aug 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants