Uh oh!
There was an error while loading. Please reload this page.
HBASE-26809: Report client backoff time for server overloaded - #4786
Conversation
Apache-HBase
commented
Sep 14, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 14, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 14, 2022
💔 -1 overall
This message was automatically generated. |
briaugenreich
commented
Sep 14, 2022
Looking into the issues above. May be due to my branch being a little behind the branch-2 latest changes. |
Apache-HBase
commented
Sep 14, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 14, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 14, 2022
💔 -1 overall
This message was automatically generated. |
ac21df9 to
13728dcCompare13728dc to
140878eCompareApache-HBase
commented
Sep 15, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2022
💔 -1 overall
This message was automatically generated. |
briaugenreich
commented
Sep 15, 2022
I'm trying to reproduce/troubleshoot the issues above locally. I am able to successfully build with a subset of tests with the following command: When I try to run a spotbugs check locally I get the following error Any tips on troubleshooting my build issues are much appreciated. cc: @bbeaudreault |
briaugenreich
commented
Sep 15, 2022
Actually I think I just found the links to the results on the ci server which is helpful. Though still curious if I can run something locally to test beforehand. |
Apache-HBase
commented
Sep 15, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2022
💔 -1 overall
This message was automatically generated. |
briaugenreich
commented
Sep 15, 2022
Everything looks good here, but not sure what to do for existing spotbugs failures. I don't think I introduced the errors called out in the report. cc: @bbeaudreault |
bbeaudreault
commented
Sep 15, 2022
Yea, the spotbugs issues look related to the recent spotbugs version upgrade. I think they will be tackled in https://issues.apache.org/jira/browse/HBASE-27373. |
Apache-HBase
commented
Sep 15, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2022
🎊 +1 overall
This message was automatically generated. |
briaugenreich
commented
Sep 19, 2022
@bbeaudreault Should I rerun this build? It looks like there were some changes merged to fix the spotbugs warnings (https://issues.apache.org/jira/browse/HBASE-27373) |
Apache-HBase
commented
Sep 19, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 19, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 19, 2022
🎊 +1 overall
This message was automatically generated. |
briaugenreich
commented
Sep 20, 2022
May retrigger this latest build... ran the failing test locally and it seemed happy. |
briaugenreich
commented
Sep 20, 2022
Actually, doesn't look like I have permission to do this. @bbeaudreault Should/can I request access to the build server? |
bbeaudreault
commented
Sep 20, 2022
Unfortunately only committers have access to the build server. I kicked off a rebuild last night. The easiest way for you to self-service this is to push a commit. Sometimes what I used to do is |
4479504 to
45ad745CompareApache-HBase
commented
Sep 20, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 20, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 20, 2022
🎊 +1 overall
This message was automatically generated. |
briaugenreich
commented
Sep 20, 2022
The build looks happy. Ready for review. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
Sep 30, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 30, 2022
🎊 +1 overall
This message was automatically generated. |
briaugenreich
commented
Oct 3, 2022
hmm not sure why the build was aborted, but I can kick off another. |
| interceptor, startLogErrorsCnt, connectionConf.getRpcTimeout(), metrics); | ||
| } | ||
| public static RpcRetryingCallerFactory instantiate(Configuration configuration) { |
There was a problem hiding this comment.
Ok, sorry for the delay here but I've been meaning to look into the usages of these methods. We basically want to ensure that our metrics object is getting in there as often as possible.
So I opened up branch-2 in intellij and looked at the usages of these instantiate overloads:
instantiate(Configuration)-- all of the callers to this method have a ClusterConnection in the call context, which we can pull our metrics from (connection.getConnectionMetrics())- `instantiate(Configuration, ServerStatisticTracker) -- all but the SecureBulkLoadClient and LoadIncrementalHFiles have similar.
So I think we should try to add ConnectionMetrics to all of the methods here, and we can pass null in for the 2 cases above.
Apache-HBase
commented
Oct 14, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 14, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 14, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 17, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 17, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 17, 2022
🎊 +1 overall
This message was automatically generated. |
Co-authored-by: Briana Augenreich <baugenreich@hubspot.com> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…overloaded (apache#4786) Co-authored-by: Briana Augenreich <baugenreich@hubspot.com> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Branch 2 changes for #4729
Enable metric reporting on backoff time when a server is overloaded.