Skip to content

HBASE-27420 Allow non-loopback for zk standalone server in minizkcluster - #4819

Merged
apurtell merged 2 commits into
apache:masterfrom
sanjeet006py:standalone-zk-fix
Oct 11, 2022
Merged

HBASE-27420 Allow non-loopback for zk standalone server in minizkcluster#4819
apurtell merged 2 commits into
apache:masterfrom
sanjeet006py:standalone-zk-fix

Conversation

@sanjeet006py

@sanjeet006pysanjeet006py commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Link to JIRA: https://issues.apache.org/jira/browse/HBASE-27420

Add a provision to allow zk to listen for client connections on non-loopback IP.

@Apache-HBase

Apache-HBase commented Oct 8, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 30smaster passed
+1 💚compile0m 10smaster passed
+1 💚shadedjars4m 3sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 11smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 3sthe patch passed
+1 💚compile0m 10sthe patch passed
+1 💚javac0m 10sthe patch passed
+1 💚shadedjars4m 2spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 9sthe patch passed
_ Other Tests _
+1 💚unit0m 35shbase-zookeeper in the patch passed.
15m 41s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4819
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c210aab837af 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 46d37a7
Default JavaTemurin-1.8.0_345-b01
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/testReport/
Max. process+thread count211 (vs. ulimit of 30000)
modulesC: hbase-zookeeper U: hbase-zookeeper
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 8, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 59sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 38smaster passed
+1 💚compile0m 15smaster passed
+1 💚shadedjars3m 49sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 14smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 34sthe patch passed
+1 💚compile0m 13sthe patch passed
+1 💚javac0m 13sthe patch passed
+1 💚shadedjars3m 46spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 12sthe patch passed
_ Other Tests _
+1 💚unit0m 41shbase-zookeeper in the patch passed.
16m 25s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4819
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a203c029c16c 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 46d37a7
Default JavaEclipse Adoptium-11.0.16.1+1
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/testReport/
Max. process+thread count279 (vs. ulimit of 30000)
modulesC: hbase-zookeeper U: hbase-zookeeper
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 8, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall2m 25smaster passed
+1 💚compile0m 21smaster passed
+1 💚checkstyle0m 10smaster passed
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
+1 💚spotbugs0m 23smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 10sthe patch passed
+1 💚compile0m 19sthe patch passed
+1 💚javac0m 19sthe patch passed
-0 ⚠️checkstyle0m 9shbase-zookeeper: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck7m 56sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌spotless0m 18spatch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚spotbugs0m 25sthe patch passed
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
21m 47s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4819
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux a2b017fd04fd 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 46d37a7
Default JavaTemurin-1.8.0_345-b01
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-zookeeper.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-zookeeper U: hbase-zookeeper
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 8, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 2sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 46smaster passed
+1 💚compile0m 15smaster passed
+1 💚shadedjars3m 47sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 14smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 32sthe patch passed
+1 💚compile0m 14sthe patch passed
+1 💚javac0m 14sthe patch passed
+1 💚shadedjars3m 49spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 12sthe patch passed
_ Other Tests _
+1 💚unit0m 41shbase-zookeeper in the patch passed.
16m 39s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4819
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 96dbbcdb4b34 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 46d37a7
Default JavaEclipse Adoptium-11.0.16.1+1
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/testReport/
Max. process+thread count221 (vs. ulimit of 30000)
modulesC: hbase-zookeeper U: hbase-zookeeper
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 8, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 49sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 41smaster passed
+1 💚compile0m 10smaster passed
+1 💚shadedjars3m 59sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 9smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 4sthe patch passed
+1 💚compile0m 10sthe patch passed
+1 💚javac0m 10sthe patch passed
+1 💚shadedjars3m 58spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 9sthe patch passed
_ Other Tests _
+1 💚unit0m 34shbase-zookeeper in the patch passed.
15m 54s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4819
Optional Testsjavac javadoc unit shadedjars compile
unameLinux bd5b4ab8eb90 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 46d37a7
Default JavaTemurin-1.8.0_345-b01
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/testReport/
Max. process+thread count160 (vs. ulimit of 30000)
modulesC: hbase-zookeeper U: hbase-zookeeper
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 8, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 57sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall2m 14smaster passed
+1 💚compile0m 19smaster passed
+1 💚checkstyle0m 9smaster passed
+1 💚spotless0m 39sbranch has no errors when running spotless:check.
+1 💚spotbugs0m 21smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 10sthe patch passed
+1 💚compile0m 19sthe patch passed
+1 💚javac0m 19sthe patch passed
+1 💚checkstyle0m 8sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck7m 53sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
+1 💚spotbugs0m 25sthe patch passed
_ Other Tests _
+1 💚asflicense0m 9sThe patch does not generate ASF License warnings.
21m 32s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4819
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 483c6c71339d 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 46d37a7
Default JavaTemurin-1.8.0_345-b01
Max. process+thread count60 (vs. ulimit of 30000)
modulesC: hbase-zookeeper U: hbase-zookeeper
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
apurtell merged commit b656456 into apache:masterOct 11, 2022
asfgit pushed a commit that referenced this pull request Oct 11, 2022
@sanjeet006pySanjeet Malhotra@apurtell
HBASE-27420Allow non-loopback for zk standalone server in minizkclus…
440d168
…ter (#4819)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Co-authored-by: Sanjeet Malhotra <sanjeetmalhotra@salesforce.com>
asfgit pushed a commit that referenced this pull request Oct 11, 2022
@sanjeet006pySanjeet Malhotra@apurtell
HBASE-27420Allow non-loopback for zk standalone server in minizkclus…
00f72f3
…ter (#4819)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Co-authored-by: Sanjeet Malhotra <sanjeetmalhotra@salesforce.com>
asfgit pushed a commit that referenced this pull request Oct 11, 2022
@sanjeet006pySanjeet Malhotra@apurtell
HBASE-27420Allow non-loopback for zk standalone server in minizkclus…
72c79b6
…ter (#4819)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Co-authored-by: Sanjeet Malhotra <sanjeetmalhotra@salesforce.com>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@sanjeet006pySanjeet Malhotra@apurtell
HBASE-27420 Allow non-loopback for zk standalone server in minizkclus…
43f8c76
…ter (apache#4819)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Co-authored-by: Sanjeet Malhotra <sanjeetmalhotra@salesforce.com>
(cherry picked from commit 00f72f3)
Change-Id: I25f25c6f38796ab207608f35587bd1637f23ef1a
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apurtellapurtellapurtell approved these changes
@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sanjeet006py@Apache-HBase@apurtell@virajjasani