Skip to content

HBASE-27442 Change the way of bumping version in release scripts - #4844

Merged
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:27442-create-release-versions-set-property
Oct 25, 2022
Merged

HBASE-27442 Change the way of bumping version in release scripts#4844
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:27442-create-release-versions-set-property

Conversation

@ndimiduk

Copy link
Copy Markdown
Member

No description provided.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

Untested...

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess maybe we'd better just use sed to do the replacement...

Comment threaddev-support/create-release/release-util.sh Outdated
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 3sMaven dependency ordering for patch
_ Other Tests _
1m 47s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4844
Optional Tests
unameLinux 065f45e4109a 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2fc879e
Max. process+thread count41 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 3sMaven dependency ordering for patch
_ Other Tests _
1m 46s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4844
Optional Tests
unameLinux 6c8ca57c5520 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2fc879e
Max. process+thread count31 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚spotless0m 38sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
+1 💚shellcheck0m 1sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚spotless0m 36spatch has no errors when running spotless:check.
_ Other Tests _
+0 🆗asflicense0m 0sASF License check generated no output?
3m 37s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4844
Optional Testsdupname asflicense spotless shellcheck shelldocs
unameLinux 8f7d681da468 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2fc879e
Max. process+thread count34 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/1/console
versionsgit=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
Contributor

There is a pending problem that, for branch-2.4, we still need to use the old way to bump the version.

Maybe we could try grep '<revision>' pom.xml, if it does not exist, we go with the old way, otherwise we use the new way.

@ndimiduk

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

Yes good point. We also need to consider correct behavior for releasing our other projects. I've never released from our other repositories before. Let me spend some time on it, will propose a solution.

@ndimiduk
ndimidukforce-pushed the 27442-create-release-versions-set-property branch from da6787a to 50fdbd7CompareOctober 25, 2022 11:38
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 14sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
_ Other Tests _
2m 28s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4844
Optional Tests
unameLinux 18d9d079a900 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2a3d5b1
Max. process+thread count40 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
_ Other Tests _
2m 27s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4844
Optional Tests
unameLinux 2f44c73d1a82 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2a3d5b1
Max. process+thread count32 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 45sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 5sMaven dependency ordering for branch
+1 💚spotless0m 38sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 3sMaven dependency ordering for patch
+1 💚shellcheck0m 1sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚spotless0m 38spatch has no errors when running spotless:check.
_ Other Tests _
+0 🆗asflicense0m 0sASF License check generated no output?
8m 15s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4844
Optional Testsdupname asflicense spotless shellcheck shelldocs
unameLinux b4ef88c46702 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2a3d5b1
Max. process+thread count33 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/2/console
versionsgit=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit 5e251c4 into apache:masterOct 25, 2022
@ndimiduk
ndimiduk deleted the 27442-create-release-versions-set-property branch October 25, 2022 16:18
@ndimiduk

Copy link
Copy Markdown
MemberAuthor

Thanks @Apache9

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@Apache9