Skip to content

HBASE-27474 Evict blocks on split/merge; Avoid caching reference/hlinks if compaction is enabled - #4868

Merged
wchevreuil merged 6 commits into
apache:masterfrom
wchevreuil:HBASE-27474
Dec 16, 2022
Merged

HBASE-27474 Evict blocks on split/merge; Avoid caching reference/hlinks if compaction is enabled#4868
wchevreuil merged 6 commits into
apache:masterfrom
wchevreuil:HBASE-27474

Conversation

@wchevreuil

@wchevreuilwchevreuil commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Wellington Chevreuil
HBASE-27474 Evict blocks on split/merge; Avoid caching reference/hlin…
f24615d
…ks if compaction is enabled
Change-Id: I63296f5f95c9549d75ea7c991d2202c2e550300e
@Apache-HBase

Apache-HBase commented Nov 8, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 44smaster passed
+1 💚compile3m 42smaster passed
+1 💚checkstyle1m 2smaster passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 21smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 34sthe patch passed
+1 💚compile3m 38sthe patch passed
+1 💚cc3m 38sthe patch passed
+1 💚javac3m 38sthe patch passed
-0 ⚠️checkstyle0m 16shbase-client: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)
-0 ⚠️checkstyle0m 36shbase-server: The patch generated 15 new + 28 unchanged - 0 fixed = 43 total (was 28)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck8m 49sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚hbaseprotoc1m 23sthe patch passed
-1 ❌spotless0m 18spatch has 30 errors when running spotless:check, run spotless:apply to fix.
+1 💚spotbugs4m 40sthe patch passed
_ Other Tests _
+1 💚asflicense0m 30sThe patch does not generate ASF License warnings.
42m 57s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4868
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux 6bd7b6919975 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 41c7bd3
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count81 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Wellington Chevreuil added 2 commits November 9, 2022 11:42
Wellington Chevreuil
checkstyles
4ee9264
Change-Id: I7b43530fe2ba44e6b6eb21f6526f7120a8eb235b
Wellington Chevreuil
spotless
525137f
Change-Id: Ia6bcfcb9445e4a448073474d12bda549cf5c6edd
@Apache-HBase

Apache-HBase commented Nov 9, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 20sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 1sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 47smaster passed
+1 💚compile3m 39smaster passed
+1 💚checkstyle1m 1smaster passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 22smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 34sthe patch passed
+1 💚compile3m 38sthe patch passed
+1 💚cc3m 38sthe patch passed
+1 💚javac3m 38sthe patch passed
+1 💚checkstyle0m 59sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck8m 57sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚hbaseprotoc1m 22sthe patch passed
+1 💚spotless0m 40spatch has no errors when running spotless:check.
+1 💚spotbugs4m 42sthe patch passed
_ Other Tests _
+1 💚asflicense0m 30sThe patch does not generate ASF License warnings.
43m 48s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4868
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux e80b49eb17a4 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 41c7bd3
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 reviewed Nov 12, 2022
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/CloseRegionProcedure.java Outdated
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/CloseRegionProcedure.java Outdated
Comment thread...ver/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java Outdated
Comment thread...ver/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java Outdated
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
HRegion region = null;
boolean compactionEnabled =
((HRegionServer) server).getCompactSplitThread().isCompactionsEnabled();
this.server.getConfiguration().setBoolean(HBASE_REGION_SERVER_ENABLE_COMPACTION,

@Apache9Apache9Nov 12, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the global configuration here?

@wchevreuilwchevreuilNov 26, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to prefetch blocks for links/refs only if compaction is disabled, but the prefetch happens in the HFileReader, where we don't access to the CompactSplitThread, so saving the state of compaction switch in the config for HFileReader deciding if prefetch should go ahead.

Comment thread...server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/UnassignRegionHandler.java
@Apache-HBase

Apache-HBase commented Nov 26, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall2m 36smaster passed
+1 💚compile3m 36smaster passed
+1 💚checkstyle0m 59smaster passed
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 20smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 28sthe patch passed
+1 💚compile3m 39sthe patch passed
+1 💚cc3m 39sthe patch passed
+1 💚javac3m 39sthe patch passed
-0 ⚠️checkstyle0m 34shbase-server: The patch generated 2 new + 28 unchanged - 0 fixed = 30 total (was 28)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck8m 50sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚hbaseprotoc1m 22sthe patch passed
-1 ❌spotless0m 35spatch has 65 errors when running spotless:check, run spotless:apply to fix.
+1 💚spotbugs4m 43sthe patch passed
_ Other Tests _
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
43m 10s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4868
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux cbdde032405a 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a5ff289
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count81 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 26, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 31sMaven dependency ordering for branch
+1 💚mvninstall2m 34smaster passed
+1 💚compile1m 27smaster passed
+1 💚shadedjars3m 51sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 42smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 23sthe patch passed
+1 💚compile1m 27sthe patch passed
+1 💚javac1m 27sthe patch passed
+1 💚shadedjars3m 49spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 42sthe patch passed
_ Other Tests _
+1 💚unit0m 30shbase-protocol-shaded in the patch passed.
+1 💚unit1m 17shbase-client in the patch passed.
+1 💚unit191m 5shbase-server in the patch passed.
215m 11s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4868
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b832dab41f5a 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a5ff289
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/testReport/
Max. process+thread count2653 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 26, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall2m 13smaster passed
+1 💚compile1m 29smaster passed
+1 💚shadedjars3m 46sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 49smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 14sthe patch passed
+1 💚compile1m 27sthe patch passed
+1 💚javac1m 27sthe patch passed
+1 💚shadedjars3m 47spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 51sthe patch passed
_ Other Tests _
+1 💚unit0m 31shbase-protocol-shaded in the patch passed.
+1 💚unit1m 1shbase-client in the patch passed.
+1 💚unit215m 31shbase-server in the patch passed.
240m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4868
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e3e12fc4aaee 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a5ff289
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/testReport/
Max. process+thread count2544 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 28, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 31smaster passed
+1 💚compile3m 40smaster passed
+1 💚checkstyle1m 0smaster passed
+1 💚spotless0m 40sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 18smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 34sthe patch passed
+1 💚compile3m 38sthe patch passed
+1 💚cc3m 38sthe patch passed
+1 💚javac3m 38sthe patch passed
+1 💚checkstyle0m 58sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck8m 48sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚hbaseprotoc1m 24sthe patch passed
+1 💚spotless0m 40spatch has no errors when running spotless:check.
+1 💚spotbugs4m 43sthe patch passed
_ Other Tests _
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
42m 51s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4868
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux 4e6c641742b8 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / bb9f43c
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count81 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 28, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 57sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for branch
+1 💚mvninstall2m 41smaster passed
+1 💚compile1m 43smaster passed
+1 💚shadedjars3m 44sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 51smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 33sthe patch passed
+1 💚compile1m 47sthe patch passed
+1 💚javac1m 47sthe patch passed
+1 💚shadedjars3m 47spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 52sthe patch passed
_ Other Tests _
+1 💚unit0m 38shbase-protocol-shaded in the patch passed.
+1 💚unit1m 21shbase-client in the patch passed.
+1 💚unit207m 0shbase-server in the patch passed.
232m 48s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4868
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d480ef7bb2bb 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / bb9f43c
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/testReport/
Max. process+thread count2435 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 28, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 37sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 8sMaven dependency ordering for branch
+1 💚mvninstall2m 44smaster passed
+1 💚compile1m 46smaster passed
+1 💚shadedjars4m 34sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 2smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 58sthe patch passed
+1 💚compile1m 40sthe patch passed
+1 💚javac1m 40sthe patch passed
+1 💚shadedjars4m 20spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 52sthe patch passed
_ Other Tests _
+1 💚unit0m 33shbase-protocol-shaded in the patch passed.
+1 💚unit1m 16shbase-client in the patch passed.
-1 ❌unit259m 46shbase-server in the patch failed.
289m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4868
Optional Testsjavac javadoc unit shadedjars compile
unameLinux dcde3c55039e 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / bb9f43c
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/testReport/
Max. process+thread count2444 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil

wchevreuil commented Dec 1, 2022

Copy link
Copy Markdown
ContributorAuthor

Latest test failure shouldn't be related.

@wchevreuil

wchevreuil commented Dec 1, 2022

Copy link
Copy Markdown
ContributorAuthor

recheck

petersomogyi
petersomogyi approved these changes Dec 9, 2022
View reviewed changes

@petersomogyipetersomogyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine. I had some thoughts on compatibility related to upgrade/rollback but I don't think those could be affected.

@wchevreuil
wchevreuil merged commit 222ec68 into apache:masterDec 16, 2022
wchevreuil added a commit that referenced this pull request Dec 19, 2022
@wchevreuil
HBASE-27474Evict blocks on split/merge; Avoid caching reference/hlin…
012306b
…ks if compaction is enabled (#4868)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit 222ec68)
virajjasani pushed a commit to virajjasani/hbase that referenced this pull request Jan 5, 2023
@wchevreuil@virajjasani
HBASE-27474 Evict blocks on split/merge; Avoid caching reference/hlin…
01d9e80
…ks if compaction is enabled (apache#4868)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@wchevreuil
CDPD-45617: Backport HBASE-27474 Evict blocks on split/merge; Avoid c…
2c1affa
…aching reference/hlinks if compaction is enabled (apache#4868)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit 222ec68)
Change-Id: I0d864cbd2a423e8df27e964834c2bcee21a532f9
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersomogyipetersomogyipetersomogyi approved these changes
@taklwutaklwuAwaiting requested review from taklwu
@ankitsinghalankitsinghalAwaiting requested review from ankitsinghal
@Apache9Apache9Awaiting requested review from Apache9

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wchevreuil@Apache-HBase@petersomogyi@Apache9