HBASE-27479 fix flaky test testClone in TestTaskMonitor by YiweiLi4 · Pull Request #4876 · apache/hbase

YiweiLi4 · 2022-11-11T03:40:47Z

testClone is detected as flaky by NonDex since the origin task monitor and the cloned one are represented as JSON objects, which are in a non-deterministic order. Therefore, I used JSONAssert to check if they are equal instead.

Apache-HBase · 2022-11-11T04:15:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 40s	master passed
+1 💚	compile	2m 20s	master passed
+1 💚	checkstyle	0m 32s	master passed
+1 💚	spotless	0m 38s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 18s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 24s	the patch passed
+1 💚	compile	2m 19s	the patch passed
+1 💚	javac	2m 19s	the patch passed
-0 ⚠️	checkstyle	0m 31s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	8m 49s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌	spotless	0m 32s	patch has 35 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 28s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		30m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4876
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle
uname	Linux 666c54725d18 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `260cd48`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/1/artifact/yetus-general-check/output/whitespace-eol.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-11T07:36:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 38s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	shadedjars	3m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	3m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	210m 18s	hbase-server in the patch passed.
		230m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4876
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fba33fb58267 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `260cd48`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/1/testReport/
Max. process+thread count	2484 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-11T07:41:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 39s	master passed
+1 💚	compile	0m 44s	master passed
+1 💚	shadedjars	3m 55s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	3m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	210m 59s	hbase-server in the patch passed.
		236m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4876
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3c4bc81e4845 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `260cd48`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/1/testReport/
Max. process+thread count	2486 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Thanks for opening this PR and letting us know this great tool for asserting json!

Apache9 · 2022-11-12T13:04:44Z

+ <dependency>
+ <groupId>org.skyscreamer</groupId>
+ <artifactId>jsonassert</artifactId>
+ <version>1.5.1</version>


Better first add this to the parent pom, in the dependencyManagement section, and then reference it here, without specifying the version, as maybe in the future we also need to use this in other mdules, epsecially the hbase-rest module.

Apache9 · 2022-11-12T13:05:44Z

And please run mvn spotless:apply to fix the style issue.

Apache-HBase · 2022-11-16T03:38:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 41s	master passed
+1 💚	compile	1m 50s	master passed
+1 💚	shadedjars	3m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 16s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	0m 5s	root in master failed.
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
-1 ❌	mvninstall	0m 5s	root in the patch failed.
-1 ❌	compile	0m 5s	root in the patch failed.
-0 ⚠️	javac	0m 5s	root in the patch failed.
-1 ❌	shadedjars	0m 3s	patch has 12 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 5s	root in the patch failed.
-0 ⚠️	javadoc	0m 5s	hbase-server in the patch failed.
		_ Other Tests _
-1 ❌	unit	0m 5s	root in the patch failed.
		13m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4876
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 199c1eac3f7a 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5463e8`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/testReport/
Max. process+thread count	147 (vs. ulimit of 30000)
modules	C: . hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-16T03:41:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 10s	master passed
+1 💚	compile	2m 15s	master passed
+1 💚	shadedjars	5m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 28s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	0m 4s	root in master failed.
+0 🆗	mvndep	0m 8s	Maven dependency ordering for patch
-1 ❌	mvninstall	0m 5s	root in the patch failed.
-1 ❌	compile	0m 4s	root in the patch failed.
-0 ⚠️	javac	0m 4s	root in the patch failed.
-1 ❌	shadedjars	0m 2s	patch has 12 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 4s	root in the patch failed.
-0 ⚠️	javadoc	0m 4s	hbase-server in the patch failed.
		_ Other Tests _
-1 ❌	unit	0m 4s	root in the patch failed.
		16m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4876
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8e62db9e8af7 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5463e8`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-root.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/testReport/
Max. process+thread count	126 (vs. ulimit of 30000)
modules	C: . hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-16T03:49:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 59s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 59s	master passed
+1 💚	compile	5m 23s	master passed
+1 💚	checkstyle	1m 16s	master passed
+1 💚	spotless	0m 48s	branch has no errors when running spotless:check.
+1 💚	spotbugs	9m 55s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	0m 5s	root in master failed.
+0 🆗	mvndep	0m 9s	Maven dependency ordering for patch
-1 ❌	mvninstall	0m 5s	root in the patch failed.
-1 ❌	compile	0m 4s	root in the patch failed.
-0 ⚠️	javac	0m 4s	root in the patch failed.
-0 ⚠️	checkstyle	0m 3s	The patch fails to run checkstyle in root
-0 ⚠️	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌	xml	0m 3s	The patch has 1 ill-formed XML file(s).
-1 ❌	hadoopcheck	0m 2s	The patch causes 12 errors with Hadoop v3.2.4.
-1 ❌	hadoopcheck	0m 5s	The patch causes 12 errors with Hadoop v3.3.4.
-1 ❌	spotless	0m 2s	patch has 12 errors when running spotless:check, run spotless:apply to fix.
-1 ❌	spotbugs	0m 4s	root in the patch failed.
-1 ❌	spotbugs	0m 4s	hbase-server in the patch failed.
		_ Other Tests _
+0 🆗	asflicense	0m 9s	ASF License check generated no output?
		23m 48s

Reason	Tests
XML	Parsing Error(s):
	pom.xml

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4876
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle
uname	Linux 2bea9a9d2182 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5463e8`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-general-check/output/branch-mvninstall-root.txt
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-general-check/output/patch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-general-check/output/patch-compile-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-general-check/output/whitespace-eol.txt
xml	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-general-check/output/xml.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-general-check/output/patch-javac-3.3.4.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-general-check/output/patch-spotless.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-general-check/output/patch-spotbugs-root.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
Max. process+thread count	176 (vs. ulimit of 30000)
modules	C: . hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-16T04:44:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 37s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 41s	master passed
+1 💚	compile	4m 29s	master passed
+1 💚	checkstyle	1m 6s	master passed
+1 💚	spotless	0m 37s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 47s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	4m 34s	the patch passed
+1 💚	javac	4m 34s	the patch passed
+1 💚	checkstyle	1m 5s	the patch passed
-0 ⚠️	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	8m 47s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌	spotless	0m 32s	patch has 24 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	8m 8s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		49m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4876
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle
uname	Linux d86d6d171c1d 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5463e8`
Default Java	Eclipse Adoptium-11.0.17+8
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/3/artifact/yetus-general-check/output/whitespace-eol.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/3/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	175 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

YiweiLi4 · 2022-11-16T05:13:26Z

And please run mvn spotless:apply to fix the style issue.

When I ran mvn spotless:check locally, all the checks passed. Do you know why the style issue still exists? Looks like the pom files are not changed after runing mvn spotless:apply, but I am not sure if this is the problem.

Apache9 · 2022-11-16T05:15:49Z

Just try mvn spotless:apply again and commit what is changed. At least there are still lines end with whitespace which is not allowed.

Thanks.

Apache-HBase · 2022-11-16T08:59:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 34s	master passed
+1 💚	compile	1m 48s	master passed
+1 💚	shadedjars	3m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 17s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	1m 49s	the patch passed
+1 💚	javac	1m 49s	the patch passed
+1 💚	shadedjars	3m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	275m 17s	root in the patch passed.
		304m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4876
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0fa65fce951a 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5463e8`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/3/testReport/
Max. process+thread count	4239 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-16T10:10:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 53s	master passed
+1 💚	compile	2m 16s	master passed
+1 💚	shadedjars	5m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 30s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	1m 53s	the patch passed
+1 💚	javac	1m 53s	the patch passed
+1 💚	shadedjars	3m 57s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 47s	the patch passed
		_ Other Tests _
+1 💚	unit	344m 18s	root in the patch passed.
		375m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4876
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9d0f58e7ac35 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5463e8`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/3/testReport/
Max. process+thread count	4083 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-16T11:00:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 34s	master passed
+1 💚	compile	4m 32s	master passed
+1 💚	checkstyle	1m 7s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 43s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 21s	the patch passed
+1 💚	compile	4m 29s	the patch passed
+1 💚	javac	4m 29s	the patch passed
+1 💚	checkstyle	1m 3s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	8m 46s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 36s	patch has no errors when running spotless:check.
+1 💚	spotbugs	8m 1s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		49m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4876
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle
uname	Linux 62652363aa46 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d7c4447`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	177 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-16T15:13:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 9s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 19s	master passed
+1 💚	compile	2m 48s	master passed
+1 💚	shadedjars	4m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 59s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 15s	the patch passed
+1 💚	compile	2m 44s	the patch passed
+1 💚	javac	2m 44s	the patch passed
+1 💚	shadedjars	4m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 48s	the patch passed
		_ Other Tests _
-1 ❌	unit	266m 28s	root in the patch failed.
		301m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4876
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 57dd8a94f8f2 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d7c4447`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/4/testReport/
Max. process+thread count	2300 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-16T16:22:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 17s	Docker mode activated.
-0 ⚠️	yetus	0m 9s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 19s	master passed
+1 💚	compile	1m 35s	master passed
+1 💚	shadedjars	3m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 46s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 9s	the patch passed
+1 💚	compile	1m 36s	the patch passed
+1 💚	javac	1m 36s	the patch passed
+1 💚	shadedjars	3m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 46s	the patch passed
		_ Other Tests _
+1 💚	unit	343m 41s	root in the patch passed.
		370m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4876
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 163e7f71c105 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d7c4447`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/4/testReport/
Max. process+thread count	4092 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4876/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

YiweiLi4 · 2022-11-17T00:16:12Z

Just try mvn spotless:apply again and commit what is changed. At least there are still lines end with whitespace which is not allowed.
Thanks.

Hi I tried mvn spotless:apply several times but it doesn't change any of the pom files. I tried both cd to path \hbase and mvn spotless:apply, and using specified destination mvn spotless:apply -DspotlessFiles=pom.xml,hbase-server/pom.xml, but none of them worked. You mentioned there are lines end with whitespace, could you specify which lines?

Apache9 · 2022-11-17T06:38:39Z

Seems the latest PR is fine. There are test failure s but should not be related, just some flaky tests.

Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a2075f5)

Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a2075f5) (cherry picked from commit fd92057) Change-Id: Ibe6a619e7f9b70b97917e0aa464f139fa0e39ac3

HBASE-27479 fix flaky test testClone in TestTaskMonitor
1f1ccb3

Apache9 reviewed Nov 12, 2022
View reviewed changes

HBASE-27479 add dependency to parent pom and fix style issue
55b3225

HBASE-27479 fix issue
91cfd47

HBASE-27479 fix issue
d355e4c

Apache9 approved these changes Nov 17, 2022
View reviewed changes

Apache9 merged commit a2075f5 into apache:masterNov 17, 2022

Apache9 pushed a commit that referenced this pull request Nov 17, 2022
HBASE-27479fix flaky test testClone in TestTaskMonitor (#4876)
fd92057
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a2075f5)

Apache9 pushed a commit that referenced this pull request Nov 17, 2022
HBASE-27479fix flaky test testClone in TestTaskMonitor (#4876)
61b74d8
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a2075f5)

Apache9 pushed a commit that referenced this pull request Nov 17, 2022
HBASE-27479fix flaky test testClone in TestTaskMonitor (#4876)
309ed58
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a2075f5)

Uh oh!

Conversation

YiweiLi4 commented Nov 11, 2022

Uh oh!

Apache-HBase commented Nov 11, 2022

Uh oh!

Apache-HBase commented Nov 11, 2022

Uh oh!

Apache-HBase commented Nov 11, 2022

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Apache9Nov 12, 2022

Choose a reason for hiding this comment

Uh oh!

Apache9 commented Nov 12, 2022

Uh oh!

Apache-HBase commented Nov 16, 2022

Uh oh!

Apache-HBase commented Nov 16, 2022

Uh oh!

Apache-HBase commented Nov 16, 2022

Uh oh!

Apache-HBase commented Nov 16, 2022

Uh oh!

YiweiLi4 commented Nov 16, 2022

Uh oh!

Apache9 commented Nov 16, 2022

Uh oh!

Apache-HBase commented Nov 16, 2022

Uh oh!

Apache-HBase commented Nov 16, 2022

Uh oh!

Apache-HBase commented Nov 16, 2022

Uh oh!

Apache-HBase commented Nov 16, 2022

Uh oh!

Apache-HBase commented Nov 16, 2022

Uh oh!

YiweiLi4 commented Nov 17, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache9 commented Nov 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YiweiLi4 commented Nov 17, 2022•
edited
Loading