HBASE-27484 FNFE on StoreFileScanner after a flush followed by a compaction by wchevreuil · Pull Request #4882 · apache/hbase

wchevreuil · 2022-11-15T02:28:07Z

No description provided.

…action Change-Id: I6d31a361f0198d0527d2a41309fc90950cf0cd76

Apache-HBase · 2022-11-15T03:25:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 50s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 57s	master passed
+1 💚	compile	2m 54s	master passed
+1 💚	checkstyle	0m 42s	master passed
+1 💚	spotless	0m 48s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 56s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	2m 47s	the patch passed
-0 ⚠️	javac	2m 47s	hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
-0 ⚠️	checkstyle	0m 37s	hbase-server: The patch generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	14m 38s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌	spotless	0m 55s	patch has 63 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	2m 29s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		45m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4882
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux c0e9ef007fa0 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `047f4e2`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-11-15T05:16:36Z

 storeFilesToScan = this.storeEngine.getStoreFileManager().getFilesForScan(startRow,
 includeStartRow, stopRow, includeStopRow);
 memStoreScanners = this.memstore.getScanners(readPt);
+ storeFilesToScan.stream().forEach(f->f.getReader().incrementRefCount());


Is it possible that the storefiles are deleted before we increment ref count here?

We are inside a storeEngine.readLock here. The delete code also is under the same lock, so if we reach this point, we are sure the files were not deleted yet.

Then there is no problem for the old code either? Since we are under the lock? I do not fully get the point why here we could fix the problem? Mind adding more comment in the code? Thanks.

OK, we will release the lock immediately after getting the file list, so when we actually get the store file scanner, the file may have already been archived.
I think a simple fix is to just move the getting scanner code into the read lock section? As here you only increase the lock if the reader is not null, it is still possible that some files are archived later?

I think one problem of moving the getting scanner code into the read lock section is that in StoreFileScanner.getScannersForStoreFiles method , it would call HStoreFile.initReader , which would make the storeEngine.readLock locked somewhat long time? Another option is that since StoreFileReader.refCount comes from StoreFileInfo.refCount, we can increase the StoreFileInfo.refCount by HStoreFile.fileInfo?

it would call HStoreFile.initReader , which would make the storeEngine.readLock locked somewhat long time? Another option is that since StoreFileReader.refCount comes from StoreFileInfo.refCount, we can increase the StoreFileInfo.refCount by HStoreFile.fileInfo?
Yeah, didn't want to move the SFR/SFS initialisation inside this read lock. I had updated the code to inc refCount via StoreFileInfo, as @comnetwork suggested.

Apache-HBase · 2022-11-15T06:34:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 55s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	shadedjars	4m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	0m 44s	the patch passed
+1 💚	javac	0m 44s	the patch passed
+1 💚	shadedjars	4m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
-1 ❌	unit	212m 51s	hbase-server in the patch failed.
		233m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4882
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 49da371412ae 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `047f4e2`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/1/testReport/
Max. process+thread count	2473 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-15T07:01:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 48s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 34s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	shadedjars	4m 33s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 3s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	shadedjars	4m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	the patch passed
		_ Other Tests _
-1 ❌	unit	236m 36s	hbase-server in the patch failed.
		261m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4882
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1b9fb3a7b5b6 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `047f4e2`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/1/testReport/
Max. process+thread count	2497 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Change-Id: I7da97865ba0fc51015db7bbdf92286c643c387c9

petersomogyi

lgtm.
Please take a look at the reported checkstyle/spotbugs/javac warnings.

Change-Id: Ib8d0df078cbb4daca8240792c2cbbfd7dae183bd

Apache-HBase · 2022-11-15T12:28:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 53s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 38s	master passed
+1 💚	compile	2m 21s	master passed
+1 💚	checkstyle	0m 32s	master passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 24s	the patch passed
+1 💚	compile	2m 25s	the patch passed
-0 ⚠️	javac	2m 25s	hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚	checkstyle	0m 32s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 57s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌	spotless	0m 31s	patch has 31 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 28s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		33m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4882
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux c9cb3ca0efe2 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5463e8`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Change-Id: I901929fb917868817de67054ed035fa9e564845e

Apache-HBase · 2022-11-15T15:46:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 45s	master passed
+1 💚	compile	0m 49s	master passed
+1 💚	shadedjars	3m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	3m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	210m 9s	hbase-server in the patch passed.
		230m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4882
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b86669cdc1cb 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5463e8`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/2/testReport/
Max. process+thread count	2518 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-15T15:51:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 27s	master passed
+1 💚	compile	0m 41s	master passed
+1 💚	shadedjars	3m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 16s	the patch passed
+1 💚	compile	0m 40s	the patch passed
+1 💚	javac	0m 40s	the patch passed
+1 💚	shadedjars	3m 48s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	216m 30s	hbase-server in the patch passed.
		236m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4882
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 380d9ebb18f7 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5463e8`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/2/testReport/
Max. process+thread count	2279 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-15T16:40:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 21s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 50s	master passed
+1 💚	compile	3m 4s	master passed
+1 💚	checkstyle	0m 38s	master passed
+1 💚	spotless	0m 53s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 46s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 13s	the patch passed
+1 💚	compile	4m 10s	the patch passed
-0 ⚠️	javac	4m 10s	hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚	checkstyle	1m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 45s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	1m 14s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 53s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		45m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4882
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux d670be5f91c6 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5463e8`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-15T19:44:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 28s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	shadedjars	3m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	3m 48s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	209m 20s	hbase-server in the patch passed.
		229m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4882
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2647957facd0 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5463e8`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/3/testReport/
Max. process+thread count	2522 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-15T19:50:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 14s	master passed
+1 💚	compile	0m 38s	master passed
+1 💚	shadedjars	3m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 12s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	3m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	216m 7s	hbase-server in the patch passed.
		235m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4882
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c273c8cf33b2 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5463e8`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/3/testReport/
Max. process+thread count	2277 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…Reader Change-Id: Icca80de53a2021fd5d169cf03525fb6f59a8f874

Apache-HBase · 2022-11-16T13:45:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 51s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 1s	master passed
+1 💚	compile	2m 52s	master passed
+1 💚	checkstyle	0m 39s	master passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 58s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 30s	the patch passed
+1 💚	compile	2m 46s	the patch passed
-0 ⚠️	javac	2m 46s	hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚	checkstyle	0m 38s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	14m 25s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	1m 4s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 21s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		45m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4882
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 4d664fc95411 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d7c4447`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-16T16:49:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 52s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	shadedjars	3m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 30s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	3m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	208m 8s	hbase-server in the patch passed.
		229m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4882
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8e3a715c5aa3 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d7c4447`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/4/testReport/
Max. process+thread count	2579 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-16T17:13:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 53s	Docker mode activated.
-0 ⚠️	yetus	0m 17s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 24s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	shadedjars	4m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 2s	the patch passed
+1 💚	compile	0m 57s	the patch passed
+1 💚	javac	0m 57s	the patch passed
+1 💚	shadedjars	4m 26s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	the patch passed
		_ Other Tests _
+1 💚	unit	228m 32s	hbase-server in the patch passed.
		253m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4882
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux aefb7cb79cf6 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d7c4447`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/4/testReport/
Max. process+thread count	2318 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4882/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…action (#4882) Signed-off-by: Peter Somogyi <psomogyi@apache.org>

Apache9 · 2022-11-26T13:16:59Z

Sorry a bit late, but at least let's add more comments in code?

…action (#4882) Signed-off-by: Peter Somogyi <psomogyi@apache.org>

…action (apache#4882) Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit 6e562bb) Change-Id: I49a5514b3183017eb245e879fd1d6cc1885f88b6

HBASE-27484 FNFE on StoreFileScanner after a flush followed by a comp…
bc30b33
…action Change-Id: I6d31a361f0198d0527d2a41309fc90950cf0cd76

wchevreuil requested review from ankitsinghal, binlijin and petersomogyi November 15, 2022 02:28

Apache9 reviewed Nov 15, 2022
View reviewed changes

fix spotless and UT
498bfdb
Change-Id: I7da97865ba0fc51015db7bbdf92286c643c387c9

petersomogyi reviewed Nov 15, 2022
View reviewed changes

Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java

fixing possible NPEs on when inc ref counts on readers
50cda47
Change-Id: Ib8d0df078cbb4daca8240792c2cbbfd7dae183bd

petersomogyi approved these changes Nov 15, 2022
View reviewed changes

Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java

spotless
bcd58f3
Change-Id: I901929fb917868817de67054ed035fa9e564845e

Switching to update refCounts on StoreFileInfo, rather than StoreFile…
9a7a338
…Reader Change-Id: Icca80de53a2021fd5d169cf03525fb6f59a8f874

ankitsinghal requested review from anoopsjohn and ramkrish86 November 16, 2022 23:00

wchevreuil merged commit a5ff289 into apache:masterNov 25, 2022

wchevreuil added a commit that referenced this pull request Nov 26, 2022
HBASE-27484FNFE on StoreFileScanner after a flush followed by a comp…
8a76451
…action (#4882) Signed-off-by: Peter Somogyi <psomogyi@apache.org>

wchevreuil added a commit that referenced this pull request Nov 29, 2022
HBASE-27484FNFE on StoreFileScanner after a flush followed by a comp…
b01fad9
…action (#4882) Signed-off-by: Peter Somogyi <psomogyi@apache.org>

wchevreuil added a commit that referenced this pull request Nov 29, 2022
HBASE-27484FNFE on StoreFileScanner after a flush followed by a comp…
6e562bb
…action (#4882) Signed-off-by: Peter Somogyi <psomogyi@apache.org>

Uh oh!

Conversation

wchevreuil commented Nov 15, 2022

Uh oh!

Apache-HBase commented Nov 15, 2022

Uh oh!

Apache9Nov 15, 2022

Choose a reason for hiding this comment

Uh oh!

wchevreuilNov 15, 2022

Choose a reason for hiding this comment

Uh oh!

Apache9Nov 15, 2022

Choose a reason for hiding this comment

Uh oh!

Apache9Nov 16, 2022

Choose a reason for hiding this comment

Uh oh!

comnetworkNov 16, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wchevreuilNov 16, 2022

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Nov 15, 2022

Uh oh!

Apache-HBase commented Nov 15, 2022

Uh oh!

petersomogyi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Nov 15, 2022

Uh oh!

Apache-HBase commented Nov 15, 2022

Uh oh!

Apache-HBase commented Nov 15, 2022

Uh oh!

Apache-HBase commented Nov 15, 2022

Uh oh!

Apache-HBase commented Nov 15, 2022

Uh oh!

Apache-HBase commented Nov 15, 2022

Uh oh!

Apache-HBase commented Nov 16, 2022

Uh oh!

Apache-HBase commented Nov 16, 2022

Uh oh!

Apache-HBase commented Nov 16, 2022

Uh oh!

Apache9 commented Nov 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

comnetworkNov 16, 2022•
edited
Loading