Uh oh!
There was an error while loading. Please reload this page.
HBASE-27567 Introduce ChaosMonkey Action to print HDFS Cluster status - #4959
Merged
ndimiduk merged 3 commits intoJan 16, 2023
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Reidddddd
approved these changes
Jan 13, 2023
Apache9
reviewed
Jan 13, 2023
| if (activeNamenode == null) { | ||
| throw new Exception("No active Name node found in zookeeper under " + hadoopHAZkNode); | ||
| } else { |
Contributor
There was a problem hiding this comment.
Why an else here? Seems not necessary,,,
| } | ||
| // TODO: add more on NN, JNs, and ZK. | ||
| // TODO: Print how long process has been up. | ||
| LOG.info(sb.toString()); |
ndimiduk
commented
Jan 13, 2023
| } | ||
| if (activeNamenode == null) { | ||
| throw new Exception("No active Name node found in zookeeper under " + hadoopHAZkNode); |
MemberAuthor
There was a problem hiding this comment.
this could just return instead of throwing.
ndimidukforce-pushed
the
27567-cm-action-dump-hdfs-status
branch
from
January 13, 2023 14:30
8452ef8 to
f8bbc92CompareApache-HBase
commented
Jan 13, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 13, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 13, 2023
🎊 +1 overall
This message was automatically generated. |
ndimiduk
commented
Jan 16, 2023
MemberAuthor
Do you have any further concerns @Apache9 ? |
Apache9
approved these changes
Jan 16, 2023
Apache9
left a comment
Contributor
There was a problem hiding this comment.
I was wondering what if we run ITs against S3AFileSystem, but since in ServerAndDependenciesKillingMonkeyFactory, we have already add RestartRandomDataNodeAction which is also HDFS specific, the PR here does not introduce new problems.
ndimiduk
commented
Jan 16, 2023
MemberAuthor
We could run Chaos tests against a cluster configured with S3A storage, but in that case we would not run the HDFS chaos components. I'd like to have a declarative configuration-driven chaos definition, instead of using these hard-coded factories, but I don't think that's been implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.