HBASE-27568 ChaosMonkey add support for JournalNodes by ndimiduk · Pull Request #4963 · apache/hbase

ndimiduk · 2023-01-12T16:23:18Z

Depends on #4959

Reidddddd · 2023-01-13T08:22:27Z

+ }
+
+ protected void startJournalNode(ServerName server) throws IOException {
+ getLogger().info("Starting journalnode :-{}", server.getHostname());


But :- is removed above. I feel it is a copy-paste nit

Reidddddd · 2023-01-13T08:22:52Z

+ getLogger().info("Starting journalnode :-{}", server.getHostname());
+ cluster.startJournalNode(server);
+ cluster.waitForJournalNodeToStart(server, startNameNodeTimeout);
+ getLogger().info("Started journalnode: {}", server);


Ditto for the :

Reidddddd · 2023-01-16T02:04:47Z

Shall we wait for the #4959, seems there are some code overlaps, and Duo is reviewing there

ndimiduk · 2023-01-16T14:01:05Z

@Reidddddd indeed. #4959 is merged ; I've rebased this onto latest master.

Apache-HBase · 2023-01-16T14:38:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 22s	master passed
+1 💚	compile	2m 45s	master passed
+1 💚	checkstyle	0m 40s	master passed
+1 💚	spotless	0m 38s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 42s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	2m 44s	the patch passed
+1 💚	javac	2m 44s	the patch passed
+1 💚	checkstyle	0m 40s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 57s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 55s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		32m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4963/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4963
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 0e1d61e2fff6 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7ed2cb9`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-server hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4963/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-01-16T18:00:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 40s	master passed
+1 💚	compile	1m 9s	master passed
+1 💚	shadedjars	3m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	compile	1m 9s	the patch passed
+1 💚	javac	1m 9s	the patch passed
+1 💚	shadedjars	3m 48s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	212m 14s	hbase-server in the patch passed.
+1 💚	unit	0m 52s	hbase-it in the patch passed.
		235m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4963/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4963
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 37589353d91b 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7ed2cb9`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4963/4/testReport/
Max. process+thread count	2659 (vs. ulimit of 30000)
modules	C: hbase-server hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4963/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-01-16T18:10:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 40s	master passed
+1 💚	compile	1m 14s	master passed
+1 💚	shadedjars	4m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	shadedjars	3m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	221m 11s	hbase-server in the patch passed.
+1 💚	unit	0m 56s	hbase-it in the patch passed.
		244m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4963/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4963
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6c2f66112769 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7ed2cb9`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4963/4/testReport/
Max. process+thread count	2406 (vs. ulimit of 30000)
modules	C: hbase-server hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4963/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2023-01-17T12:22:09Z

Thanks @Reidddddd

Signed-off-by: Reid Chan <reidchan@apache.org>

Signed-off-by: Reid Chan <reidchan@apache.org> (cherry picked from commit 181ffe7) Change-Id: I40645dac43fc1b0288b71072d7834b9ee4c5f9d9

ndimiduk force-pushed the 27568-cm-journalnode branch 3 times, most recently from 44c5aa8 to 41e7750Compare January 12, 2023 16:44

This comment was marked as outdated.
Sign in to view

Reidddddd reviewed Jan 13, 2023
View reviewed changes

ndimiduk force-pushed the 27568-cm-journalnode branch 2 times, most recently from da42f64 to 0bf3356Compare January 13, 2023 14:36

This comment was marked as outdated.
Sign in to view

ndimiduk added 2 commits January 16, 2023 14:59

HBASE-27568 ChaosMonkey add support for JournalNodes
255cbfa

PR feedback
ffe6f9d

ndimiduk force-pushed the 27568-cm-journalnode branch from 0bf3356 to ffe6f9dCompare January 16, 2023 14:00

Reidddddd merged commit da26134 into apache:masterJan 17, 2023

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jan 17, 2023
HBASE-27568 ChaosMonkey add support for JournalNodes (apache#4963)
a80e62f
Signed-off-by: Reid Chan <reidchan@apache.org>

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jan 17, 2023
HBASE-27568 ChaosMonkey add support for JournalNodes (apache#4963)
9dc0a0f
Signed-off-by: Reid Chan <reidchan@apache.org>

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jan 17, 2023
HBASE-27568 ChaosMonkey add support for JournalNodes (apache#4963)
dd5912a
Signed-off-by: Reid Chan <reidchan@apache.org>

ndimiduk deleted the 27568-cm-journalnode branch January 17, 2023 12:48

ndimiduk added a commit that referenced this pull request Jan 17, 2023
HBASE-27568ChaosMonkey add support for JournalNodes (#4963)
4f8e34f
Signed-off-by: Reid Chan <reidchan@apache.org>

ndimiduk added a commit that referenced this pull request Jan 17, 2023
HBASE-27568ChaosMonkey add support for JournalNodes (#4963)
9f81c78
Signed-off-by: Reid Chan <reidchan@apache.org>

ndimiduk added a commit that referenced this pull request Jan 17, 2023
HBASE-27568ChaosMonkey add support for JournalNodes (#4963)
181ffe7
Signed-off-by: Reid Chan <reidchan@apache.org>

Navigation Menu

Uh oh!

HBASE-27568 ChaosMonkey add support for JournalNodes - #4963

HBASE-27568 ChaosMonkey add support for JournalNodes#4963
Reidddddd merged 2 commits into
apache:masterfrom
ndimiduk:27568-cm-journalnode

ndimiduk commented Jan 12, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

ReiddddddJan 13, 2023

Uh oh!

ReiddddddJan 13, 2023

Uh oh!

ndimidukJan 13, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Reidddddd commented Jan 16, 2023•
edited
Loading

Uh oh!

ndimiduk commented Jan 16, 2023

Uh oh!

Apache-HBase commented Jan 16, 2023

Uh oh!

Apache-HBase commented Jan 16, 2023

Uh oh!

Apache-HBase commented Jan 16, 2023

Uh oh!

ndimiduk commented Jan 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ndimiduk commented Jan 12, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

ReiddddddJan 13, 2023

Choose a reason for hiding this comment

Uh oh!

ReiddddddJan 13, 2023

Choose a reason for hiding this comment

Uh oh!

ndimidukJan 13, 2023

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Reidddddd commented Jan 16, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ndimiduk commented Jan 16, 2023

Uh oh!

Apache-HBase commented Jan 16, 2023

Uh oh!

Apache-HBase commented Jan 16, 2023

Uh oh!

Apache-HBase commented Jan 16, 2023

Uh oh!

ndimiduk commented Jan 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Reidddddd commented Jan 16, 2023•
edited
Loading