Uh oh!
There was an error while loading. Please reload this page.
HBASE-27905 Directly schedule procedures that do not need to acquire … - #5267
Open
frostruan wants to merge 3 commits into
Open
HBASE-27905 Directly schedule procedures that do not need to acquire …#5267frostruan wants to merge 3 commits into
frostruan wants to merge 3 commits into
Conversation
Apache-HBase
commented
Jun 4, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 4, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 4, 2023
💔 -1 overall
This message was automatically generated. |
wchevreuil
left a comment
Contributor
There was a problem hiding this comment.
Which are the current procedures that don't need any lock? Can we add the override for needLock on those procedures here?
Does this change add the risk of procedures that don't need lock to starve those that need locks? I'm not sure this is indeed an issue, just wonder if that was already considered here.
| return false; | ||
| } | ||
| public boolean needLock() { |
Comment on lines
+377
to
+383
| if (hasNoLockNeededProcedure(queue)) { | ||
| if (LOG.isTraceEnabled()) { | ||
| LOG.trace("DO NOT remove {} from run queue because There are still procedures in the " | ||
| + "queue that do not need to acquire locks", queue); | ||
| } | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
Mind explain why we do this here? I see removeFromRunQueue is called from several places, some apparently expecting the call to effectively remove the queue.
frostruan
commented
Jun 8, 2023
ContributorAuthor
Thank you for your attention. @wchevreuil The background of the matter is this, I try to introduce a new Procedure in HBASE-26768 —— |
Apache9
commented
Jun 30, 2023
Contributor
I've commented on the design doc. PTAL. I think first we need to polish the design, before actually writing the code. And this is a sueful feature, better also start a discussion thread in the mailing list and also post the design there. Thanks. |
Apache9
reviewed
Jul 3, 2023
| // procedures, then we give up and remove the queue from run queue. | ||
| for (int i = 0, n = rq.size(); i < n; i++) { | ||
| Procedure<?> proc = rq.poll(); | ||
| if (!proc.needLock()) { |
Contributor
There was a problem hiding this comment.
Why not add this logic in the below isLockReady method?
| private static <T extends Comparable<T>> void removeFromRunQueue(FairQueue<T> fairq, | ||
| Queue<T> queue, Supplier<String> reason) { | ||
| if (hasNoLockNeededProcedure(queue)) { |
Contributor
There was a problem hiding this comment.
Ideally, if there are still no lock procedure in the queue, we should not arrive here?
frostruan
commented
Jul 3, 2023
ContributorAuthor
Thanks Duo. After I implement the optimization items you proposed, I will send an email to the community to discuss it. |
Apache-HBase
commented
Aug 5, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 7, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 7, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 7, 2023
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…locks