Skip to content

HBASE-28483 backup merge fails on bulkloaded hfiles - #5795

Merged
bbeaudreault merged 1 commit into
apache:masterfrom
thomassngdata:HBASE-28483_backup_merge_fails_bulkloaded_hfiles
Apr 6, 2024
Merged

HBASE-28483 backup merge fails on bulkloaded hfiles#5795
bbeaudreault merged 1 commit into
apache:masterfrom
thomassngdata:HBASE-28483_backup_merge_fails_bulkloaded_hfiles

Conversation

@thomassngdata

@thomassngdatathomassngdata commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Apache-HBase commented Apr 5, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 11smaster passed
+1 💚compile0m 52smaster passed
+1 💚checkstyle0m 18smaster passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
+1 💚spotbugs0m 58smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 53sthe patch passed
+1 💚compile0m 51sthe patch passed
+1 💚javac0m 51sthe patch passed
-0 ⚠️checkstyle0m 10shbase-mapreduce: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck5m 31sPatch does not cause any errors with Hadoop 3.3.6.
-1 ❌spotless0m 37spatch has 24 errors when running spotless:check, run spotless:apply to fix.
+1 💚spotbugs1m 12sthe patch passed
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
25m 39s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5795
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 3948ebceee70 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 6101bad
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count81 (vs. ulimit of 30000)
modulesC: hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 5, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 15smaster passed
+1 💚compile0m 36smaster passed
+1 💚shadedjars5m 42sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 26smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 5sthe patch passed
+1 💚compile0m 35sthe patch passed
+1 💚javac0m 35sthe patch passed
+1 💚shadedjars5m 38spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25sthe patch passed
_ Other Tests _
+1 💚unit13m 5shbase-mapreduce in the patch passed.
+1 💚unit10m 5shbase-backup in the patch passed.
45m 17s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5795
Optional Testsjavac javadoc unit shadedjars compile
unameLinux de7f3f51c592 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 6101bad
Default JavaEclipse Adoptium-17.0.10+7
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/testReport/
Max. process+thread count3775 (vs. ulimit of 30000)
modulesC: hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 5, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 58smaster passed
+1 💚compile0m 34smaster passed
+1 💚shadedjars5m 38sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 27smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 53sthe patch passed
+1 💚compile0m 35sthe patch passed
+1 💚javac0m 35sthe patch passed
+1 💚shadedjars5m 39spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25sthe patch passed
_ Other Tests _
+1 💚unit14m 21shbase-mapreduce in the patch passed.
+1 💚unit10m 38shbase-backup in the patch passed.
46m 26s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5795
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a4536b1f2506 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 6101bad
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/testReport/
Max. process+thread count3583 (vs. ulimit of 30000)
modulesC: hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 5, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 30smaster passed
+1 💚compile0m 40smaster passed
+1 💚shadedjars5m 20sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 28smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 59sthe patch passed
+1 💚compile0m 40sthe patch passed
+1 💚javac0m 40sthe patch passed
+1 💚shadedjars5m 58spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 27sthe patch passed
_ Other Tests _
+1 💚unit15m 6shbase-mapreduce in the patch passed.
+1 💚unit11m 28shbase-backup in the patch passed.
49m 11s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5795
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 42dee04f1f59 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 6101bad
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/testReport/
Max. process+thread count3340 (vs. ulimit of 30000)
modulesC: hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault
bbeaudreault reviewed Apr 5, 2024
View reviewed changes

@bbeaudreaultbbeaudreault left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so the problem here is that the Merge job sets the input dirs to table dirs:

backupIT/backup_1712319710829/default/table-false
backupIT/backup_1712319719106/default/table-false

Typically HFileInputFormat expects the input dirs to be region dirs like:

backupIT/backup_1712319710829/default/table-false/<regionname>
backupIT/backup_1712319719106/default/table-false/<regionname>
... etc, for each region in each table

In which case a region dir contains a column dir, and so it needed to handle that and does 1 level of "recursion".

But in the case of merge, the input dir is the table dir and it needs to do 2 levels of recursion.

I'm a little on the fence about whether this fix should be in HFileInputFormat or actually in MapReduceHFileSplitterJob. In the latter case we could list the backup dirs and add the regions within to the inputs, so that we honor the existing contract of HFileInputFormat.

That said I think for now I'm leaning towards this being the ok path, so we can leave it. There might be other benefits as well.

Comment threadhbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileInputFormat.java Outdated
@@ -155,16 +154,23 @@ protected List<FileStatus> listStatus(JobContext job) throws IOException {
// since HFiles are written to directories where the
// directory name is the column name

@bbeaudreaultbbeaudreaultApr 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment here is out of date relative to the implementation now. It would be good to update it about the case where sometimes it might need to recurse further, such as when pointed at a table dir.

@thomassngdatathomassngdataApr 6, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I updated the comment to hint at both current cases for the input dirs: and (but without specifically mentioning MapReduceBackupMergeJob)

@bbeaudreault

bbeaudreault commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

Also please run mvn spotless:apply -pl hbase-backups

@thomassngdata
thomassngdataforce-pushed the HBASE-28483_backup_merge_fails_bulkloaded_hfiles branch from a828ccf to 9714577CompareApril 6, 2024 09:43
@thomassngdata

thomassngdata commented Apr 6, 2024

Copy link
Copy Markdown
ContributorAuthor

Issue with mvn spotless:apply -pl hbase-backup was a duplicate hamcrest-library dependency in hbase-replication/pom.xml, nothing to do with my PR but fixed it.

@Apache-HBase

Apache-HBase commented Apr 6, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 11smaster passed
+1 💚compile1m 7smaster passed
+1 💚checkstyle0m 24smaster passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 14smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 58sthe patch passed
+1 💚compile1m 5sthe patch passed
+1 💚javac1m 5sthe patch passed
+1 💚checkstyle0m 23sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck5m 33sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
+1 💚spotbugs1m 37sthe patch passed
_ Other Tests _
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
27m 21s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5795
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml
unameLinux 02d087f44ccc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / aea7e7c
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count81 (vs. ulimit of 30000)
modulesC: hbase-replication hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 6, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall3m 16smaster passed
+1 💚compile0m 48smaster passed
+1 💚shadedjars5m 42sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 58sthe patch passed
+1 💚compile0m 47sthe patch passed
+1 💚javac0m 47sthe patch passed
+1 💚shadedjars5m 39spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35sthe patch passed
_ Other Tests _
+1 💚unit0m 30shbase-replication in the patch passed.
+1 💚unit13m 12shbase-mapreduce in the patch passed.
+1 💚unit9m 55shbase-backup in the patch passed.
46m 19s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5795
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2c9ac48f55e8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / aea7e7c
Default JavaEclipse Adoptium-17.0.10+7
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/2/testReport/
Max. process+thread count3609 (vs. ulimit of 30000)
modulesC: hbase-replication hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 6, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 6smaster passed
+1 💚compile0m 53smaster passed
+1 💚shadedjars5m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 45smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 52sthe patch passed
+1 💚compile0m 53sthe patch passed
+1 💚javac0m 53sthe patch passed
+1 💚shadedjars5m 14spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 43sthe patch passed
_ Other Tests _
+1 💚unit0m 36shbase-replication in the patch passed.
+1 💚unit15m 42shbase-mapreduce in the patch passed.
+1 💚unit11m 0shbase-backup in the patch passed.
49m 34s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5795
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 60169d09119f 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / aea7e7c
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/2/testReport/
Max. process+thread count3370 (vs. ulimit of 30000)
modulesC: hbase-replication hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 6, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 36smaster passed
+1 💚compile0m 49smaster passed
+1 💚shadedjars5m 8sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 28sthe patch passed
+1 💚compile0m 48sthe patch passed
+1 💚javac0m 48sthe patch passed
+1 💚shadedjars6m 14spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39sthe patch passed
_ Other Tests _
+1 💚unit0m 34shbase-replication in the patch passed.
+1 💚unit16m 12shbase-mapreduce in the patch passed.
+1 💚unit11m 29shbase-backup in the patch passed.
49m 57s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5795
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 47831bcf74d1 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / aea7e7c
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/2/testReport/
Max. process+thread count3278 (vs. ulimit of 30000)
modulesC: hbase-replication hbase-mapreduce hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault

bbeaudreault commented Apr 6, 2024

Copy link
Copy Markdown
Contributor

What I was referring to about spotless was this error in the first build: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/artifact/yetus-general-check/output/patch-spotless.txt

Spotless helps maintain our formatting guidelines. Where did you see it complaining about the hamcrest dependency?

I see the formatting issues have been fixed, but I'm not sure we should change the pom.xml unless there was a reason

@bbeaudreault

bbeaudreault commented Apr 6, 2024

Copy link
Copy Markdown
Contributor

I investigated and it does seem like a true duplicate. I don't think this was related, but it's ok. More importantly, the spotless formatting issues have been fixed. Going to merge this

@bbeaudreault
bbeaudreault merged commit 558b151 into apache:masterApr 6, 2024
bbeaudreault pushed a commit that referenced this pull request Apr 6, 2024
@thomassngdata@bbeaudreault
HBASE-28483backup merge fails on bulkloaded hfiles (#5795)
6510fac
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
bbeaudreault pushed a commit that referenced this pull request Apr 6, 2024
@thomassngdata@bbeaudreault
HBASE-28483backup merge fails on bulkloaded hfiles (#5795)
6a5f9ca
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
bbeaudreault pushed a commit that referenced this pull request Apr 6, 2024
@thomassngdata@bbeaudreault
HBASE-28483backup merge fails on bulkloaded hfiles (#5795)
5a92541
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Apr 6, 2024
@thomassngdata@bbeaudreault
HubSpot Backport: HBASE-28483 backup merge fails on bulkloaded hfiles (…
c7df430
…apache#5795)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbeaudreaultbbeaudreaultbbeaudreault left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomassngdata@Apache-HBase@bbeaudreault