Skip to content

Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-3 - #5803

Merged
ndimiduk merged 1 commit into
apache:branch-3from
ndimiduk:28485-zsdt-reuse-ctx-perf-branch-3
Apr 9, 2024
Merged

Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-3#5803
ndimiduk merged 1 commit into
apache:branch-3from
ndimiduk:28485-zsdt-reuse-ctx-perf-branch-3

Conversation

@ndimiduk

@ndimidukndimiduk commented Apr 9, 2024

Copy link
Copy Markdown
Member

No description provided.

@charlesconnell@ndimiduk
HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (a…
f6e8db8
…pache#5797)
Co-authored-by: Charles Connell <cconnell@hubspot.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Apr 9, 2024
@Apache-HBase

Apache-HBase commented Apr 9, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+1 💚mvninstall3m 4sbranch-3 passed
+1 💚compile0m 15sbranch-3 passed
+1 💚shadedjars5m 14sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 15sbranch-3 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 49sthe patch passed
+1 💚compile0m 15sthe patch passed
+1 💚javac0m 15sthe patch passed
+1 💚shadedjars5m 17spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 12sthe patch passed
_ Other Tests _
+1 💚unit5m 45shbase-compression-zstd in the patch passed.
24m 28s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5803/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5803
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ce46451ad63c 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / add57ca
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5803/1/testReport/
Max. process+thread count473 (vs. ulimit of 30000)
modulesC: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5803/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-3 Compile Tests _
+1 💚mvninstall4m 34sbranch-3 passed
+1 💚compile0m 25sbranch-3 passed
+1 💚checkstyle0m 12sbranch-3 passed
+1 💚spotless0m 56sbranch has no errors when running spotless:check.
+1 💚spotbugs0m 25sbranch-3 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile0m 17sthe patch passed
+1 💚javac0m 17sthe patch passed
+1 💚checkstyle0m 7sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck6m 15sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless1m 11spatch has no errors when running spotless:check.
+1 💚spotbugs0m 43sthe patch passed
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
26m 41s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5803/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5803
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 0566631aae64 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / add57ca
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5803/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+1 💚mvninstall4m 30sbranch-3 passed
+1 💚compile0m 14sbranch-3 passed
+1 💚shadedjars6m 45sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 15sbranch-3 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile0m 14sthe patch passed
+1 💚javac0m 14sthe patch passed
+1 💚shadedjars5m 59spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 11sthe patch passed
_ Other Tests _
+1 💚unit4m 25shbase-compression-zstd in the patch passed.
28m 3s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5803/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5803
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 09f081ac6720 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / add57ca
Default JavaEclipse Adoptium-17.0.10+7
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5803/1/testReport/
Max. process+thread count478 (vs. ulimit of 30000)
modulesC: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5803/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 50sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+1 💚mvninstall3m 47sbranch-3 passed
+1 💚compile0m 19sbranch-3 passed
+1 💚shadedjars6m 5sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 15sbranch-3 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 41sthe patch passed
+1 💚compile0m 18sthe patch passed
+1 💚javac0m 18sthe patch passed
+1 💚shadedjars6m 2spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 14sthe patch passed
_ Other Tests _
+1 💚unit8m 8shbase-compression-zstd in the patch passed.
30m 26s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5803/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5803
Optional Testsjavac javadoc unit shadedjars compile
unameLinux cf6427997642 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / add57ca
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5803/1/testReport/
Max. process+thread count487 (vs. ulimit of 30000)
modulesC: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5803/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit 75b1516 into apache:branch-3Apr 9, 2024
@ndimiduk
ndimiduk deleted the 28485-zsdt-reuse-ctx-perf-branch-3 branch April 9, 2024 09:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@charlesconnell