HBASE-28631 Show the create time of the replication peer by wangxin97-02 · Pull Request #5954 · apache/hbase

wangxin97-02 · 2024-05-30T09:16:02Z

When the table data needs to be migrated due to the closure of the computer room or the business side needs to have a primary and standby table, we need to create a peer.
By checking the creation time of the peer, we can understand when and what operations were performed, and the impact of these operations on the HBase system status.
When there is a problem with the HBase cluster, such as abnormal data synchronization, performance degradation, etc., displaying the creation time of the peer can help us quickly locate the possible source of the problem. For example, if a peer has a problem shortly after it is created, we can prioritize checking the configuration and status of the peer, optimize the related configuration of replication, etc.
Recording the creation time of the peer helps to audit and track system changes, ensuring that any changes to the replication configuration can be traced. This is very important for meeting data governance, security compliance, and business continuity requirements.

Apache-HBase · 2024-05-30T10:12:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 53s	master passed
+1 💚	compile	5m 36s	master passed
+1 💚	checkstyle	1m 11s	master passed
+1 💚	spotless	0m 59s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 42s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 51s	the patch passed
+1 💚	compile	5m 0s	the patch passed
+1 💚	cc	5m 0s	the patch passed
-0 ⚠️	javac	3m 23s	hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚	checkstyle	1m 43s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	6m 30s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	hbaseprotoc	1m 36s	the patch passed
-1 ❌	spotless	0m 21s	patch has 23 errors when running spotless:check, run spotless:apply to fix.
-1 ❌	spotbugs	2m 0s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 32s	The patch does not generate ASF License warnings.
		51m 48s

Reason	Tests
FindBugs	module:hbase-server
	Call to method of static java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.addPeer(String, ReplicationPeerConfig, boolean) At ReplicationPeerManager.java:java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.addPeer(String, ReplicationPeerConfig, boolean) At ReplicationPeerManager.java:[line 296]

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname	Linux 8a0d5530f5a3 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cd0b29c`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/artifact/yetus-general-check/output/patch-spotless.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-30T13:36:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 55s	master passed
+1 💚	compile	1m 35s	master passed
+1 💚	shadedjars	5m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 41s	the patch passed
+1 💚	compile	1m 35s	the patch passed
+1 💚	javac	1m 35s	the patch passed
+1 💚	shadedjars	5m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 33s	hbase-protocol-shaded in the patch passed.
-1 ❌	unit	1m 14s	hbase-client in the patch failed.
+1 💚	unit	226m 59s	hbase-server in the patch passed.
		255m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ebe11d20c37d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cd0b29c`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/testReport/
Max. process+thread count	5220 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-30T13:40:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 55s	master passed
+1 💚	compile	1m 39s	master passed
+1 💚	shadedjars	5m 29s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 49s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 43s	the patch passed
+1 💚	compile	1m 41s	the patch passed
+1 💚	javac	1m 41s	the patch passed
+1 💚	shadedjars	5m 27s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 48s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 31s	hbase-protocol-shaded in the patch passed.
-1 ❌	unit	1m 12s	hbase-client in the patch failed.
+1 💚	unit	229m 43s	hbase-server in the patch passed.
		259m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a1108b0b59b5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cd0b29c`
Default Java	Eclipse Adoptium-17.0.10+7
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-client.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/testReport/
Max. process+thread count	5470 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-30T13:47:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 49s	master passed
+1 💚	compile	1m 24s	master passed
+1 💚	shadedjars	5m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 48s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	compile	1m 23s	the patch passed
+1 💚	javac	1m 23s	the patch passed
+1 💚	shadedjars	5m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 28s	hbase-protocol-shaded in the patch passed.
-1 ❌	unit	1m 6s	hbase-client in the patch failed.
+1 💚	unit	238m 37s	hbase-server in the patch passed.
		266m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1f807dec3bd7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cd0b29c`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/testReport/
Max. process+thread count	4638 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Better add this to ReplicationPeerDescription instead of ReplicationPeerConfig?

It is not a config...

wangxin97-02 · 2024-06-04T14:47:09Z

Ok, I understand
Now, the create time of the peer needs to be recorded separately on the zk node for persistence, so I need to create a new node under /hbase/replication/peers/peerId, called the create-time.
Do you think that's okay? @Apache9

Apache9 · 2024-06-05T14:30:20Z

Ok, I understand Now, the create time of the peer needs to be recorded separately on the zk node for persistence, so I need to create a new node under /hbase/replication/peers/peerId, called the create-time. Do you think that's okay? @Apache9

Could we just use the creation time of the peer id znode or directory? If this is not stable, we could introduce a separated znode or file to store it.

wangxin97-02 · 2024-06-08T15:51:54Z

Ok, I understand Now, the create time of the peer needs to be recorded separately on the zk node for persistence, so I need to create a new node under /hbase/replication/peers/peerId, called the create-time. Do you think that's okay? @Apache9
Could we just use the creation time of the peer id znode or directory? If this is not stable, we could introduce a separated znode or file to store it.

The latest code has been submitted, please review it if you have time. I use the creation time of the peer id znode to get the create time of the peer.

Apache-HBase · 2024-06-08T16:43:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 49s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 22s	master passed
+1 💚	compile	5m 3s	master passed
+1 💚	checkstyle	1m 14s	master passed
+1 💚	spotless	0m 51s	branch has no errors when running spotless:check.
+1 💚	spotbugs	3m 49s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 58s	the patch passed
+1 💚	compile	4m 48s	the patch passed
-0 ⚠️	javac	3m 9s	hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
-0 ⚠️	checkstyle	0m 37s	hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	6m 40s	Patch does not cause any errors with Hadoop 3.3.6.
-1 ❌	spotless	1m 6s	patch has 35 errors when running spotless:check, run spotless:apply to fix.
-1 ❌	spotbugs	2m 58s	hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
		_ Other Tests _
+1 💚	asflicense	1m 4s	The patch does not generate ASF License warnings.
		52m 38s

Reason	Tests
FindBugs	module:hbase-server
	Call to method of static java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.addPeer(String, ReplicationPeerConfig, boolean) At ReplicationPeerManager.java:java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.addPeer(String, ReplicationPeerConfig, boolean) At ReplicationPeerManager.java:[line 301]
	Call to method of static java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.create(MasterServices, String) At ReplicationPeerManager.java:java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.create(MasterServices, String) At ReplicationPeerManager.java:[line 724]

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux a96a7e1f67b0 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f136f0a`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/artifact/yetus-general-check/output/patch-spotless.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-08T20:05:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 57s	master passed
+1 💚	compile	1m 44s	master passed
+1 💚	shadedjars	5m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 9s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 50s	the patch passed
+1 💚	compile	1m 45s	the patch passed
+1 💚	javac	1m 45s	the patch passed
+1 💚	shadedjars	5m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 34s	hbase-client in the patch passed.
+1 💚	unit	0m 43s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 35s	hbase-replication in the patch passed.
+1 💚	unit	223m 21s	hbase-server in the patch passed.
		254m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cb4dbdb30f3c 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f136f0a`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/testReport/
Max. process+thread count	5076 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-08T20:11:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 43s	master passed
+1 💚	compile	1m 22s	master passed
+1 💚	shadedjars	5m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	1m 20s	the patch passed
+1 💚	javac	1m 20s	the patch passed
+1 💚	shadedjars	5m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 28s	hbase-client in the patch passed.
+1 💚	unit	0m 36s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 25s	hbase-replication in the patch passed.
+1 💚	unit	231m 46s	hbase-server in the patch passed.
		260m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6c842a2797da 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f136f0a`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/testReport/
Max. process+thread count	5162 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-08T20:28:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 53s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 22s	master passed
+1 💚	compile	2m 14s	master passed
+1 💚	shadedjars	6m 26s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 31s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 58s	the patch passed
+1 💚	compile	2m 6s	the patch passed
+1 💚	javac	2m 6s	the patch passed
+1 💚	shadedjars	6m 21s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 57s	hbase-client in the patch passed.
+1 💚	unit	0m 41s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 35s	hbase-replication in the patch passed.
-1 ❌	unit	239m 18s	hbase-server in the patch failed.
		277m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 04182d19c222 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f136f0a`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/testReport/
Max. process+thread count	4615 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-06-11T13:40:57Z

+ public long getPeerCreateTime(String peerId) throws ReplicationException {
+ long createTimeIfNodeExists;
+ try {
+ createTimeIfNodeExists = ZKUtil.getCreateTimeIfNodeExists(zookeeper, getPeerNode(peerId));


Why not just return here? And what is the return value if the znode does not exist?

Apache9 · 2024-06-11T13:42:01Z

+ public static long getCreateTimeIfNodeExists(ZKWatcher zkw, String znode) throws KeeperException {
+ try {
+ Stat s = zkw.getRecoverableZooKeeper().exists(znode, false);
+ return s != null ? s.getCtime() : -1;


OK, -1, then we'd better have a constant in the ReplicationPeerStorage interface so all the implementations follow the same pattern?

Apache9 · 2024-06-11T13:42:33Z

+ } catch (KeeperException e) {
+ LOG.warn(zkw.prefix("Unable to get create time on znode (" + znode + ")"), e);
+ zkw.keeperException(e);
+ return -1;


Should we return -1 here instead of throwing exception out?

Apache-HBase · 2024-06-12T16:07:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 50s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 23s	master passed
+1 💚	compile	4m 58s	master passed
+1 💚	checkstyle	1m 25s	master passed
+1 💚	spotless	0m 58s	branch has no errors when running spotless:check.
+1 💚	spotbugs	3m 34s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 38s	the patch passed
+1 💚	compile	5m 16s	the patch passed
-0 ⚠️	javac	0m 21s	hbase-zookeeper generated 1 new + 49 unchanged - 0 fixed = 50 total (was 49)
-0 ⚠️	javac	3m 36s	hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
-0 ⚠️	checkstyle	0m 9s	hbase-replication: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️	checkstyle	0m 48s	hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	7m 14s	Patch does not cause any errors with Hadoop 3.3.6.
-1 ❌	spotless	0m 21s	patch has 24 errors when running spotless:check, run spotless:apply to fix.
-1 ❌	spotbugs	2m 24s	hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 43s	The patch does not generate ASF License warnings.
		47m 7s

Reason	Tests
FindBugs	module:hbase-server
	Call to method of static java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.addPeer(String, ReplicationPeerConfig, boolean) At ReplicationPeerManager.java:java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.addPeer(String, ReplicationPeerConfig, boolean) At ReplicationPeerManager.java:[line 301]
	Call to method of static java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.create(MasterServices, String) At ReplicationPeerManager.java:java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.create(MasterServices, String) At ReplicationPeerManager.java:[line 724]

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 833afd05de30 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9bdee6d`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-replication.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/artifact/yetus-general-check/output/patch-spotless.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-12T19:48:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 8s	master passed
+1 💚	compile	2m 5s	master passed
+1 💚	shadedjars	7m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 38s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 55s	the patch passed
+1 💚	compile	2m 10s	the patch passed
+1 💚	javac	2m 10s	the patch passed
+1 💚	shadedjars	6m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 34s	hbase-client in the patch passed.
+1 💚	unit	0m 50s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 26s	hbase-replication in the patch passed.
+1 💚	unit	227m 47s	hbase-server in the patch passed.
		267m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 930fbab079e6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9bdee6d`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/testReport/
Max. process+thread count	4422 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-12T19:51:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 40s	master passed
+1 💚	compile	1m 40s	master passed
+1 💚	shadedjars	5m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 10s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 47s	the patch passed
+1 💚	compile	1m 38s	the patch passed
+1 💚	javac	1m 38s	the patch passed
+1 💚	shadedjars	5m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 39s	hbase-client in the patch passed.
+1 💚	unit	0m 41s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 34s	hbase-replication in the patch passed.
-1 ❌	unit	238m 52s	hbase-server in the patch failed.
		270m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b44755ffe00e 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9bdee6d`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/testReport/
Max. process+thread count	4609 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-12T19:53:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 43s	master passed
+1 💚	compile	1m 21s	master passed
+1 💚	shadedjars	5m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 58s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
+1 💚	shadedjars	5m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 27s	hbase-client in the patch passed.
+1 💚	unit	0m 36s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 24s	hbase-replication in the patch passed.
-1 ❌	unit	243m 19s	hbase-server in the patch failed.
		272m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6ccb2ca3f37e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9bdee6d`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/testReport/
Max. process+thread count	5284 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-20T13:37:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 21s	master passed
+1 💚	compile	4m 54s	master passed
+1 💚	checkstyle	1m 18s	master passed
+1 💚	spotless	0m 49s	branch has no errors when running spotless:check.
+1 💚	spotbugs	3m 41s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 28s	the patch passed
+1 💚	compile	4m 44s	the patch passed
-0 ⚠️	javac	0m 21s	hbase-zookeeper generated 1 new + 49 unchanged - 0 fixed = 50 total (was 49)
-0 ⚠️	javac	3m 16s	hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
-0 ⚠️	checkstyle	0m 10s	hbase-replication: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️	checkstyle	0m 48s	hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	6m 15s	Patch does not cause any errors with Hadoop 3.3.6.
-1 ❌	spotless	0m 22s	patch has 24 errors when running spotless:check, run spotless:apply to fix.
-1 ❌	spotbugs	2m 14s	hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		45m 57s

Reason	Tests
FindBugs	module:hbase-server
	Call to method of static java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.addPeer(String, ReplicationPeerConfig, boolean) At ReplicationPeerManager.java:java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.addPeer(String, ReplicationPeerConfig, boolean) At ReplicationPeerManager.java:[line 301]
	Call to method of static java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.create(MasterServices, String) At ReplicationPeerManager.java:java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.create(MasterServices, String) At ReplicationPeerManager.java:[line 724]

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 928747c95cf8 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `62e7fe8`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-replication.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/artifact/yetus-general-check/output/patch-spotless.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-20T16:49:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 53s	master passed
+1 💚	compile	1m 31s	master passed
+1 💚	shadedjars	5m 18s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 1s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 43s	the patch passed
+1 💚	compile	1m 30s	the patch passed
+1 💚	javac	1m 30s	the patch passed
+1 💚	shadedjars	5m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 58s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 29s	hbase-client in the patch passed.
+1 💚	unit	0m 37s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 25s	hbase-replication in the patch passed.
+1 💚	unit	209m 56s	hbase-server in the patch passed.
		239m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6b8be09274b3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `62e7fe8`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/testReport/
Max. process+thread count	5089 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-20T17:13:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 55s	master passed
+1 💚	compile	1m 43s	master passed
+1 💚	shadedjars	5m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 50s	the patch passed
+1 💚	compile	1m 40s	the patch passed
+1 💚	javac	1m 40s	the patch passed
+1 💚	shadedjars	5m 17s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 40s	hbase-client in the patch passed.
+1 💚	unit	0m 44s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 34s	hbase-replication in the patch passed.
+1 💚	unit	231m 15s	hbase-server in the patch passed.
		262m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 63e3f93e4f56 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `62e7fe8`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/testReport/
Max. process+thread count	4806 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-20T18:13:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 35s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 59s	master passed
+1 💚	compile	2m 15s	master passed
+1 💚	shadedjars	7m 57s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 22s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 29s	the patch passed
+1 💚	compile	2m 13s	the patch passed
+1 💚	javac	2m 13s	the patch passed
+1 💚	shadedjars	8m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 57s	hbase-client in the patch passed.
+1 💚	unit	0m 55s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 45s	hbase-replication in the patch passed.
+1 💚	unit	281m 13s	hbase-server in the patch passed.
		322m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e4063bb84bda 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `62e7fe8`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/testReport/
Max. process+thread count	5203 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-06-21T07:37:04Z

 if (!enabled) {
 fs.createNewFile(new Path(peerDir, DISABLED_FILE));
 }
+ write(fs, peerDir, CREATE_TIME_FILE,


For create time I do not think we need to use the special write method here? As we will never change it...

Apache-HBase · 2024-06-23T03:58:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 47s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --blanks-eol-ignore-list --blanks-tabs-ignore-list
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 0s		master passed
+1 💚	compile	4m 5s		master passed
+1 💚	checkstyle	1m 11s		master passed
+1 💚	spotbugs	3m 2s		master passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 48s		the patch passed
+1 💚	compile	4m 2s		the patch passed
-0 ⚠️	javac	0m 20s	/results-compile-javac-hbase-zookeeper.txt	hbase-zookeeper generated 1 new + 49 unchanged - 0 fixed = 50 total (was 49)
-0 ⚠️	javac	2m 43s	/results-compile-javac-hbase-server.txt	hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 8s	/results-checkstyle-hbase-replication.txt	hbase-replication: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️	checkstyle	0m 37s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
-1 ❌	spotbugs	1m 42s	/new-spotbugs-hbase-server.html	hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	hadoopcheck	5m 2s		Patch does not cause any errors with Hadoop 3.3.6.
-1 ❌	spotless	0m 21s		patch has 24 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 40s		The patch does not generate ASF License warnings.
		37m 51s

Reason	Tests
SpotBugs	module:hbase-server
	Call to method of static java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.addPeer(String, ReplicationPeerConfig, boolean) At ReplicationPeerManager.java:java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.addPeer(String, ReplicationPeerConfig, boolean) At ReplicationPeerManager.java:[line 301]
	Call to method of static java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.create(MasterServices, String) At ReplicationPeerManager.java:java.text.DateFormat in org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.create(MasterServices, String) At ReplicationPeerManager.java:[line 724]

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 9cbba48096a5 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ad97646`
Default Java	Eclipse Adoptium-11.0.17+8
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/5/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-23T07:19:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-list --blanks-tabs-ignore-list --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 46s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 23s		master passed
+1 💚	compile	1m 35s		master passed
+1 💚	javadoc	1m 0s		master passed
+1 💚	shadedjars	5m 38s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s		the patch passed
+1 💚	compile	1m 37s		the patch passed
+1 💚	javac	1m 37s		the patch passed
+1 💚	javadoc	1m 1s		the patch passed
+1 💚	shadedjars	5m 38s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	1m 32s		hbase-client in the patch passed.
+1 💚	unit	0m 37s		hbase-zookeeper in the patch passed.
+1 💚	unit	0m 26s		hbase-replication in the patch passed.
+1 💚	unit	207m 8s		hbase-server in the patch passed.
		238m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux e1acf2996d53 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ad97646`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/5/testReport/
Max. process+thread count	5213 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-23T07:33:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-list --blanks-tabs-ignore-list --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 14s		master passed
+1 💚	compile	1m 30s		master passed
+1 💚	javadoc	1m 3s		master passed
+1 💚	shadedjars	5m 56s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 1s		the patch passed
+1 💚	compile	1m 31s		the patch passed
+1 💚	javac	1m 31s		the patch passed
+1 💚	javadoc	1m 1s		the patch passed
+1 💚	shadedjars	5m 52s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	1m 37s		hbase-client in the patch passed.
+1 💚	unit	0m 40s		hbase-zookeeper in the patch passed.
+1 💚	unit	0m 27s		hbase-replication in the patch passed.
+1 💚	unit	221m 40s		hbase-server in the patch passed.
		252m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 299584c7fe55 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ad97646`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/5/testReport/
Max. process+thread count	5642 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-23T07:45:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-list --blanks-tabs-ignore-list --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 33s		master passed
+1 💚	compile	1m 28s		master passed
+1 💚	javadoc	1m 4s		master passed
+1 💚	shadedjars	5m 8s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s		the patch passed
+1 💚	compile	1m 26s		the patch passed
+1 💚	javac	1m 26s		the patch passed
+1 💚	javadoc	1m 0s		the patch passed
+1 💚	shadedjars	5m 9s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	1m 22s		hbase-client in the patch passed.
+1 💚	unit	0m 40s		hbase-zookeeper in the patch passed.
+1 💚	unit	0m 32s		hbase-replication in the patch passed.
+1 💚	unit	235m 35s		hbase-server in the patch passed.
		264m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5954
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 484b77e3094b 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ad97646`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/5/testReport/
Max. process+thread count	5645 (vs. ulimit of 30000)
modules	C: hbase-client hbase-zookeeper hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5954/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

wangxin97-02 · 2024-06-27T14:40:11Z

 if (!enabled) {
 fs.createNewFile(new Path(peerDir, DISABLED_FILE));
 }
+ fs.createNewFile(new Path(peerDir, CREATE_TIME_FILE));


I have changed it to just create this file and not add content. So I can use fs.getFileStatus(createTimeFile).getModificationTime() to get peer create time. @Apache9

Apache9 reviewed Jun 3, 2024
View reviewed changes

wangxin97-02 force-pushed the master branch from 000bb4c to b8d7583Compare June 8, 2024 15:44

Apache9 reviewed Jun 11, 2024
View reviewed changes

wangxin97-02 force-pushed the master branch 2 times, most recently from de4d772 to b1d16ffCompare June 12, 2024 15:11

wangxin97-02 force-pushed the master branch from b1d16ff to 6d32a16Compare June 20, 2024 12:49

Apache9 reviewed Jun 21, 2024
View reviewed changes

Show the create time of the replication peer
ad97646

wangxin97-02 force-pushed the master branch from 6d32a16 to ad97646Compare June 23, 2024 03:07

wangxin97-02 commented Jun 27, 2024
View reviewed changes

wangxin97-02 requested a review from Apache9 August 13, 2024 10:45

Uh oh!

Conversation

wangxin97-02 commented May 30, 2024

Uh oh!

Apache-HBase commented May 30, 2024

Uh oh!

Apache-HBase commented May 30, 2024

Uh oh!

Apache-HBase commented May 30, 2024

Uh oh!

Apache-HBase commented May 30, 2024

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

wangxin97-02 commented Jun 4, 2024

Uh oh!

Apache9 commented Jun 5, 2024

Uh oh!

wangxin97-02 commented Jun 8, 2024

Uh oh!

Apache-HBase commented Jun 8, 2024

Uh oh!

Apache-HBase commented Jun 8, 2024

Uh oh!

Apache-HBase commented Jun 8, 2024

Uh oh!

Apache-HBase commented Jun 8, 2024

Uh oh!

Uh oh!

Apache9Jun 11, 2024

Choose a reason for hiding this comment

Uh oh!

Apache9Jun 11, 2024

Choose a reason for hiding this comment

Uh oh!

Apache9Jun 11, 2024

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jun 12, 2024

Uh oh!

Apache-HBase commented Jun 12, 2024

Uh oh!

Apache-HBase commented Jun 12, 2024

Uh oh!

Apache-HBase commented Jun 12, 2024

Uh oh!

Apache-HBase commented Jun 20, 2024

Uh oh!

Apache-HBase commented Jun 20, 2024

Uh oh!

Apache-HBase commented Jun 20, 2024

Uh oh!

Apache-HBase commented Jun 20, 2024

Uh oh!

Apache9Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jun 23, 2024

Uh oh!

Apache-HBase commented Jun 23, 2024

Uh oh!

Apache-HBase commented Jun 23, 2024

Uh oh!

Apache-HBase commented Jun 23, 2024

Uh oh!

wangxin97-02Jun 27, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants