Uh oh!
There was an error while loading. Please reload this page.
HBASE-28565 Make map reduce jobs accept connection uri when specifyin… - #5972
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Apache-HBase
commented
Jun 9, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 9, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 9, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 9, 2024
🎊 +1 overall
This message was automatically generated. |
ndimiduk
left a comment
There was a problem hiding this comment.
Looks good, I have just a couple small suggestions. Thanks for the exhaustive test coverage.
Uh oh!
There was an error while loading. Please reload this page.
| import org.junit.experimental.categories.Category; | ||
| @Category({ MapReduceTests.class, LargeTests.class }) | ||
| public class TestCopyTableToPeerClusterWithClusterKey extends CopyTableToPeerClusterTestBase { |
There was a problem hiding this comment.
Oof. It would be nice if we could verify this "simple" change without needing to actually run these map-reduce jobs. But yes, I understand why you've added them.
Uh oh!
There was an error while loading. Please reload this page.
| tokenForCluster.decodeIdentifier().getUsername()); | ||
| } | ||
| } finally { | ||
| kdc.stop(); |
There was a problem hiding this comment.
I'm surprised to see that MiniKdc is not AutoCloseable.
Apache-HBase
commented
Jun 11, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 11, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 11, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 11, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 12, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 12, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 12, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 12, 2024
🎊 +1 overall
This message was automatically generated. |
…g peer cluster