Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-5296 : Ensure store file reader refcount is zero at end of relevant unit tests - #1097
Closed
virajjasani wants to merge 1 commit into
Closed
PHOENIX-5296 : Ensure store file reader refcount is zero at end of relevant unit tests#1097virajjasani wants to merge 1 commit into
virajjasani wants to merge 1 commit into
Conversation
stoty
commented
Jan 18, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
virajjasani
commented
Jan 18, 2021
ContributorAuthor
Once changes are finalized in #1096 , will get them here together. |
stoty
suggested changes
Jan 19, 2021
stoty
left a comment
Contributor
There was a problem hiding this comment.
Can you port the latest version from master here ?
virajjasani
commented
Jan 19, 2021
ContributorAuthor
Sure, I am on it. |
stoty
commented
Jan 19, 2021
Contributor
Looks good, let's wait for the Yetus checks. |
virajjasani
commented
Jan 19, 2021
ContributorAuthor
Build#2 is aborted, let's see how build#3 goes, it was lined up. |
stoty
commented
Jan 20, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
ContributorAuthor
@stoty For 4.x, a couple more patch results are available on Jira. But master patch builds are still taking time. What do you suggest? Let's see some builds are anyways in progress. |
stoty
approved these changes
Jan 20, 2021
stoty
commented
Jan 20, 2021
Contributor
Can you start one more for each branch ? |
ContributorAuthor
PR-1097#8 build timed out after 9 hr and PR-1097#9 is in progress. In the meanwhile, we have below build results available from precommit Jira for 4.x (QA results available on Jira): https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/367/ For PR-1096, both latest triggered builds were successful. While precommit PR builds are serial, precommit Jira builds can run in parallel (consuming more resources?) |
stoty
commented
Jan 21, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Jan 22, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
virajjasani
commented
Jan 22, 2021
ContributorAuthor
Just removed changes in |
stoty
commented
Jan 22, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Jan 23, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Jan 24, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
reviewed
Jan 26, 2021
stoty
left a comment
Contributor
There was a problem hiding this comment.
Looks good, apart form the indent nits. see
https://www.oracle.com/technetwork/java/codeconventions-150003.pdf section 4.2
| {1L, 20L, 10L, 1L, 1L}, | ||
| {1L, 20L, 10L, 0L, 2L}, | ||
| {1L, 100L, 10L, 0L, 3L}, | ||
| {100000L, 5000L, 10L, 0L, 0L}, |
Contributor
There was a problem hiding this comment.
Your autoformatter doesn't seem to be set up right.
Continuation lines should either be matched to the previous expression, or use 8 spaces, not 4.
| StringBuilder ddl = new StringBuilder("CREATE TABLE " + fullTableName | ||
| + " (col1 varchar primary key"); | ||
| for (int i = 2; i< columns; i++){ | ||
| + " (col1 varchar primary key"); |
stoty
reviewed
Jan 26, 2021
| private static final String MODIFIED_MAX_VERSIONS ="5"; | ||
| private static final String CREATE_TABLE_STMT = "CREATE TABLE %s" | ||
| + " (k1 VARCHAR NOT NULL, k2 VARCHAR, CONSTRAINT PK PRIMARY KEY(K1,K2))"; | ||
| + " (k1 VARCHAR NOT NULL, k2 VARCHAR, CONSTRAINT PK PRIMARY KEY(K1,K2))"; |
Contributor
There was a problem hiding this comment.
These line continuations do match the conventions in https://phoenix.apache.org/contributing.html .
I know that we have code in much worse shape than this, but since you are fixing formatting, we might as well do it by the book.
ContributorAuthor
There was a problem hiding this comment.
True, i just realized that i had continuation tab as 4 as opposed to 8.
ContributorAuthor
There was a problem hiding this comment.
you meant do not match the conventions above right?
Contributor
There was a problem hiding this comment.
https://phoenix.apache.org/develop.html details the steps for Eclipse and intelliJ
stoty
commented
Jan 26, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Jan 26, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Jan 27, 2021
Contributor
Comitted with updated commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4.x backport PR of #1096