Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6198 Add option to IndexTool to specify the source table for scan - #937
Merged
Merged
Conversation
tkhurana
commented
Oct 23, 2020
ContributorAuthor
gokceni
suggested changes
Oct 23, 2020
gokceni
left a comment
Contributor
There was a problem hiding this comment.
Having an IT that test that index table is used would be great (extra tables in index table, run IndexTool without this option see that it doesn't return anything, with this option and observe the failure)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
stoty
commented
Oct 23, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE. Added the disclaimer for -vAFTER. Also, using the source table enum from IndexScrutinyTool.
tkhurana
commented
Oct 29, 2020
ContributorAuthor
I have comprehensive IT tests for end to end functionality in an upcoming PR. This PR is just for client side changes. I have broken up the feature into multiple smaller PRs to ease the review. Ultimately, the feature branch apache:4.x-PHOENIX-5182 will be merged into mainline. |
stoty
commented
Oct 29, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
| public static IndexScrutinyTool.SourceTable getIndexToolSourceTable(Configuration configuration) { | ||
| Preconditions.checkNotNull(configuration); | ||
| return IndexScrutinyTool.SourceTable.valueOf(configuration.get(INDEX_TOOL_SOURCE_TABLE, | ||
| IndexScrutinyTool.SourceTable.DATA_TABLE_SOURCE.name())); |
Contributor
There was a problem hiding this comment.
IndexScrutinyTool.SourceTable.DATA_TABLE_SOURCE.name() the default value?
ContributorAuthor
There was a problem hiding this comment.
By default, we are going to use the data table as the source which is what the current behavior is. We have to return a string from which the appropriate enum is constructed. I am not sure what is the question here.
gokceni
approved these changes
Nov 4, 2020
swaroopak
approved these changes
Nov 9, 2020
tkhurana added a commit
to tkhurana/phoenix
that referenced
this pull request
Nov 13, 2020
…ble for scan (apache#937)" This reverts commit 0d33ce9.
swaroopak pushed a commit
that referenced
this pull request
Dec 17, 2020
…scan (#937) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan * Addressed feedback for PHOENIX-6198 Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE. Added the disclaimer for -vAFTER. Also, using the source table enum from IndexScrutinyTool.
swaroopak pushed a commit
that referenced
this pull request
Dec 17, 2020
…1022) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan (#937) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan * Addressed feedback for PHOENIX-6198 Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE. Added the disclaimer for -vAFTER. Also, using the source table enum from IndexScrutinyTool. * PHOENIX-6199 Generate different query plan depending upon if the source (#958) is index table or data table * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (#995) * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table * Address feedback * PHOENIX-6200 (addendum) Fix test case because invalid rows now are reported as beyond max lookback when max lookback is set to 0 Also add ASF license to one file
tkhurana added a commit
to tkhurana/phoenix
that referenced
this pull request
Jan 29, 2021
…pache#1022) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan * Addressed feedback for PHOENIX-6198 Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE. Added the disclaimer for -vAFTER. Also, using the source table enum from IndexScrutinyTool. * PHOENIX-6199 Generate different query plan depending upon if the source (apache#958) is index table or data table * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995) * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table * Address feedback * PHOENIX-6200 (addendum) Fix test case because invalid rows now are reported as beyond max lookback when max lookback is set to 0 Also add ASF license to one file
stoty pushed a commit
to stoty/phoenix
that referenced
this pull request
Feb 1, 2021
…pache#1022) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan * Addressed feedback for PHOENIX-6198 Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE. Added the disclaimer for -vAFTER. Also, using the source table enum from IndexScrutinyTool. * PHOENIX-6199 Generate different query plan depending upon if the source (apache#958) is index table or data table * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995) * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table * Address feedback * PHOENIX-6200 (addendum) Fix test case because invalid rows now are reported as beyond max lookback when max lookback is set to 0 Also add ASF license to one file
stoty pushed a commit
to stoty/phoenix
that referenced
this pull request
Feb 1, 2021
…pache#1022) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan * Addressed feedback for PHOENIX-6198 Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE. Added the disclaimer for -vAFTER. Also, using the source table enum from IndexScrutinyTool. * PHOENIX-6199 Generate different query plan depending upon if the source (apache#958) is index table or data table * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995) * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table * Address feedback * PHOENIX-6200 (addendum) Fix test case because invalid rows now are reported as beyond max lookback when max lookback is set to 0 Also add ASF license to one file
stoty pushed a commit
to stoty/phoenix
that referenced
this pull request
Feb 2, 2021
…pache#1022) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan * Addressed feedback for PHOENIX-6198 Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE. Added the disclaimer for -vAFTER. Also, using the source table enum from IndexScrutinyTool. * PHOENIX-6199 Generate different query plan depending upon if the source (apache#958) is index table or data table * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995) * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table * Address feedback * PHOENIX-6200 (addendum) Fix test case because invalid rows now are reported as beyond max lookback when max lookback is set to 0 Also add ASF license to one file
asfgit pushed a commit
that referenced
this pull request
Feb 2, 2021
…1022) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan (#937) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan * Addressed feedback for PHOENIX-6198 Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE. Added the disclaimer for -vAFTER. Also, using the source table enum from IndexScrutinyTool. * PHOENIX-6199 Generate different query plan depending upon if the source (#958) is index table or data table * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (#995) * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table * Address feedback * PHOENIX-6200 (addendum) Fix test case because invalid rows now are reported as beyond max lookback when max lookback is set to 0 Also add ASF license to one file This port to the master branch also includes a fix for * PHOENIX-6356 missing row.clear() for dummy row in GlobalIndexRegionScanner
asfgit pushed a commit
that referenced
this pull request
Feb 2, 2021
…1022) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan (#937) * PHOENIX-6198 Add option to IndexTool to specify the source table for scan * Addressed feedback for PHOENIX-6198 Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE. Added the disclaimer for -vAFTER. Also, using the source table enum from IndexScrutinyTool. * PHOENIX-6199 Generate different query plan depending upon if the source (#958) is index table or data table * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (#995) * PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table * Address feedback * PHOENIX-6200 (addendum) Fix test case because invalid rows now are reported as beyond max lookback when max lookback is set to 0 Also add ASF license to one file This port to the master branch also includes a fix for * PHOENIX-6356 missing row.clear() for dummy row in GlobalIndexRegionScanner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PHOENIX-6182
New option
-fior--from-indexadded. When specified, use the index table as the source for verification. Inly works with-vBEFOREand-vONLYoptions.