Skip to content

PHOENIX-6199 Generate different query plan depending upon if the source is index table or data table - #958

Merged
swaroopak merged 1 commit into
apache:4.x-PHOENIX-5182from
tkhurana:PHOENIX-6199-4.x
Dec 1, 2020
Merged

PHOENIX-6199 Generate different query plan depending upon if the source is index table or data table#958
swaroopak merged 1 commit into
apache:4.x-PHOENIX-5182from
tkhurana:PHOENIX-6199-4.x

Conversation

@tkhurana

@tkhuranatkhurana commented Nov 9, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

@tkhurana
tkhurana changed the base branch from 4.x-PHOENIX-5182 to 4.xNovember 9, 2020 18:23
@tkhurana
tkhurana changed the base branch from 4.x to 4.x-PHOENIX-5182November 9, 2020 18:25
@stoty

stoty commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ 4.x Compile Tests _
+1 💚mvninstall10m 46s4.x passed
+1 💚compile0m 55s4.x passed
+1 💚checkstyle0m 53s4.x passed
+1 💚javadoc0m 45s4.x passed
+0 🆗spotbugs2m 54sphoenix-core in 4.x has 946 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall5m 15sthe patch passed
+1 💚compile0m 54sthe patch passed
+1 💚javac0m 54sthe patch passed
-1 ❌checkstyle0m 56sphoenix-core: The patch generated 53 new + 962 unchanged - 16 fixed = 1015 total (was 978)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 41sthe patch passed
+1 💚spotbugs3m 1sthe patch passed
_ Other Tests _
-1 ❌unit126m 53sphoenix-core in the patch failed.
-1 ❌asflicense0m 37sThe patch generated 1 ASF License warnings.
157m 46s
ReasonTests
Failed junit testsphoenix.end2end.DerivedTableIT
phoenix.end2end.BackwardCompatibilityForSplitableSyscatIT
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-958/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#958
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux 0fbd2d7aaa57 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x / f0f2f74
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-958/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-958/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-958/1/testReport/
asflicensehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-958/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count7152 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-958/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x-PHOENIX-5182 Compile Tests _
+1 💚mvninstall10m 55s4.x-PHOENIX-5182 passed
+1 💚compile0m 55s4.x-PHOENIX-5182 passed
+1 💚checkstyle0m 31s4.x-PHOENIX-5182 passed
+1 💚javadoc0m 45s4.x-PHOENIX-5182 passed
+0 🆗spotbugs2m 53sphoenix-core in 4.x-PHOENIX-5182 has 954 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall5m 12sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚checkstyle0m 32sphoenix-core: The patch generated 0 new + 62 unchanged - 3 fixed = 62 total (was 65)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 44sthe patch passed
+1 💚spotbugs3m 5sthe patch passed
_ Other Tests _
-1 ❌unit128m 12sphoenix-core in the patch failed.
-1 ❌asflicense0m 38sThe patch generated 1 ASF License warnings.
158m 35s
ReasonTests
Failed junit testsphoenix.end2end.StoreNullsIT
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-958/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#958
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux 0d8b501c6702 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x-PHOENIX-5182 / 0d33ce9
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-958/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-958/2/testReport/
asflicensehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-958/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count7005 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-958/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tkhurana

tkhurana commented Nov 25, 2020

Copy link
Copy Markdown
ContributorAuthor

@gokceni@kadirozde@swaroopak

swaroopak
swaroopak approved these changes Nov 25, 2020
View reviewed changes

@swaroopakswaroopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks!

@swaroopak
swaroopak merged commit 92c8579 into apache:4.x-PHOENIX-5182Dec 1, 2020
swaroopak pushed a commit that referenced this pull request Dec 17, 2020
@tkhuranaSwaroopa Kadam
PHOENIX-6199Generate different query plan depending upon if the sour…
1496765
…ce (#958)
is index table or data table
swaroopak pushed a commit that referenced this pull request Dec 17, 2020
@tkhurana
MergePHOENIX-6182: IndexTool to verify and repair every index row (#…
3b6ea02
…1022)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
* PHOENIX-6199 Generate different query plan depending upon if the source (#958)
is index table or data table
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
tkhurana added a commit to tkhurana/phoenix that referenced this pull request Jan 29, 2021
@tkhurana
Merge PHOENIX-6182: IndexTool to verify and repair every index row (a…
8bd8da5
…pache#1022)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
* PHOENIX-6199 Generate different query plan depending upon if the source (apache#958)
is index table or data table
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
@tkhuranatkhurana mentioned this pull request Jan 29, 2021
Closed
stoty pushed a commit to stoty/phoenix that referenced this pull request Feb 1, 2021
@tkhurana@stoty
Merge PHOENIX-6182: IndexTool to verify and repair every index row (a…
9cb5c33
…pache#1022)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
* PHOENIX-6199 Generate different query plan depending upon if the source (apache#958)
is index table or data table
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
@stotystoty mentioned this pull request Feb 1, 2021
Closed
stoty pushed a commit to stoty/phoenix that referenced this pull request Feb 1, 2021
@tkhurana@stoty
Merge PHOENIX-6182: IndexTool to verify and repair every index row (a…
b1d6d86
…pache#1022)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
* PHOENIX-6199 Generate different query plan depending upon if the source (apache#958)
is index table or data table
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
stoty pushed a commit to stoty/phoenix that referenced this pull request Feb 2, 2021
@tkhurana@stoty
Merge PHOENIX-6182: IndexTool to verify and repair every index row (a…
8258991
…pache#1022)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
* PHOENIX-6199 Generate different query plan depending upon if the source (apache#958)
is index table or data table
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
asfgit pushed a commit that referenced this pull request Feb 2, 2021
@tkhurana@stoty
MergePHOENIX-6182: IndexTool to verify and repair every index row (#…
a26adea
…1022)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
* PHOENIX-6199 Generate different query plan depending upon if the source (#958)
is index table or data table
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
This port to the master branch also includes a fix for
* PHOENIX-6356 missing row.clear() for dummy row in GlobalIndexRegionScanner
asfgit pushed a commit that referenced this pull request Feb 2, 2021
@tkhurana@stoty
MergePHOENIX-6182: IndexTool to verify and repair every index row (#…
7db43ea
…1022)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
* PHOENIX-6199 Generate different query plan depending upon if the source (#958)
is index table or data table
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
This port to the master branch also includes a fix for
* PHOENIX-6356 missing row.clear() for dummy row in GlobalIndexRegionScanner
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swaroopakswaroopakswaroopak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tkhurana@stoty@swaroopak