Skip to content

Merge PHOENIX-6182: IndexTool to verify and repair every index row - #1022

Merged
swaroopak merged 4 commits into
apache:4.xfrom
tkhurana:4.x-PHOENIX-6182
Dec 17, 2020
Merged

Merge PHOENIX-6182: IndexTool to verify and repair every index row#1022
swaroopak merged 4 commits into
apache:4.xfrom
tkhurana:4.x-PHOENIX-6182

Conversation

@tkhurana

Copy link
Copy Markdown
Contributor

No description provided.

…scan (apache#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
…d PIT_RESULT table (apache#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
@tkhuranatkhurana changed the title Merge PHOENIX-6182Merge PHOENIX-6182: IndexTool to verify and repair every index rowDec 17, 2020
@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 23sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 3 new or modified test files.
_ 4.x Compile Tests _
+1 💚mvninstall14m 6s4.x passed
+1 💚compile1m 0s4.x passed
+1 💚checkstyle1m 36s4.x passed
+1 💚javadoc0m 46s4.x passed
+0 🆗spotbugs3m 3sphoenix-core in 4.x has 958 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall5m 47sthe patch passed
+1 💚compile1m 2sthe patch passed
+1 💚javac1m 2sthe patch passed
-1 ❌checkstyle1m 34sphoenix-core: The patch generated 212 new + 2750 unchanged - 31 fixed = 2962 total (was 2781)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 47sthe patch passed
-1 ❌spotbugs3m 15sphoenix-core generated 4 new + 958 unchanged - 0 fixed = 962 total (was 958)
_ Other Tests _
-1 ❌unit206m 38sphoenix-core in the patch failed.
+1 💚asflicense0m 42sThe patch does not generate ASF License warnings.
244m 48s
ReasonTests
FindBugsmodule:phoenix-core
org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.AFTER_REPAIR_EXTRA_UNVERIFIED_INDEX_ROW_COUNT_BYTES is a mutable array At IndexVerificationResultRepository.java: At IndexVerificationResultRepository.java:[line 136]
org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.AFTER_REPAIR_EXTRA_VERIFIED_INDEX_ROW_COUNT_BYTES is a mutable array At IndexVerificationResultRepository.java: At IndexVerificationResultRepository.java:[line 133]
org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.BEFORE_REPAIR_EXTRA_UNVERIFIED_INDEX_ROW_COUNT_BYTES is a mutable array At IndexVerificationResultRepository.java: At IndexVerificationResultRepository.java:[line 129]
org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.BEFORE_REPAIR_EXTRA_VERIFIED_INDEX_ROW_COUNT_BYTES is a mutable array At IndexVerificationResultRepository.java: At IndexVerificationResultRepository.java:[line 126]
Failed junit testsphoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT
phoenix.util.IndexScrutinyIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1022/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1022
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux c3c138416e7c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x / aa468e3
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1022/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1022/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1022/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1022/1/testReport/
Max. process+thread count6259 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1022/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@swaroopak
swaroopak merged commit 3b6ea02 into apache:4.xDec 17, 2020
tkhurana added a commit to tkhurana/phoenix that referenced this pull request Jan 29, 2021
…pache#1022)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
* PHOENIX-6199 Generate different query plan depending upon if the source (apache#958)
is index table or data table
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
stoty pushed a commit to stoty/phoenix that referenced this pull request Feb 1, 2021
…pache#1022)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
* PHOENIX-6199 Generate different query plan depending upon if the source (apache#958)
is index table or data table
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
stoty pushed a commit to stoty/phoenix that referenced this pull request Feb 1, 2021
…pache#1022)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
* PHOENIX-6199 Generate different query plan depending upon if the source (apache#958)
is index table or data table
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
stoty pushed a commit to stoty/phoenix that referenced this pull request Feb 2, 2021
…pache#1022)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
* PHOENIX-6199 Generate different query plan depending upon if the source (apache#958)
is index table or data table
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
asfgit pushed a commit that referenced this pull request Feb 2, 2021
…1022)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
* PHOENIX-6199 Generate different query plan depending upon if the source (#958)
is index table or data table
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
This port to the master branch also includes a fix for
* PHOENIX-6356 missing row.clear() for dummy row in GlobalIndexRegionScanner
asfgit pushed a commit that referenced this pull request Feb 2, 2021
…1022)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (#937)
* PHOENIX-6198 Add option to IndexTool to specify the source table for scan
* Addressed feedback for PHOENIX-6198
Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
* PHOENIX-6199 Generate different query plan depending upon if the source (#958)
is index table or data table
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (#995)
* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table
* Address feedback
* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
This port to the master branch also includes a fix for
* PHOENIX-6356 missing row.clear() for dummy row in GlobalIndexRegionScanner
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tkhurana@stoty@swaroopak