Review and tidy ./solr/modules code

[epugh]

Description

Go through code in ./solr/modules (both source and tests) and tidy up code.

Solution

Leverage Intellij warnings

Tests

existing

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 102 out of 103 changed files in this pull request and generated 3 comments.

Suppressed comments (6)

solr/modules/scripting/src/java/org/apache/solr/scripting/xslt/XSLTResponseWriter.java:71

• The article is incorrect before “XSLT”; use “an XSLT output element.”
  solr/modules/scripting/src/java/org/apache/solr/scripting/update/ScriptUpdateProcessorFactory.java:339
• This updated description is grammatically unclear and “exceptions registered” does not describe the implementation. The method returns null when factory discovery returns null or throws a runtime exception.
  solr/modules/analysis-extras/src/java/org/apache/solr/schema/ICUCollationField.java:111
• Use “an XML configuration file”; “XML” takes “an,” and the initialism should be capitalized.

 // error via `XMLConfigFile.assertWarnOrFail(...)` is because this is at its root a xml config
// file

solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java:295

• The comparison needs “than,” not “then.”

 * restricted access and with fewer replicas and shards then the number of nodes. Test if we can

solr/modules/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java:305

• “Not anymore” is unidiomatic here; use “no longer.”
  solr/modules/sql/src/java/org/apache/solr/handler/sql/functions/ArrayContainsAny.java:23
• The ArrayContainsAny example still names ARRAY_CONTAINS_ALL, so the public documentation directs users to the wrong operator. Update the example to match this class and its ARRAY_CONTAINS_ANY UDF name.

[epugh]

This was a pretty basic "go through and look at things" PR. I am hoping to enlist a few folks to review different modules based on their previous activity in those modules, though a review on everything is always nice ;-)

Module	Reviewer
analysis-extras	@chatman
clustering	@chatman
cross-dc	@sanjayDutt
cuvs	@rahulgoswami
extraction	@HoustonPutman
gcs-repository	@HoustonPutman
jwt-auth	@janhoy
langid	@janhoy
language-models	@serhiy-bzhezytskyy
ltr	@mlbiscoc
opentelemetry	@mlbiscoc
s3-repository	@janhoy
scripting	@mlbiscoc
sql	@serhiy-bzhezytskyy

[rahulgoswami]

On vacation atm. Will address this soon after.

[epugh]

This PR was too big and unwieldy to work with. I have broken it up into seperate PR's per module, and will tag folks there.

[epugh]

Description

Go through code in ./solr/modules (both source and tests) and tidy up code.

Solution

Leverage Intellij warnings

Tests

existing

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 102 out of 103 changed files in this pull request and generated 3 comments.

Suppressed comments (6)

solr/modules/scripting/src/java/org/apache/solr/scripting/xslt/XSLTResponseWriter.java:71

• The article is incorrect before “XSLT”; use “an XSLT output element.”
  solr/modules/scripting/src/java/org/apache/solr/scripting/update/ScriptUpdateProcessorFactory.java:339
• This updated description is grammatically unclear and “exceptions registered” does not describe the implementation. The method returns null when factory discovery returns null or throws a runtime exception.
  solr/modules/analysis-extras/src/java/org/apache/solr/schema/ICUCollationField.java:111
• Use “an XML configuration file”; “XML” takes “an,” and the initialism should be capitalized.

 // error via `XMLConfigFile.assertWarnOrFail(...)` is because this is at its root a xml config
// file

solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java:295

• The comparison needs “than,” not “then.”

 * restricted access and with fewer replicas and shards then the number of nodes. Test if we can

solr/modules/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java:305

• “Not anymore” is unidiomatic here; use “no longer.”
  solr/modules/sql/src/java/org/apache/solr/handler/sql/functions/ArrayContainsAny.java:23
• The ArrayContainsAny example still names ARRAY_CONTAINS_ALL, so the public documentation directs users to the wrong operator. Update the example to match this class and its ARRAY_CONTAINS_ANY UDF name.

[epugh]

This was a pretty basic "go through and look at things" PR. I am hoping to enlist a few folks to review different modules based on their previous activity in those modules, though a review on everything is always nice ;-)

Module	Reviewer
analysis-extras	@chatman
clustering	@chatman
cross-dc	@sanjayDutt
cuvs	@rahulgoswami
extraction	@HoustonPutman
gcs-repository	@HoustonPutman
jwt-auth	@janhoy
langid	@janhoy
language-models	@serhiy-bzhezytskyy
ltr	@mlbiscoc
opentelemetry	@mlbiscoc
s3-repository	@janhoy
scripting	@mlbiscoc
sql	@serhiy-bzhezytskyy

[rahulgoswami]

On vacation atm. Will address this soon after.

[epugh]

This PR was too big and unwieldy to work with. I have broken it up into seperate PR's per module, and will tag folks there.

[epugh]

Description

Go through code in ./solr/modules (both source and tests) and tidy up code.

Solution

Leverage Intellij warnings

Tests

existing

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 102 out of 103 changed files in this pull request and generated 3 comments.

Suppressed comments (6)

solr/modules/scripting/src/java/org/apache/solr/scripting/xslt/XSLTResponseWriter.java:71

• The article is incorrect before “XSLT”; use “an XSLT output element.”
  solr/modules/scripting/src/java/org/apache/solr/scripting/update/ScriptUpdateProcessorFactory.java:339
• This updated description is grammatically unclear and “exceptions registered” does not describe the implementation. The method returns null when factory discovery returns null or throws a runtime exception.
  solr/modules/analysis-extras/src/java/org/apache/solr/schema/ICUCollationField.java:111
• Use “an XML configuration file”; “XML” takes “an,” and the initialism should be capitalized.

 // error via `XMLConfigFile.assertWarnOrFail(...)` is because this is at its root a xml config
// file

solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java:295

• The comparison needs “than,” not “then.”

 * restricted access and with fewer replicas and shards then the number of nodes. Test if we can

solr/modules/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java:305

• “Not anymore” is unidiomatic here; use “no longer.”
  solr/modules/sql/src/java/org/apache/solr/handler/sql/functions/ArrayContainsAny.java:23
• The ArrayContainsAny example still names ARRAY_CONTAINS_ALL, so the public documentation directs users to the wrong operator. Update the example to match this class and its ARRAY_CONTAINS_ANY UDF name.

[epugh]

This was a pretty basic "go through and look at things" PR. I am hoping to enlist a few folks to review different modules based on their previous activity in those modules, though a review on everything is always nice ;-)

Module	Reviewer
analysis-extras	@chatman
clustering	@chatman
cross-dc	@sanjayDutt
cuvs	@rahulgoswami
extraction	@HoustonPutman
gcs-repository	@HoustonPutman
jwt-auth	@janhoy
langid	@janhoy
language-models	@serhiy-bzhezytskyy
ltr	@mlbiscoc
opentelemetry	@mlbiscoc
s3-repository	@janhoy
scripting	@mlbiscoc
sql	@serhiy-bzhezytskyy

[rahulgoswami]

On vacation atm. Will address this soon after.

[epugh]

This PR was too big and unwieldy to work with. I have broken it up into seperate PR's per module, and will tag folks there.

[epugh]

Description

Go through code in ./solr/modules (both source and tests) and tidy up code.

Solution

Leverage Intellij warnings

Tests

existing

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 102 out of 103 changed files in this pull request and generated 3 comments.

Suppressed comments (6)

solr/modules/scripting/src/java/org/apache/solr/scripting/xslt/XSLTResponseWriter.java:71

• The article is incorrect before “XSLT”; use “an XSLT output element.”
  solr/modules/scripting/src/java/org/apache/solr/scripting/update/ScriptUpdateProcessorFactory.java:339
• This updated description is grammatically unclear and “exceptions registered” does not describe the implementation. The method returns null when factory discovery returns null or throws a runtime exception.
  solr/modules/analysis-extras/src/java/org/apache/solr/schema/ICUCollationField.java:111
• Use “an XML configuration file”; “XML” takes “an,” and the initialism should be capitalized.

 // error via `XMLConfigFile.assertWarnOrFail(...)` is because this is at its root a xml config
// file

solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java:295

• The comparison needs “than,” not “then.”

 * restricted access and with fewer replicas and shards then the number of nodes. Test if we can

solr/modules/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java:305

• “Not anymore” is unidiomatic here; use “no longer.”
  solr/modules/sql/src/java/org/apache/solr/handler/sql/functions/ArrayContainsAny.java:23
• The ArrayContainsAny example still names ARRAY_CONTAINS_ALL, so the public documentation directs users to the wrong operator. Update the example to match this class and its ARRAY_CONTAINS_ANY UDF name.

[epugh]

This was a pretty basic "go through and look at things" PR. I am hoping to enlist a few folks to review different modules based on their previous activity in those modules, though a review on everything is always nice ;-)

Module	Reviewer
analysis-extras	@chatman
clustering	@chatman
cross-dc	@sanjayDutt
cuvs	@rahulgoswami
extraction	@HoustonPutman
gcs-repository	@HoustonPutman
jwt-auth	@janhoy
langid	@janhoy
language-models	@serhiy-bzhezytskyy
ltr	@mlbiscoc
opentelemetry	@mlbiscoc
s3-repository	@janhoy
scripting	@mlbiscoc
sql	@serhiy-bzhezytskyy

[rahulgoswami]

On vacation atm. Will address this soon after.

[epugh]

This PR was too big and unwieldy to work with. I have broken it up into seperate PR's per module, and will tag folks there.

[epugh]

Description

Go through code in ./solr/modules (both source and tests) and tidy up code.

Solution

Leverage Intellij warnings

Tests

existing

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 102 out of 103 changed files in this pull request and generated 3 comments.

Suppressed comments (6)

solr/modules/scripting/src/java/org/apache/solr/scripting/xslt/XSLTResponseWriter.java:71

• The article is incorrect before “XSLT”; use “an XSLT output element.”
  solr/modules/scripting/src/java/org/apache/solr/scripting/update/ScriptUpdateProcessorFactory.java:339
• This updated description is grammatically unclear and “exceptions registered” does not describe the implementation. The method returns null when factory discovery returns null or throws a runtime exception.
  solr/modules/analysis-extras/src/java/org/apache/solr/schema/ICUCollationField.java:111
• Use “an XML configuration file”; “XML” takes “an,” and the initialism should be capitalized.

 // error via `XMLConfigFile.assertWarnOrFail(...)` is because this is at its root a xml config
// file

solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java:295

• The comparison needs “than,” not “then.”

 * restricted access and with fewer replicas and shards then the number of nodes. Test if we can

solr/modules/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java:305

• “Not anymore” is unidiomatic here; use “no longer.”
  solr/modules/sql/src/java/org/apache/solr/handler/sql/functions/ArrayContainsAny.java:23
• The ArrayContainsAny example still names ARRAY_CONTAINS_ALL, so the public documentation directs users to the wrong operator. Update the example to match this class and its ARRAY_CONTAINS_ANY UDF name.

[epugh]

This was a pretty basic "go through and look at things" PR. I am hoping to enlist a few folks to review different modules based on their previous activity in those modules, though a review on everything is always nice ;-)

Module	Reviewer
analysis-extras	@chatman
clustering	@chatman
cross-dc	@sanjayDutt
cuvs	@rahulgoswami
extraction	@HoustonPutman
gcs-repository	@HoustonPutman
jwt-auth	@janhoy
langid	@janhoy
language-models	@serhiy-bzhezytskyy
ltr	@mlbiscoc
opentelemetry	@mlbiscoc
s3-repository	@janhoy
scripting	@mlbiscoc
sql	@serhiy-bzhezytskyy

[rahulgoswami]

On vacation atm. Will address this soon after.

[epugh]

This PR was too big and unwieldy to work with. I have broken it up into seperate PR's per module, and will tag folks there.

[epugh]

Description

Go through code in ./solr/modules (both source and tests) and tidy up code.

Solution

Leverage Intellij warnings

Tests

existing

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 102 out of 103 changed files in this pull request and generated 3 comments.

Suppressed comments (6)

solr/modules/scripting/src/java/org/apache/solr/scripting/xslt/XSLTResponseWriter.java:71

• The article is incorrect before “XSLT”; use “an XSLT output element.”
  solr/modules/scripting/src/java/org/apache/solr/scripting/update/ScriptUpdateProcessorFactory.java:339
• This updated description is grammatically unclear and “exceptions registered” does not describe the implementation. The method returns null when factory discovery returns null or throws a runtime exception.
  solr/modules/analysis-extras/src/java/org/apache/solr/schema/ICUCollationField.java:111
• Use “an XML configuration file”; “XML” takes “an,” and the initialism should be capitalized.

 // error via `XMLConfigFile.assertWarnOrFail(...)` is because this is at its root a xml config
// file

solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java:295

• The comparison needs “than,” not “then.”

 * restricted access and with fewer replicas and shards then the number of nodes. Test if we can

solr/modules/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java:305

• “Not anymore” is unidiomatic here; use “no longer.”
  solr/modules/sql/src/java/org/apache/solr/handler/sql/functions/ArrayContainsAny.java:23
• The ArrayContainsAny example still names ARRAY_CONTAINS_ALL, so the public documentation directs users to the wrong operator. Update the example to match this class and its ARRAY_CONTAINS_ANY UDF name.

[epugh]

This was a pretty basic "go through and look at things" PR. I am hoping to enlist a few folks to review different modules based on their previous activity in those modules, though a review on everything is always nice ;-)

Module	Reviewer
analysis-extras	@chatman
clustering	@chatman
cross-dc	@sanjayDutt
cuvs	@rahulgoswami
extraction	@HoustonPutman
gcs-repository	@HoustonPutman
jwt-auth	@janhoy
langid	@janhoy
language-models	@serhiy-bzhezytskyy
ltr	@mlbiscoc
opentelemetry	@mlbiscoc
s3-repository	@janhoy
scripting	@mlbiscoc
sql	@serhiy-bzhezytskyy

[rahulgoswami]

On vacation atm. Will address this soon after.

[epugh]

This PR was too big and unwieldy to work with. I have broken it up into seperate PR's per module, and will tag folks there.

[epugh]

Description

Go through code in ./solr/modules (both source and tests) and tidy up code.

Solution

Leverage Intellij warnings

Tests

existing

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 102 out of 103 changed files in this pull request and generated 3 comments.

Suppressed comments (6)

solr/modules/scripting/src/java/org/apache/solr/scripting/xslt/XSLTResponseWriter.java:71

• The article is incorrect before “XSLT”; use “an XSLT output element.”
  solr/modules/scripting/src/java/org/apache/solr/scripting/update/ScriptUpdateProcessorFactory.java:339
• This updated description is grammatically unclear and “exceptions registered” does not describe the implementation. The method returns null when factory discovery returns null or throws a runtime exception.
  solr/modules/analysis-extras/src/java/org/apache/solr/schema/ICUCollationField.java:111
• Use “an XML configuration file”; “XML” takes “an,” and the initialism should be capitalized.

 // error via `XMLConfigFile.assertWarnOrFail(...)` is because this is at its root a xml config
// file

solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java:295

• The comparison needs “than,” not “then.”

 * restricted access and with fewer replicas and shards then the number of nodes. Test if we can

solr/modules/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java:305

• “Not anymore” is unidiomatic here; use “no longer.”
  solr/modules/sql/src/java/org/apache/solr/handler/sql/functions/ArrayContainsAny.java:23
• The ArrayContainsAny example still names ARRAY_CONTAINS_ALL, so the public documentation directs users to the wrong operator. Update the example to match this class and its ARRAY_CONTAINS_ANY UDF name.

[epugh]

This was a pretty basic "go through and look at things" PR. I am hoping to enlist a few folks to review different modules based on their previous activity in those modules, though a review on everything is always nice ;-)

Module	Reviewer
analysis-extras	@chatman
clustering	@chatman
cross-dc	@sanjayDutt
cuvs	@rahulgoswami
extraction	@HoustonPutman
gcs-repository	@HoustonPutman
jwt-auth	@janhoy
langid	@janhoy
language-models	@serhiy-bzhezytskyy
ltr	@mlbiscoc
opentelemetry	@mlbiscoc
s3-repository	@janhoy
scripting	@mlbiscoc
sql	@serhiy-bzhezytskyy

[rahulgoswami]

On vacation atm. Will address this soon after.

[epugh]

This PR was too big and unwieldy to work with. I have broken it up into seperate PR's per module, and will tag folks there.

[epugh]

Description

Go through code in ./solr/modules (both source and tests) and tidy up code.

Solution

Leverage Intellij warnings

Tests

existing

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 102 out of 103 changed files in this pull request and generated 3 comments.

Suppressed comments (6)

solr/modules/scripting/src/java/org/apache/solr/scripting/xslt/XSLTResponseWriter.java:71

• The article is incorrect before “XSLT”; use “an XSLT output element.”
  solr/modules/scripting/src/java/org/apache/solr/scripting/update/ScriptUpdateProcessorFactory.java:339
• This updated description is grammatically unclear and “exceptions registered” does not describe the implementation. The method returns null when factory discovery returns null or throws a runtime exception.
  solr/modules/analysis-extras/src/java/org/apache/solr/schema/ICUCollationField.java:111
• Use “an XML configuration file”; “XML” takes “an,” and the initialism should be capitalized.

 // error via `XMLConfigFile.assertWarnOrFail(...)` is because this is at its root a xml config
// file

solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java:295

• The comparison needs “than,” not “then.”

 * restricted access and with fewer replicas and shards then the number of nodes. Test if we can

solr/modules/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java:305

• “Not anymore” is unidiomatic here; use “no longer.”
  solr/modules/sql/src/java/org/apache/solr/handler/sql/functions/ArrayContainsAny.java:23
• The ArrayContainsAny example still names ARRAY_CONTAINS_ALL, so the public documentation directs users to the wrong operator. Update the example to match this class and its ARRAY_CONTAINS_ANY UDF name.

[epugh]

This was a pretty basic "go through and look at things" PR. I am hoping to enlist a few folks to review different modules based on their previous activity in those modules, though a review on everything is always nice ;-)

Module	Reviewer
analysis-extras	@chatman
clustering	@chatman
cross-dc	@sanjayDutt
cuvs	@rahulgoswami
extraction	@HoustonPutman
gcs-repository	@HoustonPutman
jwt-auth	@janhoy
langid	@janhoy
language-models	@serhiy-bzhezytskyy
ltr	@mlbiscoc
opentelemetry	@mlbiscoc
s3-repository	@janhoy
scripting	@mlbiscoc
sql	@serhiy-bzhezytskyy

[rahulgoswami]

On vacation atm. Will address this soon after.

[epugh]

This PR was too big and unwieldy to work with. I have broken it up into seperate PR's per module, and will tag folks there.